marcel

marcel closed issue marcel/familienarchiv#340

2026-04-26 21:53:20 +02:00

feat(search): add direct page-jump control to document search pagination

marcel merged pull request marcel/familienarchiv#346

2026-04-26 21:53:18 +02:00

feat(search): add direct page-jump control to document search pagination (#340)

marcel pushed to feat/issue-343-person-dropdown-clipping at marcel/familienarchiv

2026-04-26 21:52:15 +02:00

a5856e2f02 test(persons): fix E2E flakiness — replace waitForTimeout with waitForListbox, remove conditional assertions, fix data-hydrated selector

afe1acb05d test(persons): add ArrowDown forward-wrap unit test for keyboard navigation

Compare 2 commits »

marcel commented on pull request marcel/familienarchiv#347

2026-04-26 21:52:08 +02:00

feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Leonie Voss — UI/UX Design Lead

Verdict: ✅ Approved

What I checked

Brand token usage, danger signal visibility, touch targets, accessibility, mobile layout, and the senior-audi…

marcel commented on pull request marcel/familienarchiv#347

2026-04-26 21:51:52 +02:00

feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Sara Holt — QA Engineer

Verdict: ✅ Approved

What I checked

TDD evidence, spec file quality, mock correctness, test coverage completeness, and test pyramid placement.

###…

marcel commented on pull request marcel/familienarchiv#347

2026-04-26 21:51:37 +02:00

feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Nora "NullX" Steiner — Security Engineer

Verdict: ✅ Approved

What I checked

Authorization surface changes, action routing security, CSRF exposure, server action guard…

marcel commented on pull request marcel/familienarchiv#347

2026-04-26 21:51:27 +02:00

feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Elicit — Requirements Engineer

Verdict: ✅ Approved

What I checked

Acceptance criteria traceability against the Decision Queue resolution, scope alignment, i18n completeness,…

marcel commented on pull request marcel/familienarchiv#347

2026-04-26 21:51:17 +02:00

feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I checked

Infrastructure impact, CI pipeline, SvelteKit routing, E2E test files, Docker Compose, and diff…

marcel commented on pull request marcel/familienarchiv#347

2026-04-26 21:51:07 +02:00

feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

What I checked

TDD evidence, Svelte 5 patterns, mock correctness, component size, naming, dead code, and diff…

marcel commented on pull request marcel/familienarchiv#347

2026-04-26 21:50:56 +02:00

feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Markus Keller — Application Architect

Verdict: ✅ Approved

What I checked

Module boundaries, component ownership, layer separation, dead code elimination, and the {#key}…

marcel pushed to feat/issue-342-person-merge-inline at marcel/familienarchiv

2026-04-26 21:50:09 +02:00

f162c9b55b feat(persons): show merge panel inline on edit page, remove Gefahrenzone accordion

marcel commented on pull request marcel/familienarchiv#346

2026-04-26 21:46:54 +02:00

feat(search): add direct page-jump control to document search pagination (#340)

Decision Queue — Round 2

All round 1 concerns resolved. All personas approve.

Resolved This Round

marcel closed issue marcel/familienarchiv#341

2026-04-26 21:46:47 +02:00

bug(viewer): "Annotieren anzeigen" text has insufficient contrast in light mode

marcel pushed to main at marcel/familienarchiv

2026-04-26 21:46:46 +02:00

2c5877ea9e fix(a11y): fix ProgressRing text label contrast and add no-restricted-syntax lint rule for text-accent

cfbe33140c fix(viewer): replace text-accent with text-primary on annotation toggle inactive state

Compare 2 commits »

marcel merged pull request marcel/familienarchiv#349

2026-04-26 21:46:45 +02:00

fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

marcel commented on pull request marcel/familienarchiv#346

2026-04-26 21:46:38 +02:00

feat(search): add direct page-jump control to document search pagination (#340)

Elicit (Requirements Engineer) — Round 2 Review

Verifying implementation against #340 acceptance criteria.

From issue #340:

Numbered page buttons visible on desktop (sm:+), hidden…

marcel commented on pull request marcel/familienarchiv#346

2026-04-26 21:46:25 +02:00

feat(search): add direct page-jump control to document search pagination (#340)

Tobias (DevOps) — Round 2 Review

Infra and CI impact assessment.

Bundle size — no new npm packages. Pagination.svelte adds ~50 lines of Svelte template and ~40 lines of TypeScript…

marcel commented on pull request marcel/familienarchiv#346

2026-04-26 21:46:13 +02:00

feat(search): add direct page-jump control to document search pagination (#340)

Nora (Security) — Round 2 Review

This PR is a pure frontend pagination component. Security surface is minimal but I'll confirm it explicitly.

XSS / injection: makeHref(entry - 1)…

marcel commented on pull request marcel/familienarchiv#346

2026-04-26 21:46:04 +02:00

feat(search): add direct page-jump control to document search pagination (#340)

Markus (Architect) — Round 2 Review

Reviewing structural and component design concerns.

Component contract — Pagination.svelte props are unchanged: page (0-indexed), totalPages,…

marcel pushed to main at marcel/familienarchiv

2026-04-26 21:45:52 +02:00

e8d1835ae1 feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344) (#351)