• Joined on 2026-03-17
marcel commented on issue marcel/familienarchiv#345 2026-04-26 20:00:24 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action to transcription panel

🧪 Sara Holt — QA Engineer

Observations

  • The AC has four testable behaviors: button visible when ≥ 2 unreviewed blocks; all blocks marked on click; button hidden/disabled when all…
marcel commented on issue marcel/familienarchiv#342 2026-04-26 20:00:24 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible

🗳️ Decision Queue

Consolidated decisions requiring human input before implementation begins.


Theme 1: Scope of "Gefahrenzone" removal

Question: The accordion `PersonDangerZone.s…

marcel commented on issue marcel/familienarchiv#340 2026-04-26 20:00:19 +02:00
feat(search): add direct page-jump control to document search pagination

🧪 Sara Holt — QA Engineer

Observations

  • The existing Pagination.svelte.spec.ts is a solid baseline: vitest-browser-svelte, real DOM, role/testid selectors, no internal state…
marcel commented on issue marcel/familienarchiv#344 2026-04-26 20:00:13 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell icon

🗳️ Decision Queue

Consolidated open decisions requiring human context before implementation.


Theme: cursor-pointer scope — global vs. per-component

From Leonie & Markus

Shou…

marcel commented on issue marcel/familienarchiv#343 2026-04-26 20:00:12 +02:00
bug(persons): person selection dropdown is visually clipped / cut off

⚙️ Tobias Wendt — DevOps & Platform

Observations

  • This is a frontend CSS/JS positioning fix with zero infrastructure impact. No new containers, services, or build steps are required. -…
marcel commented on issue marcel/familienarchiv#345 2026-04-26 20:00:10 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action to transcription panel

🔒 Nora "NullX" Steiner — Security Engineer

Observations

  • The existing PUT /{blockId}/review is correctly guarded with @RequirePermission(Permission.WRITE_ALL). The new bulk endpoint…
marcel commented on issue marcel/familienarchiv#342 2026-04-26 20:00:10 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible

👨‍💻 Leonie Voss — UI/UX Design Lead

Observations

  • The current PersonMergePanel.svelte container uses border-line bg-surface — neutral styling. The PersonDangerZone.svelte
marcel commented on issue marcel/familienarchiv#341 2026-04-26 20:00:08 +02:00
bug(viewer): "Annotieren anzeigen" text has insufficient contrast in light mode

📋 Elicit — Requirements Engineer

Observations

  • The issue body is clear and well-structured: steps to reproduce, expected vs. actual, and one WCAG-referenced acceptance criterion. This…
marcel commented on issue marcel/familienarchiv#339 2026-04-26 20:00:07 +02:00
feat(viewer): show delete icon directly on transcription annotation

🏗️ Tobias Wendt — DevOps

Observations

  • This is a purely frontend UI change. No Docker Compose, CI pipeline, or infrastructure changes are required.
  • The delete endpoint is already…
marcel commented on issue marcel/familienarchiv#340 2026-04-26 20:00:06 +02:00
feat(search): add direct page-jump control to document search pagination

🔒 Nora "NullX" Steiner — Security Engineer

Observations

  • The page parameter is user-controlled input that travels via URL query string → +page.server.ts → backend. The existing…
marcel commented on issue marcel/familienarchiv#343 2026-04-26 20:00:03 +02:00
bug(persons): person selection dropdown is visually clipped / cut off

🎨 Leonie Voss — UX Design Lead

Observations

  • The clipping bug means that on document edit, the person picker's dropdown list is unreachable for users who cannot mouse outside the card…
marcel commented on issue marcel/familienarchiv#339 2026-04-26 20:00:01 +02:00
feat(viewer): show delete icon directly on transcription annotation

🧪 Sara Holt — QA Engineer

Observations

  • The existing TranscriptionBlock.svelte delete path already has an integration path in +page.svelte (deleteBlock → fetch DELETE → filter…
marcel commented on issue marcel/familienarchiv#344 2026-04-26 20:00:00 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell icon

📋 Elicit — Requirements Engineer

Observations

  • The user story, context, and acceptance criteria are well-formed and implementation-ready.
  • AC1 ("cursor changes to pointer") and AC2…
marcel commented on issue marcel/familienarchiv#341 2026-04-26 19:59:59 +02:00
bug(viewer): "Annotieren anzeigen" text has insufficient contrast in light mode

🛠️ Tobias Wendt — DevOps & Platform Engineer

Observations

  • This is a frontend styling bug with no infrastructure or CI implications. No Docker Compose, pipeline, or deployment…
marcel commented on issue marcel/familienarchiv#345 2026-04-26 19:59:59 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action to transcription panel

👨‍💻 Felix Brandt — Fullstack Developer

Observations

  • The reviewToggle function in +page.svelte (line 108–115) makes one PUT per block. The bulk action must NOT be implemented by…
marcel commented on issue marcel/familienarchiv#340 2026-04-26 19:59:54 +02:00
feat(search): add direct page-jump control to document search pagination

📋 Elicit — Requirements Engineer

Observations

The issue is well-written and production-ready for implementation. User story, context, and acceptance criteria are present and testable. A…

marcel commented on issue marcel/familienarchiv#342 2026-04-26 19:59:54 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible

👨‍💻 Sara Holt — QA Engineer

Observations

  • The existing page.server.spec.ts in persons/[id]/ covers the detail page load function. It currently has no test for form actions because…
marcel commented on issue marcel/familienarchiv#341 2026-04-26 19:59:51 +02:00
bug(viewer): "Annotieren anzeigen" text has insufficient contrast in light mode

🧪 Sara Holt — QA Engineer & Test Strategist

Observations

  • No test covers the annotation toggle in any layer. The three existing tests in PdfViewer.svelte.spec.ts cover navigation…
marcel commented on issue marcel/familienarchiv#344 2026-04-26 19:59:48 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell icon

⚙️ Tobias Wendt — DevOps & Platform Engineer

Observations

  • Pure frontend cosmetic change. No infrastructure, Docker Compose, CI pipeline, or environment configuration is affected.
  • No…
marcel commented on issue marcel/familienarchiv#343 2026-04-26 19:59:47 +02:00
bug(persons): person selection dropdown is visually clipped / cut off

🧪 Sara Holt — QA Engineer

Observations

  • There are currently no Playwright E2E tests that verify the person dropdown renders unclipped. This bug was caught manually — it won't be…