• Joined on 2026-03-17
marcel commented on issue marcel/familienarchiv#339 2026-04-26 19:59:47 +02:00
feat(viewer): show delete icon directly on transcription annotation

🎨 Leonie Voss — UI/UX Expert

Observations

  • The primary audience for the transcription panel is 60+ transcribers working on laptop/tablet. Hover-only affordances are a high-risk…
marcel commented on issue marcel/familienarchiv#342 2026-04-26 19:59:43 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible

👨‍💻 Nora "NullX" Steiner — Security Engineer

Observations

  • The merge action in edit/+page.server.ts is already gated by the canWrite check in the load function: `if (!canWrite)…
marcel commented on issue marcel/familienarchiv#344 2026-04-26 19:59:42 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell icon

🧪 Sara Holt — QA Engineer

Observations

  • The acceptance criteria are clear and testable: cursor changes to pointer on hover, tooltip appears on hover, behavior matches the color-mode…
marcel commented on issue marcel/familienarchiv#345 2026-04-26 19:59:42 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action to transcription panel

🏗️ Markus Keller — Application Architect

Observations

  • The existing per-block review endpoint PUT /api/documents/{documentId}/transcription-blocks/{blockId}/review correctly toggles a…
marcel commented on issue marcel/familienarchiv#340 2026-04-26 19:59:38 +02:00
feat(search): add direct page-jump control to document search pagination

🚀 Tobias Wendt — DevOps & Platform Engineer

Observations

  • This is a pure frontend change with no backend impact, no new dependencies, no new containers, and no CI configuration changes…
marcel commented on issue marcel/familienarchiv#341 2026-04-26 19:59:38 +02:00
bug(viewer): "Annotieren anzeigen" text has insufficient contrast in light mode

🔒 Nora "NullX" Steiner — Application Security Engineer

Observations

  • This is an accessibility compliance bug, not a security vulnerability. No attack surface is affected.
  • From a…
marcel commented on issue marcel/familienarchiv#343 2026-04-26 19:59:33 +02:00
bug(persons): person selection dropdown is visually clipped / cut off

🔒 Nora "NullX" Steiner — Security Engineer

Observations

  • This is a purely presentational bug. There are no new attack surfaces introduced by fixing it.
  • The fixed-position approach…
marcel commented on issue marcel/familienarchiv#342 2026-04-26 19:59:32 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible

👨‍💻 Elicit — Requirements Engineer

Observations

  • The acceptance criteria are testable and well-formed. Three behavioral assertions cover the core change; one structural assertion…
marcel commented on issue marcel/familienarchiv#339 2026-04-26 19:59:31 +02:00
feat(viewer): show delete icon directly on transcription annotation

🛡️ Nora "NullX" Steiner — Security Expert

Observations

  • The backend delete endpoint DELETE /api/documents/{documentId}/transcription-blocks/{blockId} is already protected with…
marcel commented on issue marcel/familienarchiv#344 2026-04-26 19:59:30 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell icon

🔒 Nora Steiner — Application Security Engineer

Observations

  • No security implications in the core change. Adding cursor-pointer and a title tooltip to a button introduces no new…
marcel commented on issue marcel/familienarchiv#340 2026-04-26 19:59:29 +02:00
feat(search): add direct page-jump control to document search pagination

👨‍💻 Felix Brandt — Fullstack Developer

Observations

  • Pagination.svelte is currently 80 lines and handles one visual concern: prev/next navigation. A page-jump addition (whether…
marcel commented on issue marcel/familienarchiv#341 2026-04-26 19:59:28 +02:00
bug(viewer): "Annotieren anzeigen" text has insufficient contrast in light mode

🏗️ Markus Keller — Application Architect

Observations

  • This is a purely presentational bug with no architectural surface — the fix is a single token swap in one component. No module…
marcel commented on issue marcel/familienarchiv#343 2026-04-26 19:59:23 +02:00
bug(persons): person selection dropdown is visually clipped / cut off

💻 Felix Brandt — Fullstack Developer

Observations

  • PersonTypeahead (line 144–167): The dropdown uses class="absolute top-full left-0 z-50 …". The outer wrapper `<div…
marcel commented on issue marcel/familienarchiv#344 2026-04-26 19:59:23 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell icon

🏗️ Markus Keller — Application Architect

Observations

  • This is a pure frontend cosmetic change: two HTML attributes on an existing <button> element. No architectural implications. -…
marcel commented on issue marcel/familienarchiv#339 2026-04-26 19:59:21 +02:00
feat(viewer): show delete icon directly on transcription annotation

👩‍💻 Felix Brandt — Fullstack Developer

Observations

  • AnnotationShape.svelte already renders a numbered badge in the top-left corner. The delete icon should follow the same pattern:…
marcel commented on issue marcel/familienarchiv#342 2026-04-26 19:59:20 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible

👨‍💻 Tobias Wendt — DevOps & Platform Engineer

Observations

  • This is a pure frontend refactor — no infrastructure, Docker Compose, CI pipeline, or environment config changes needed. -…
marcel commented on issue marcel/familienarchiv#341 2026-04-26 19:59:19 +02:00
bug(viewer): "Annotieren anzeigen" text has insufficient contrast in light mode

👨‍💻 Felix Brandt — Fullstack Developer

Observations

  • The offending line is in /frontend/src/lib/components/PdfControls.svelte at line 92–94:
    class="flex items-center…
    
marcel commented on issue marcel/familienarchiv#344 2026-04-26 19:59:15 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell icon

👨‍💻 Felix Brandt — Fullstack Developer

Observations

  • The implementation diff is tiny and well-scoped: two additions to an existing <button> element in NotificationBell.svelte. No…
marcel commented on issue marcel/familienarchiv#342 2026-04-26 19:59:14 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible

👨‍💻 Felix Brandt — Fullstack Developer

Observations

  • PersonMergePanel.svelte is already a well-factored standalone component (84 lines). It renders the form, the two-step confirm…
marcel commented on issue marcel/familienarchiv#340 2026-04-26 19:59:12 +02:00
feat(search): add direct page-jump control to document search pagination

🏗️ Markus Keller — Application Architect

Observations

  • The pagination machinery is already well-structured. buildSearchParams() in +page.svelte is a single source of truth for URL…