• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:08:43 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

⚙️ Tobias Wendt — DevOps & Platform Engineer (@tobiwendt)

Verdict: Approved

No infrastructure changes. No new dependencies. No Docker Compose, CI pipeline, or environment config…

marcel commented on pull request marcel/familienarchiv#352 2026-04-26 21:08:42 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: Approved

Backend

The service method is clean and readable. Guard clause pattern used correctly: if (!block.isReviewed())

marcel commented on pull request marcel/familienarchiv#349 2026-04-26 21:08:40 +02:00
fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

🏗️ Markus Keller — Senior Application Architect

Verdict: Approved

What I checked

  • Module boundary compliance
  • Separation of concerns
  • Token system integrity
  • Lint rule…
marcel commented on pull request marcel/familienarchiv#350 2026-04-26 21:08:39 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

What I checked

TDD evidence, naming, function size, Svelte 5 rules, ARIA correctness, dead…

marcel commented on pull request marcel/familienarchiv#347 2026-04-26 21:08:39 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Elicit — Requirements Engineer

Verdict: Approved

What I checked

Acceptance criteria traceability, scope alignment with the Decision Queue resolution, and requirement…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:08:38 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🛡️ Nora "NullX" Steiner — Security Expert

Verdict: ⚠️ Approved with concerns

What I checked

Authorization enforcement, error handling, and new API surface.

Blockers

**Orphaned…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:08:37 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

The core implementation is solid and follows the project conventions correctly. $derived.by(),…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:08:35 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

👨‍💻 Felix Brandt — Senior Fullstack Developer (@felixbrandt)

Verdict: Approved

Clean, minimal, and DRY. This is exactly what was discussed in the issue review. The $derived

marcel commented on pull request marcel/familienarchiv#352 2026-04-26 21:08:28 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)

🏗️ Markus Keller — Application Architect

Verdict: Approved

What I checked

The pre-implementation review (issue #345) already locked in the structural decisions: single…

marcel commented on pull request marcel/familienarchiv#349 2026-04-26 21:08:27 +02:00
fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: Approved

What I checked

  • TDD evidence (test-first discipline)
  • Test quality: naming, structure, assertion style -…
marcel commented on pull request marcel/familienarchiv#347 2026-04-26 21:08:26 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

What I checked

Infrastructure impact, CI pipeline, SvelteKit routing side effects, Docker Compose, E2E test path…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:08:25 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

What I checked

Code clarity, Svelte 5 patterns, component sizing, and naming.

Blockers

**`ari…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:08:21 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

🏗️ Markus Keller — Application Architect (@mkeller)

Verdict: Approved

This is a well-scoped cosmetic fix with no architectural implications. The diff is exactly what was agreed in…

marcel commented on pull request marcel/familienarchiv#350 2026-04-26 21:08:20 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

🏗️ Markus Keller — Application Architect

Verdict: Approved

What I checked

The architectural concern here was whether the fix correctly addresses the root cause (CSS stacking…

marcel commented on pull request marcel/familienarchiv#347 2026-04-26 21:08:20 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

What I checked

TDD evidence, Svelte 5 patterns, component size, naming, dead code, test quality,…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:08:17 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🏗️ Markus Keller — Application Architect

Verdict: Approved

What I checked

Layer boundaries, prop-chain design, and module coupling.

Findings

**Prop chain implementation is…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:08:16 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🏗️ Markus Keller — Application Architect

Verdict: Approved

The architecture is clean. All page-jump logic lives exclusively inside Pagination.svelte — the +page.svelte

marcel commented on pull request marcel/familienarchiv#349 2026-04-26 21:08:14 +02:00
fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

🎨 Leonie Voss — UI/UX Design Lead & Accessibility Advocate

Verdict: Approved

What I checked

  • Brand token usage in changed components
  • WCAG contrast ratios for both toggle…
marcel commented on pull request marcel/familienarchiv#347 2026-04-26 21:07:54 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Markus Keller — Application Architect

Verdict: Approved

What I checked

Module boundaries, component ownership, dead code, layer separation, and the {#key} state-reset…

marcel created pull request marcel/familienarchiv#352 2026-04-26 21:07:49 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)