• Joined on 2026-03-17
marcel commented on issue marcel/familienarchiv#332 2026-04-26 15:48:17 +02:00
refactor: bulk-edit follow-ups deferred from PR #331

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Observations

M2 — Focus ring on DocumentRow checkbox is a confirmed WCAG 2.1 AA SC 2.4.7 failure. The `<label data-testid="bul…

marcel commented on issue marcel/familienarchiv#332 2026-04-26 15:47:53 +02:00
refactor: bulk-edit follow-ups deferred from PR #331

🧪 Sara Holt — Senior QA Engineer

Observations

M4 — The integration test is the right call; the Mockito suite is structurally blind here. applyBulkEditToDocument is annotated…

marcel commented on issue marcel/familienarchiv#332 2026-04-26 15:47:28 +02:00
refactor: bulk-edit follow-ups deferred from PR #331

🔒 Nora "NullX" Steiner — Application Security Engineer

Observations

M1 — CWE-209: Information Exposure via BulkEditError.message. The current code in DocumentController.patchBulk

marcel commented on issue marcel/familienarchiv#332 2026-04-26 15:47:07 +02:00
refactor: bulk-edit follow-ups deferred from PR #331

🏗️ Markus Keller — Application Architect

Observations

S3 — onMount data fetch is a confirmed SSR violation. I verified it: +page.svelte imports onMount from svelte and calls…

marcel commented on issue marcel/familienarchiv#332 2026-04-26 15:46:42 +02:00
refactor: bulk-edit follow-ups deferred from PR #331

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

M1 — BulkEditError.message is confirmed free-form. BulkEditError.java is a one-liner record with String message. The…

marcel commented on pull request marcel/familienarchiv#337 2026-04-26 15:19:39 +02:00
feat(audit): track user management events in audit log (#336)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: Approved

This PR is entirely backend — new AuditKind values, service-layer audit emission, a new query method, and…

marcel commented on pull request marcel/familienarchiv#337 2026-04-26 15:19:31 +02:00
feat(audit): track user management events in audit log (#336)

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

No infrastructure changes in this PR — no Compose changes, no new CI steps, no Dockerfile modifications, no new…

marcel commented on pull request marcel/familienarchiv#337 2026-04-26 15:19:24 +02:00
feat(audit): track user management events in audit log (#336)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

The test coverage is good at the unit layer — 7 new unit tests with clear names, proper Arrange-Act-Asser…

marcel commented on pull request marcel/familienarchiv#337 2026-04-26 15:19:12 +02:00
feat(audit): track user management events in audit log (#336)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

No new injection vectors. Parameterized JPQL. @RequirePermission(ADMIN_USER) is already on…

marcel commented on pull request marcel/familienarchiv#337 2026-04-26 15:18:54 +02:00
feat(audit): track user management events in audit log (#336)

🏗️ Markus Keller — Application Architect

Verdict: Approved

The structural choices here are sound. AuditService is injected into UserService via constructor — service calls…

marcel commented on pull request marcel/familienarchiv#337 2026-04-26 15:18:46 +02:00
feat(audit): track user management events in audit log (#336)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

TDD evidence is strong — the 7 new unit tests and the integration test clearly cover every branch.…

marcel pushed to feat/issue-336-audit-user-management at marcel/familienarchiv 2026-04-26 15:16:34 +02:00
77affcfb4f test(audit): integration test — create + delete user produces ordered audit entries
36529f7e11 feat(audit): add findRecentUserManagementEvents query method
eb8f9d4dc4 feat(audit): emit GROUP_MEMBERSHIP_CHANGED when admin updates user groups
a736b7399a feat(audit): emit USER_DELETED when admin removes a user
e7c7f801c9 feat(audit): emit USER_CREATED when admin creates a new user
Compare 33 commits »
marcel created pull request marcel/familienarchiv#337 2026-04-26 15:13:10 +02:00
feat(audit): track user management events in audit log (#336)
marcel pushed to feat/issue-336-audit-user-management at marcel/familienarchiv 2026-04-26 15:12:53 +02:00
dd1bd837ad test(audit): integration test — create + delete user produces ordered audit entries
d03521724c feat(audit): add findRecentUserManagementEvents query method
3fac8b4e7f feat(audit): emit GROUP_MEMBERSHIP_CHANGED when admin updates user groups
81387b2f1b feat(audit): emit USER_DELETED when admin removes a user
9cd48007a0 feat(audit): emit USER_CREATED when admin creates a new user
Compare 10 commits »
marcel created branch feat/issue-336-audit-user-management in marcel/familienarchiv 2026-04-26 15:12:53 +02:00
marcel commented on issue marcel/familienarchiv#336 2026-04-26 15:09:22 +02:00
feat(audit): track user management events in audit log (USER_CREATED, USER_DELETED, GROUP_MEMBERSHIP_CHANGED)

Implementation complete

All acceptance criteria met. 1362 backend tests pass (0 failures).

What was implemented

New AuditKind values (audit/AuditKind.java)

  • USER_CREATED —…
marcel commented on issue marcel/familienarchiv#336 2026-04-26 14:28:47 +02:00
feat(audit): track user management events in audit log (USER_CREATED, USER_DELETED, GROUP_MEMBERSHIP_CHANGED)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

No UI concerns from my angle for this issue — scope is explicitly backend-only (new AuditKind values, service-layer logging calls,…

marcel commented on issue marcel/familienarchiv#336 2026-04-26 14:28:39 +02:00
feat(audit): track user management events in audit log (USER_CREATED, USER_DELETED, GROUP_MEMBERSHIP_CHANGED)

📋 Elicit — Requirements Engineer

Observations

  • The spec is well-structured and testable. User story, explicit payload table, in/out-of-scope boundaries, and AC checklist — this is…
marcel commented on issue marcel/familienarchiv#336 2026-04-26 14:28:25 +02:00
feat(audit): track user management events in audit log (USER_CREATED, USER_DELETED, GROUP_MEMBERSHIP_CHANGED)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Observations

  • No infrastructure work in this issue. New enum values in AuditKind work without a Flyway migration because kind is…
marcel commented on issue marcel/familienarchiv#336 2026-04-26 14:28:15 +02:00
feat(audit): track user management events in audit log (USER_CREATED, USER_DELETED, GROUP_MEMBERSHIP_CHANGED)

🧪 Sara Holt — QA Engineer & Test Strategist

Observations

  • The AC test coverage plan is sound at the unit level. Mock AuditService, assert log() is called with the correct…