marcel

marcel pushed to main at marcel/familienarchiv

2026-04-26 13:37:41 +02:00

5062513ae6 refactor(persons): extract inputCls/labelCls and PersonFormData type

24d5381775 refactor(persons): rename page.server.test.ts to normalizePersonType.test.ts

826283afcb test(persons): replace fragile CSS class tests with aria-checked behavior tests

1d5f99a2c8 a11y(persons): add aria-label to PersonTypeSelector radiogroup

5961bfb916 test(persons): assert error code in createPerson_returns400_whenPersonTypeIsSkip

Compare 27 commits »

marcel merged pull request marcel/familienarchiv#333

2026-04-26 13:37:40 +02:00

feat(persons): surface personType + title in forms and detail card

marcel commented on issue marcel/familienarchiv#324

2026-04-26 13:10:38 +02:00

feat(admin): /admin lands on a real dashboard instead of redirecting to /admin/users

📋 Elicit — Requirements Engineer

Requirements discussion, 2026-04-26. Nine open items worked through; all resolved.

Resolved items

1. Pending invites data source `InviteToken.is…

marcel opened issue marcel/familienarchiv#334

2026-04-26 13:03:54 +02:00

feat(admin): Storage panel on admin dashboard — MinIO admin API integration

marcel commented on issue marcel/familienarchiv#319

2026-04-26 12:47:01 +02:00

fix(i18n): translate viewer + Transcribe panel controls so EN/ES locales do not show German labels

🗳️ Decision Queue — Action Required

1 decision needs your input before implementation starts.

UX / Translations

**"Mark for training" vs "Mark for OCR training" in EN (and ES…

marcel commented on issue marcel/familienarchiv#319

2026-04-26 12:46:47 +02:00

fix(i18n): translate viewer + Transcribe panel controls so EN/ES locales do not show German labels

📋 Elicit — Requirements Engineer

Observations

The issue is well-scoped with explicit non-goals. The acceptance criteria are testable and traceable to specific violations. This is one…

marcel commented on issue marcel/familienarchiv#319

2026-04-26 12:46:39 +02:00

fix(i18n): translate viewer + Transcribe panel controls so EN/ES locales do not show German labels

🚀 Tobias Wendt — DevOps & Platform Engineer

Observations

No infrastructure changes, no new npm dependencies, no config changes. The change touches only *.svelte components and…

marcel commented on issue marcel/familienarchiv#319

2026-04-26 12:46:32 +02:00

fix(i18n): translate viewer + Transcribe panel controls so EN/ES locales do not show German labels

🎨 Leonie Voss — Senior UX Designer & Accessibility Strategist

Observations

The four viewer violations (Zurück, Weiter, Verkleinern, Vergrößern) are aria-label values on…

marcel commented on issue marcel/familienarchiv#319

2026-04-26 12:46:22 +02:00

fix(i18n): translate viewer + Transcribe panel controls so EN/ES locales do not show German labels

🧪 Sara Holt — Senior QA Engineer

Observations

Acceptance criteria are specific and testable — named strings, key-parity enforcement, locale-specific E2E assertions. Solid spec. -…

marcel commented on issue marcel/familienarchiv#319

2026-04-26 12:46:11 +02:00

fix(i18n): translate viewer + Transcribe panel controls so EN/ES locales do not show German labels

🔒 Nora "NullX" Steiner — Application Security Engineer

Observations

WCAG 3.1.2 ("Language of Parts") requires that all text content — including aria-label attributes — matches the…

marcel commented on issue marcel/familienarchiv#319

2026-04-26 12:46:02 +02:00

fix(i18n): translate viewer + Transcribe panel controls so EN/ES locales do not show German labels

🏛️ Markus Keller — Senior Application Architect

Observations

Pure frontend change. No backend, no DB migrations, no API surface touched. Blast radius is a handful of .svelte files…

marcel commented on issue marcel/familienarchiv#319

2026-04-26 12:45:52 +02:00

fix(i18n): translate viewer + Transcribe panel controls so EN/ES locales do not show German labels

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

I grepped the repo. The violations live in PdfControls.svelte (not DocumentViewer.svelte as the critical files list…

marcel commented on pull request marcel/familienarchiv#333

2026-04-26 12:37:15 +02:00

feat(persons): surface personType + title in forms and detail card

Review concerns addressed ✅

All non-blocking suggestions from the third review round resolved in 4 commits.

✅ Leonie minor — `aria-label` missing on radiogroup div

Commit:…

marcel pushed to feat/issue-218-person-title-type-fields at marcel/familienarchiv

2026-04-26 12:36:52 +02:00

1f7509413d refactor(persons): extract inputCls/labelCls and PersonFormData type

da1270c419 refactor(persons): rename page.server.test.ts to normalizePersonType.test.ts

409a8fc8f2 test(persons): replace fragile CSS class tests with aria-checked behavior tests

c154dcd47e a11y(persons): add aria-label to PersonTypeSelector radiogroup

Compare 4 commits »

marcel commented on issue marcel/familienarchiv#292

2026-04-26 12:36:15 +02:00

As a user I want route-specific skeleton loaders so I see the page layout while data is still being fetched

we will use animate-pulse

marcel commented on pull request marcel/familienarchiv#333

2026-04-26 10:48:59 +02:00

feat(persons): surface personType + title in forms and detail card

🎨 Leonie Voss — UI/UX & Accessibility

Verdict: ⚠️ Approved with concerns

The accessibility architecture of PersonTypeSelector is correct and the previous blockers are resolved. One…

marcel commented on pull request marcel/familienarchiv#333

2026-04-26 10:48:46 +02:00

feat(persons): surface personType + title in forms and detail card

📋 Elicit — Requirements Engineer

Verdict: ✅ Approved

Checking the implementation against the expected acceptance criteria for this feature.

Acceptance criteria — all fulfilled

marcel commented on pull request marcel/familienarchiv#333

2026-04-26 10:48:39 +02:00

feat(persons): surface personType + title in forms and detail card

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

No infrastructure changes in this PR. Nothing to block.

What's checked

No Flyway migration files added or…

marcel commented on pull request marcel/familienarchiv#333

2026-04-26 10:48:38 +02:00

feat(persons): surface personType + title in forms and detail card

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

No new security risks introduced. Several security-relevant details are handled correctly.

What's…

marcel commented on pull request marcel/familienarchiv#333

2026-04-26 10:48:30 +02:00

feat(persons): surface personType + title in forms and detail card

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ✅ Approved

Test coverage for this PR is solid and addresses the gaps from the previous review round.

What's covered

-…

📋 Elicit — Requirements Engineer

Resolved items

🗳️ Decision Queue — Action Required

UX / Translations

📋 Elicit — Requirements Engineer

Observations

🚀 Tobias Wendt — DevOps & Platform Engineer

Observations

🎨 Leonie Voss — Senior UX Designer & Accessibility Strategist

Observations

🧪 Sara Holt — Senior QA Engineer

Observations

🔒 Nora "NullX" Steiner — Application Security Engineer

Observations

🏛️ Markus Keller — Senior Application Architect

Observations

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

Review concerns addressed ✅

✅ Leonie minor — aria-label missing on radiogroup div

🎨 Leonie Voss — UI/UX & Accessibility

📋 Elicit — Requirements Engineer

Acceptance criteria — all fulfilled

⚙️ Tobias Wendt — DevOps & Platform Engineer

What's checked

🔐 Nora "NullX" Steiner — Application Security Engineer

What's…

🧪 Sara Holt — QA Engineer & Test Strategist

What's covered

✅ Leonie minor — `aria-label` missing on radiogroup div