marcel

marcel commented on pull request marcel/familienarchiv#333

2026-04-26 00:02:19 +02:00

feat(persons): surface personType + title in forms and detail card

🔐 Nora "NullX" Steiner — Security Expert

Verdict: ✅ Approved

What I checked

Input validation and SKIP guard placement
Error response information disclosure
SQL injection…

marcel commented on pull request marcel/familienarchiv#333

2026-04-26 00:02:09 +02:00

feat(persons): surface personType + title in forms and detail card

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Blockers

1. page.server.test.ts tests a local copy, not production code `normalizePersonType…

marcel commented on pull request marcel/familienarchiv#333

2026-04-26 00:01:59 +02:00

feat(persons): surface personType + title in forms and detail card

🏗️ Markus Keller — Software Architect

Verdict: ⚠️ Approved with concerns

Blockers

None — the changes are safe to merge.

Concerns

1. Breaking API contract on personType…

marcel created pull request marcel/familienarchiv#333

2026-04-25 23:56:21 +02:00

feat(persons): surface personType + title in forms and detail card

marcel commented on issue marcel/familienarchiv#218

2026-04-25 22:01:54 +02:00

feat(ui): surface title & personType fields in person forms and detail card

Implementierung abgeschlossen ✅

Alle 16 Tasks wurden umgesetzt. Branch: feat/issue-218-person-title-type-fields

Backend (15 neue Tests, alle grün — 1353 total)

aac8250a —…

marcel pushed to feat/issue-218-person-title-type-fields at marcel/familienarchiv

2026-04-25 22:01:34 +02:00

86032d5c6b feat(persons): show title in small-caps above display name in PersonCard

378d35d44d feat(persons): add type selector + title + conditional fields to new-person form

ecf93f4b9b feat(persons): extract personType + title in edit action; relax firstName for non-PERSON

1786386936 feat(persons): add type selector + title + conditional fields to edit form

Compare 4 commits »

marcel created branch feat/issue-218-person-title-type-fields in marcel/familienarchiv

2026-04-25 21:41:22 +02:00

marcel pushed to feat/issue-218-person-title-type-fields at marcel/familienarchiv

2026-04-25 21:41:22 +02:00

6a906281e5 fix(search): use to_tsquery('simple') for prefix transform to avoid German stop word collision

fe830ad64b feat(persons): add PersonTypeSelector segmented control component

8f75552503 feat(i18n): add form_label_person_type, form_label_name, a11y_type_changed keys

e7573bbeda feat(persons): normalize SKIP→UNKNOWN in edit-route load function

bf31380141 feat(persons): add radioGroupNav action for keyboard navigation in type selector

Compare 10 commits »

marcel pushed to main at marcel/familienarchiv

2026-04-25 20:34:07 +02:00

18cad798fc fix(documents): preserve archiveBox + archiveFolder in markForReview; drop documentLocation

0ddf43947b refactor(documents): drop documentLocation binding from edit layouts; wire archive fields

45f7642f8d feat(documents): replace documentLocation with archiveBox/archiveFolder in edit form

5a13e61357 feat(documents): wire archiveBox + archiveFolder through DTO and service update

Compare 4 commits »

marcel commented on issue marcel/familienarchiv#218

2026-04-25 20:33:49 +02:00

feat(ui): surface title & personType fields in person forms and detail card

It's non-nullable, PersonType is always required

marcel commented on issue marcel/familienarchiv#218

2026-04-25 20:32:21 +02:00

feat(ui): surface title & personType fields in person forms and detail card

🗳️ Decision Queue — Action Required

1 decision needs your input before implementation starts.

Backend API Design

**Null personType in PersonUpdateDTO: preserve existing type…

marcel commented on issue marcel/familienarchiv#218

2026-04-25 20:32:09 +02:00

feat(ui): surface title & personType fields in person forms and detail card

⚙️ Tobias Wendt — DevOps & Platform Engineer

Observations

No infrastructure changes needed: V22 migration already adds title and person_type columns. No new Docker services,…

marcel commented on issue marcel/familienarchiv#218

2026-04-25 20:32:01 +02:00

feat(ui): surface title & personType fields in person forms and detail card

🎨 Leonie Voss — UX Design Lead & Accessibility Strategist

Pre-implementation design decisions are resolved (see 2026-04-15 comment). Three items for this implementation pass.

Observation…

marcel commented on issue marcel/familienarchiv#218

2026-04-25 20:31:49 +02:00

feat(ui): surface title & personType fields in person forms and detail card

🧪 Sara Holt — QA Engineer

Observations

Confirmed coverage gaps (codebase-verified):

PersonServiceTest: zero tests for title persistence in create/update; zero for personType…

marcel closed issue marcel/familienarchiv#325

2026-04-25 20:31:40 +02:00

feat(tags): split flat tag taxonomy into documentType + event + freeform dimensions

marcel commented on issue marcel/familienarchiv#218

2026-04-25 20:31:36 +02:00

feat(ui): surface title & personType fields in person forms and detail card

🔒 Nora "NullX" Steiner — Application Security Engineer

Observations

Permissions are correct: Both POST /api/persons and PUT /api/persons/{id} require `@RequirePermission(Permissi…

marcel commented on issue marcel/familienarchiv#218

2026-04-25 20:31:23 +02:00

feat(ui): surface title & personType fields in person forms and detail card

🏛️ Markus Keller — Application Architect

Observations

DB layer is already sound: V22 migration has CHECK (person_type IN ('PERSON', 'INSTITUTION', 'GROUP', 'UNKNOWN')) — SKIP…

marcel commented on issue marcel/familienarchiv#218

2026-04-25 20:31:13 +02:00

feat(ui): surface title & personType fields in person forms and detail card

👨‍💻 Felix Brandt — Senior Fullstack Developer

Six decisions from the 2026-04-15 pre-review stand. This pass focuses on what codebase research turned up.

Observations

**Four concrete…

marcel commented on issue marcel/familienarchiv#218

2026-04-25 20:25:51 +02:00

feat(ui): surface title & personType fields in person forms and detail card

📋 Elicit — Requirements Review

Requirements analysis of this issue against spec §4, V22 migration, and PersonService.java. Seven open questions resolved; findings below.

###…

marcel pushed to main at marcel/familienarchiv

2026-04-25 19:42:29 +02:00

a91ee1f26d refactor(documents): unify count + action links into one row