marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#330 2026-04-25 12:03:35 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

📋 Elicit — Requirements Engineer

Verdict: ✅ Approved

Reviewing against the stated goals of issue #320: guided empty state + Kurrent primer for first-time transcribers.

Requirements…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 12:03:23 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

No infrastructure changes in this PR. CI pipeline, Docker Compose, and deployment config are untouched.…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 12:03:15 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Clean implementation. The Svelte 5 idioms are correct throughout. A few observations on the finer details.

###…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 12:03:01 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

🏗️ Markus Keller — Senior Application Architect

Verdict: ✅ Approved

This PR is frontend-only (no backend, no DB, no infrastructure changes). The scope is clean. A few architectural…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 11:53:20 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

Hover-target bug fixed — 38c3bb13

Root cause: hover:border-brand-navy hover:text-brand-navy were on the inner <span>, so the visual state change only fired when the cursor was over…

marcel pushed to feat/issue-320-transcribe-coach at marcel/familienarchiv 2026-04-25 11:53:05 +02:00
38c3bb137c fix(transcribe-coach): propagate hover from 44px button group to inner span
marcel commented on pull request marcel/familienarchiv#329 2026-04-25 11:41:03 +02:00
feat(documents): bulk upload — split-panel with file switcher

All reviewer concerns addressed. Summary by concern:

Concurrent save guard (@reviewer: "double-click fires two fetches")

  • Added saving guard in save() + disabled prop to `UploadSaveBa…
marcel pushed to feat/issue-317-bulk-upload at marcel/familienarchiv 2026-04-25 11:40:47 +02:00
1fca1f80a2 docs(bulk-upload): explain chunkSize=10 and 50-file cap constants
46dae8a826 feat(bulk-upload): guard discard-all with confirm dialog
e5fe2fc5c6 fix(bulk-upload): add gradient overflow indicators to chip strip
0ab85d888b fix(bulk-upload): chip readability and focus management in FileSwitcherStrip
48c82aa07b fix(bulk-upload): handle network errors and partial upload success
Compare 6 commits »
marcel commented on pull request marcel/familienarchiv#330 2026-04-25 11:01:26 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

📋 Elicit — Requirements Engineer

Verdict: ✅ Approved with observations

Reviewing against the stated goals of issue #320: guided empty state for first-time transcribers and a Kurrent…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 11:01:07 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with one action item

No CI workflow changes. No Docker or infrastructure changes. The afterAll document teardowns in…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 11:00:58 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

This is a pure frontend feature PR — no backend changes, no service boundaries, no schema migrations. The architectural…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 11:00:41 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ⚠️ Approved with one bug

This PR shows exactly the attention to the 60+ audience that the project needs. Most of the…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 11:00:23 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with minor concerns

Solid test work. The afterAll teardowns, the global reducedMotion default, and the new "with blocks" state…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 11:00:11 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

No new attack surface, no injection vectors, no credential handling. The `rel="noopener…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 10:59:53 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Overall this is clean, disciplined work. A few things worth calling out.

What's done well

**$state +…

marcel commented on pull request marcel/familienarchiv#330 2026-04-25 10:24:07 +02:00
feat(#320): guided empty state + Kurrent primer for first-time transcribers

Training footer positive-case test added — 534ec959

Addressed the concern from Sara and Elicit across the last two review rounds: the spec only verified the footer was hidden on an empty…

marcel pushed to feat/issue-320-transcribe-coach at marcel/familienarchiv 2026-04-25 10:23:48 +02:00
534ec9597d test(e2e): add training footer positive-case test and fix broken selectors
marcel commented on pull request marcel/familienarchiv#329 2026-04-25 09:57:52 +02:00
feat(documents): bulk upload — split-panel with file switcher

🎨 Leonie Voss — UI/UX & Accessibility Expert

Verdict: ⚠️ Approved with concerns

What was checked

  • WCAG 2.2 AA compliance (touch targets, screen reader support, focus management) -…
marcel commented on pull request marcel/familienarchiv#329 2026-04-25 09:57:36 +02:00
feat(documents): bulk upload — split-panel with file switcher

🧪 Sara Holt — QA & Test Engineer

Verdict: ✅ Approved

What was checked

  • Test pyramid: unit, integration, component coverage
  • Edge case coverage in component tests
  • Test…
marcel commented on pull request marcel/familienarchiv#329 2026-04-25 09:57:28 +02:00
feat(documents): bulk upload — split-panel with file switcher

🔐 Nora "NullX" Steiner — Application Security

Verdict: ✅ Approved

What was checked

  • CSRF exposure for the client-side batch fetch
  • Authentication enforcement on the new…