marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:49:29 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

⚙️ Tobias Wendt — DevOps & Platform Engineer

Observations

  • Zero infrastructure changes. No new service, no new port, no new env var, no new volume. The thumbnail endpoint (`DocumentContr…
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:49:28 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🛡️ Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

Re-audited the delta. No security surface added, no existing control weakened.

What changed and what I…

marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:49:17 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🧪 Sara Holt — QA Engineer

Observations

  • Good news: both test files already exist (DashboardServiceTest.java:50-81 for the backend, DashboardResumeStrip.svelte.spec.ts:1-55 for the…
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:49:15 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

No structural changes in round 2 — the fixes stay inside existing boundaries. ADR-005 remains the single source of truth…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:49:09 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Round-2 check — every suggestion I raised in round 1 is resolved, each with its own atomic commit and a matching…

marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:49:03 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🔒 Nora Steiner — Application Security Engineer

Observations

  • The thumbnail endpoint (DocumentController.java:98-120) serves through the standard application auth chain. Embedding a…
marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:48:48 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🏛️ Markus Keller — Senior Application Architect

Observations

  • Narrow, localized change confined to the dashboard feature package — no boundary crossings, no new repository dependencie…
marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:48:38 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

  • The DTO already exposes thumbnailUrl as a fully-formed URL string, but elsewhere in the codebase we keep thumbnailKey +…
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:48:05 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🔧 Review fixes — round 1

Pushed 10 commits addressing every blocker + concern from the first review cycle.

@leonievoss blockers

  • ✅ WCAG 1.4.1 — direction via color alone…
a92644d69b test(briefwechsel): visual spec seeds bilateral pair and asserts row structure
d1a69e0b43 test(briefwechsel): a11y spec seeds bilateral pair and axes the row layout
3b3b551d84 refactor(briefwechsel): extract TagChipList from ThumbnailRow
78caac8d1a refactor(thumbnails): pack key + aspect + pageCount into ThumbnailResult
514f0174e3 refactor(briefwechsel): ThumbnailRow captures now at prop binding
Compare 10 commits »
marcel pushed to main at marcel/familienarchiv 2026-04-23 20:45:52 +02:00
94e976bae3 docs(specs): rework person dashboard spec around data reality
marcel opened issue marcel/familienarchiv#312 2026-04-23 20:31:36 +02:00
refactor(ui): use bg-surface token instead of bg-white on thumbnail tiles
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 19:11:53 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: 🚫 Changes requested

The structural intent is right — thumbnails as the primary visual anchor, quote-styled summary,…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 19:11:18 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

This PR is infrastructure-quiet by design — no changes to docker-compose.yml, .github/workflows, Caddyfile, or…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 19:11:04 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🧪 Sara Holt — QA & Test Strategist

Verdict: 🚫 Changes requested

The unit layer is excellent — I counted 37 new assertions across 6 files (migration, entity, service, three components,…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 19:10:43 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🛡️ Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

The PR widens the data surface (two new columns, a new frontend row layout rendering summary + tags) but…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 19:10:26 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

Structural choices are conservative and well-documented. No new infrastructure, no new domain module, no boundary leaks…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 19:10:09 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

TDD evidence is strong end-to-end: every commit has a matching red test — V53 migration tests (4),…

marcel created pull request marcel/familienarchiv#311 2026-04-23 16:28:16 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)
f74fe16747 docs(adr): ADR-005 thumbnailAspect + pageCount alongside the thumbnail
63c0395151 test(briefwechsel): axe sweep at 3 viewports x 2 themes
22a4e49794 test(briefwechsel): scaffold visual-regression spec for row layout
c004c3bc6f test(briefwechsel): cover DistributionBar and fix Person fixture shape
80728200c6 refactor(briefwechsel): ConversationTimeline renders ThumbnailRow per letter
Compare 10 commits »