marcel pushed to main at marcel/familienarchiv

2026-04-23 21:53:51 +02:00

334b624063 feat(briefwechsel): bump row typography and drop relative-year chip

marcel pushed to main at marcel/familienarchiv

2026-04-23 21:39:06 +02:00

503ce49ef7 refactor(briefwechsel): TagChipList defaults max to 3

f5a30c71b7 i18n(briefwechsel): ThumbnailRow direction label via Paraglide

720f90299a refactor(e2e): visual spec shares seedBilateralPair + asserts person-bar

0e988a9d42 refactor(e2e): extract seedBilateralPair fixture + afterAll cleanup

8cb179a8a1 test(briefwechsel): visual spec seeds bilateral pair and asserts row structure

Compare 30 commits »

marcel deleted branch feat/issue-305-briefwechsel-thumbnail-rows from marcel/familienarchiv

2026-04-23 21:39:00 +02:00

marcel closed issue marcel/familienarchiv#305

2026-04-23 21:38:58 +02:00

feature(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar

marcel merged pull request marcel/familienarchiv#311

2026-04-23 21:38:58 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

marcel commented on issue marcel/familienarchiv#309

2026-04-23 21:34:44 +02:00

As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🎯 Discussion Resolutions

After walking through every persona point with the user, here are the agreed decisions. These now act as the authoritative design for implementation.

Theme 1 —…

marcel commented on pull request marcel/familienarchiv#311

2026-04-23 21:21:25 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

Both round-2 follow-ups I flagged are landed.

Direction label i18n (0da34d06)

Three locales, idiomatic…

marcel commented on pull request marcel/familienarchiv#311

2026-04-23 21:21:16 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

Round 3 is still infrastructure-quiet. Issue #313 filed with the right labels (test, devops), scoped to one clear…

marcel commented on pull request marcel/familienarchiv#311

2026-04-23 21:21:12 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🧪 Sara Holt — QA & Test Strategist

Verdict: ✅ Approved

All four of my round-2 follow-ups resolved in the way I asked for.

Verified

seedBilateralPair helper (00fa7674) —…

marcel commented on pull request marcel/familienarchiv#311

2026-04-23 21:21:00 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🛡️ Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

No security surface added in round 3.

What I re-audited

Fixture module (`e2e/fixtures/bilateral-co…

marcel commented on pull request marcel/familienarchiv#311

2026-04-23 21:20:55 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

Round 3 was pure hygiene — no structural changes. The new fixture module (e2e/fixtures/bilateral-correspondence.ts) is…

marcel commented on pull request marcel/familienarchiv#311

2026-04-23 21:20:50 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Round-3 check — nothing on my side left to raise.

What I verified

TagChipList's max defaulting to 3…

marcel commented on pull request marcel/familienarchiv#311

2026-04-23 21:10:45 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🔧 Review fixes — round 2

Pushed 4 commits addressing every non-blocking follow-up from the round-2 reviews.

@saraholt follow-ups

✅ Shared seedBilateralPair fixture (00fa7674)…

marcel pushed to feat/issue-305-briefwechsel-thumbnail-rows at marcel/familienarchiv

2026-04-23 21:10:22 +02:00

fba685e7a4 refactor(briefwechsel): TagChipList defaults max to 3

0da34d0669 i18n(briefwechsel): ThumbnailRow direction label via Paraglide

b7083d426c refactor(e2e): visual spec shares seedBilateralPair + asserts person-bar

00fa767419 refactor(e2e): extract seedBilateralPair fixture + afterAll cleanup

Compare 4 commits »

marcel opened issue marcel/familienarchiv#313

2026-04-23 21:10:02 +02:00

test(briefwechsel): capture visual-regression baselines for the row layout

marcel commented on pull request marcel/familienarchiv#311

2026-04-23 20:50:21 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

All three of my round-1 blockers are resolved in a way I'm comfortable shipping.

Blockers — resolved

1.…

marcel commented on pull request marcel/familienarchiv#311

2026-04-23 20:49:58 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

Round 2 stays infrastructure-quiet: no Compose, no CI workflow, no env var change. The two E2E specs now hit the real…

marcel commented on issue marcel/familienarchiv#309

2026-04-23 20:49:58 +02:00

As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🗳️ Decision Queue — Action Required

2 decisions need your input before implementation starts.

Architecture / API

**Pre-composed thumbnailUrl string on the DTO vs. raw `thumbnailKey…

marcel commented on issue marcel/familienarchiv#309

2026-04-23 20:49:49 +02:00

As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🎨 Leonie Voss — UX Designer & Accessibility Advocate

Observations

This is the single most prominent visual on the dashboard — the whole point of "resume strip" is recognition-at-a-glan…

marcel commented on pull request marcel/familienarchiv#311

2026-04-23 20:49:48 +02:00

feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🧪 Sara Holt — QA & Test Strategist

Verdict: ⚠️ Approved with concerns

Both blockers addressed, both concerns addressed. What's left is a handful of test-hygiene follow-ups — they're…