marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 21:21:00 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🛡️ Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

No security surface added in round 3.

What I re-audited

  • Fixture module (`e2e/fixtures/bilateral-co…
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 21:20:55 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

Round 3 was pure hygiene — no structural changes. The new fixture module (e2e/fixtures/bilateral-correspondence.ts) is…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 21:20:50 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Round-3 check — nothing on my side left to raise.

What I verified

  • TagChipList's max defaulting to 3…
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 21:10:45 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🔧 Review fixes — round 2

Pushed 4 commits addressing every non-blocking follow-up from the round-2 reviews.

@saraholt follow-ups

  • ✅ Shared seedBilateralPair fixture (00fa7674)…
fba685e7a4 refactor(briefwechsel): TagChipList defaults max to 3
0da34d0669 i18n(briefwechsel): ThumbnailRow direction label via Paraglide
b7083d426c refactor(e2e): visual spec shares seedBilateralPair + asserts person-bar
00fa767419 refactor(e2e): extract seedBilateralPair fixture + afterAll cleanup
Compare 4 commits »
marcel opened issue marcel/familienarchiv#313 2026-04-23 21:10:02 +02:00
test(briefwechsel): capture visual-regression baselines for the row layout
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:50:21 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

All three of my round-1 blockers are resolved in a way I'm comfortable shipping.

Blockers — resolved

1.…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:49:58 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

Round 2 stays infrastructure-quiet: no Compose, no CI workflow, no env var change. The two E2E specs now hit the real…

marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:49:58 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🗳️ Decision Queue — Action Required

2 decisions need your input before implementation starts.

Architecture / API

  • **Pre-composed thumbnailUrl string on the DTO vs. raw `thumbnailKey…
marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:49:49 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🎨 Leonie Voss — UX Designer & Accessibility Advocate

Observations

  • This is the single most prominent visual on the dashboard — the whole point of "resume strip" is recognition-at-a-glan…
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:49:48 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🧪 Sara Holt — QA & Test Strategist

Verdict: ⚠️ Approved with concerns

Both blockers addressed, both concerns addressed. What's left is a handful of test-hygiene follow-ups — they're…

marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:49:29 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

⚙️ Tobias Wendt — DevOps & Platform Engineer

Observations

  • Zero infrastructure changes. No new service, no new port, no new env var, no new volume. The thumbnail endpoint (`DocumentContr…
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:49:28 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🛡️ Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

Re-audited the delta. No security surface added, no existing control weakened.

What changed and what I…

marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:49:17 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🧪 Sara Holt — QA Engineer

Observations

  • Good news: both test files already exist (DashboardServiceTest.java:50-81 for the backend, DashboardResumeStrip.svelte.spec.ts:1-55 for the…
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:49:15 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

No structural changes in round 2 — the fixes stay inside existing boundaries. ADR-005 remains the single source of truth…

marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:49:09 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

Round-2 check — every suggestion I raised in round 1 is resolved, each with its own atomic commit and a matching…

marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:49:03 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🔒 Nora Steiner — Application Security Engineer

Observations

  • The thumbnail endpoint (DocumentController.java:98-120) serves through the standard application auth chain. Embedding a…
marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:48:48 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

🏛️ Markus Keller — Senior Application Architect

Observations

  • Narrow, localized change confined to the dashboard feature package — no boundary crossings, no new repository dependencie…
marcel commented on issue marcel/familienarchiv#309 2026-04-23 20:48:38 +02:00
As a user I want the dashboard resume strip to show the actual document thumbnail so I recognize what I was working on at a glance

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

  • The DTO already exposes thumbnailUrl as a fully-formed URL string, but elsewhere in the codebase we keep thumbnailKey +…
marcel commented on pull request marcel/familienarchiv#311 2026-04-23 20:48:05 +02:00
feat(briefwechsel): thumbnail rows with summary quote and bilateral distribution bar (#305)

🔧 Review fixes — round 1

Pushed 10 commits addressing every blocker + concern from the first review cycle.

@leonievoss blockers

  • ✅ WCAG 1.4.1 — direction via color alone…