marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel pushed to feat/issue-181-person-name-aliases at marcel/familienarchiv 2026-04-07 16:31:55 +02:00
f435f2441c fix(model): add @JsonIgnore on PersonNameAlias.person to prevent LazyInitializationException
marcel pushed to feat/issue-181-person-name-aliases at marcel/familienarchiv 2026-04-07 16:06:17 +02:00
e204ed89b6 fix(ui): switch alias operations from client fetch to form actions
marcel pushed to feat/issue-181-person-name-aliases at marcel/familienarchiv 2026-04-07 16:02:00 +02:00
036843bf8f fix(ui): use mt-6 on save bar to match card spacing
marcel pushed to feat/issue-181-person-name-aliases at marcel/familienarchiv 2026-04-07 16:00:23 +02:00
9027f60760 fix(ui): use card-style save bar with mt-4 instead of full-bleed
marcel pushed to feat/issue-181-person-name-aliases at marcel/familienarchiv 2026-04-07 15:59:27 +02:00
0f5eebec29 fix(ui): move save bar to end of edit page after alias and danger zone
marcel commented on pull request marcel/familienarchiv#206 2026-04-07 13:43:48 +02:00
feat: Person name aliases — support name changes over time #181

Review Concerns Addressed

4 commits pushed addressing all reviewer concerns:

@felixbrandt + @nullx (DTO validation)

  • ✅ cfb3260 — Added @NotBlank @Size(max=255) on lastName,…
marcel pushed to feat/issue-181-person-name-aliases at marcel/familienarchiv 2026-04-07 13:43:34 +02:00
f0eb3a76be test(ui): add component tests for NameHistoryCard
6d837c518c fix(a11y): include alias name in delete button aria-label
97646a31df fix(ui): always show Namensverlauf card on detail page
cfb3260e0e fix(api): add input validation to PersonNameAliasDTO
Compare 4 commits »
marcel commented on pull request marcel/familienarchiv#206 2026-04-07 13:38:50 +02:00
feat: Person name aliases — support name changes over time #181

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I checked

Migration safety, infrastructure impact, new dependencies, Docker changes, CI impact.

Findings

-…

marcel commented on pull request marcel/familienarchiv#206 2026-04-07 13:38:41 +02:00
feat: Person name aliases — support name changes over time #181

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ⚠️ Approved with concerns

What I checked

Typography, layout, touch targets, accessibility, mobile behavior, dark mode, brand compliance.

…

marcel commented on pull request marcel/familienarchiv#206 2026-04-07 13:38:24 +02:00
feat: Person name aliases — support name changes over time #181

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

What I checked

Injection surfaces, authorization, IDOR, input validation, data exposure.

#…

marcel commented on pull request marcel/familienarchiv#206 2026-04-07 13:38:04 +02:00
feat: Person name aliases — support name changes over time #181

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

What I checked

Test coverage at every layer, edge cases, test quality.

Strengths

  • **Repository…
marcel commented on pull request marcel/familienarchiv#206 2026-04-07 13:37:51 +02:00
feat: Person name aliases — support name changes over time #181

🏗️ Markus Keller — Application Architect

Verdict: ⚠️ Approved with concerns

What I checked

Layer boundaries, domain model design, query architecture, migration quality.

###…

marcel commented on pull request marcel/familienarchiv#206 2026-04-07 13:37:35 +02:00
feat: Person name aliases — support name changes over time #181

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Strengths

  • TDD discipline strong on backend: 7 unit tests for service layer (getAliases,…
marcel created pull request marcel/familienarchiv#206 2026-04-07 13:36:39 +02:00
feat: Person name aliases — support name changes over time #181
marcel pushed to feat/issue-181-person-name-aliases at marcel/familienarchiv 2026-04-07 13:36:24 +02:00
59f593280b fix(test): update person detail loader tests for 4th aliases API call
b910517690 feat(ui): add alias management to person edit page
002ee1010a feat(ui): add Namensverlauf read-only card to person detail page
9e13208ccd chore(api): regenerate TypeScript API types with alias endpoints
f396e079a5 feat(i18n): add alias type labels and section strings for de/en/es
Compare 10 commits »
marcel created branch feat/issue-181-person-name-aliases in marcel/familienarchiv 2026-04-07 13:36:23 +02:00
marcel commented on issue marcel/familienarchiv#181 2026-04-07 13:36:14 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

Implementation Complete

Branch feat/issue-181-person-name-aliases — 11 commits, all tests green (676 backend, 213 frontend).

Backend (7 commits)

  • V21 migration: `person_name_aliase…
marcel deleted branch feat/issue-177-transcription-read-mode from marcel/familienarchiv 2026-04-07 12:46:26 +02:00
marcel pushed to main at marcel/familienarchiv 2026-04-07 12:46:23 +02:00
b5ec4ebc0c refactor(ui): rename shadowed m parameter to newMode
10fdaf7d00 refactor(ui): use CSS variable for turquoise in flash animations
e01ef56c48 fix(i18n): use getLocale() for date formatting in panel header
b01a9ef406 refactor(ui): use bg-turquoise/10 token for paragraph hover
e31b73303e fix(ui): bump paragraph hover opacity from 6% to 10%
Compare 20 commits »
marcel closed issue marcel/familienarchiv#177 2026-04-07 12:46:22 +02:00
feat: Transcription read mode (clean split)