• Joined on 2026-03-17
marcel commented on issue marcel/familienarchiv#180 2026-04-06 01:14:56 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

🧪 Sara Holt — QA Engineer & Test Strategist

Questions & Observations

The ACs are well-structured but have gaps that will make test cases ambiguous. A few I'd want closed before…

marcel commented on issue marcel/familienarchiv#180 2026-04-06 01:14:42 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

🏗️ Markus Keller — Application Architect

Questions & Observations

  • Multi-value sort fields need a design decision: Sort by sender is unambiguous (one sender per document). Sort…
marcel commented on issue marcel/familienarchiv#180 2026-04-06 01:14:30 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • Current sort mechanism: Before writing the first failing test for the new sort fields, I need to know how…
marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:13:22 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

This is a clean, additive change from an infrastructure perspective. No new services, no new dependencies, no async…

marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:13:11 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

🎨 Leonie Voss — UI/UX Design Lead

Questions & Observations

  • Mobile layout for the add-alias form: At 320px viewport, a single row with a type dropdown + last name field + optional…
marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:13:06 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🎨 Leonie Voss — UX Design Lead

The sequential hero design is agreed (see earlier discussion comment). A few implementation details that need to be defined before the developer starts:

###…

marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:12:56 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

🔒 Nora "NullX" Steiner — Application Security

Questions & Observations

Two concerns worth resolving before implementation, one definite and one a design decision:

**1. IDOR risk in…

marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:12:51 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🚀 Tobias Wendt — DevOps & Platform Engineer

No infrastructure impact

Pure SvelteKit frontend change. No new environment variables, no new services, no Docker Compose changes, no CI…

marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:12:45 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

🧪 Sara Holt — QA Engineer & Test Strategist

Questions & Observations

The acceptance criteria are solid at the happy-path level, but several edge cases and error paths are unspecified.…

marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:12:41 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🔒 Nora "NullX" Steiner — Security Engineer

No new attack surface introduced

This is a UI-only refactor. No new endpoints, no new data flows, no auth boundary changes. Nothing to flag on…

marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:12:32 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

🏗️ Markus Keller — Application Architect

Questions & Observations

  • Where does the alias JOIN live in document search? The issue says DocumentService search must join aliases when…
marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:12:27 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🧪 Sara Holt — QA Engineer

Missing acceptance criteria for the sequential flow

The current AC covers the end states but not the transitions. I'd add:

  • After Person A is selected,…
marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:12:18 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • Test strategy for the search JOIN: The extension to PersonService and DocumentService search touches…
marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:12:13 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🏗️ Markus Keller — Application Architect

No backend changes required

This is a pure frontend refactor. No new API endpoints, no schema changes, no Spring Boot work. The existing…

marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:12:01 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

👨‍💻 Felix Brandt — Senior Fullstack Developer

Component decomposition

The current ConversationFilterBar.svelte does one job today (full filter panel) but will need to serve two…

marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:10:12 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🎨 Leonie Voss — UX Design Lead

Design discussion outcomes — interaction model and layout decisions agreed with the product owner.


Resolved

  • **Interaction model — sequential…
marcel opened issue marcel/familienarchiv#181 2026-04-06 00:25:22 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)
marcel opened issue marcel/familienarchiv#180 2026-04-06 00:23:00 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback
marcel opened issue marcel/familienarchiv#179 2026-04-06 00:22:41 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text
f359c19e4c fix: bump comment text to text-base + reload annotations on block delete