marcel

marcel commented on pull request marcel/familienarchiv#206

2026-04-07 13:37:51 +02:00

feat: Person name aliases — support name changes over time #181

🏗️ Markus Keller — Application Architect

Verdict: ⚠️ Approved with concerns

What I checked

Layer boundaries, domain model design, query architecture, migration quality.

###…

marcel commented on pull request marcel/familienarchiv#206

2026-04-07 13:37:35 +02:00

feat: Person name aliases — support name changes over time #181

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Strengths

TDD discipline strong on backend: 7 unit tests for service layer (getAliases,…

marcel created pull request marcel/familienarchiv#206

2026-04-07 13:36:39 +02:00

feat: Person name aliases — support name changes over time #181

marcel pushed to feat/issue-181-person-name-aliases at marcel/familienarchiv

2026-04-07 13:36:24 +02:00

59f593280b fix(test): update person detail loader tests for 4th aliases API call

b910517690 feat(ui): add alias management to person edit page

002ee1010a feat(ui): add Namensverlauf read-only card to person detail page

9e13208ccd chore(api): regenerate TypeScript API types with alias endpoints

f396e079a5 feat(i18n): add alias type labels and section strings for de/en/es

Compare 10 commits »

marcel created branch feat/issue-181-person-name-aliases in marcel/familienarchiv

2026-04-07 13:36:23 +02:00

marcel commented on issue marcel/familienarchiv#181

2026-04-07 13:36:14 +02:00

feat: Person name aliases — support name changes over time (marriage, widowhood)

Implementation Complete

Branch feat/issue-181-person-name-aliases — 11 commits, all tests green (676 backend, 213 frontend).

Backend (7 commits)

V21 migration: `person_name_aliase…

marcel deleted branch feat/issue-177-transcription-read-mode from marcel/familienarchiv

2026-04-07 12:46:26 +02:00

marcel pushed to main at marcel/familienarchiv

2026-04-07 12:46:23 +02:00

b5ec4ebc0c refactor(ui): rename shadowed m parameter to newMode

10fdaf7d00 refactor(ui): use CSS variable for turquoise in flash animations

e01ef56c48 fix(i18n): use getLocale() for date formatting in panel header

b01a9ef406 refactor(ui): use bg-turquoise/10 token for paragraph hover

e31b73303e fix(ui): bump paragraph hover opacity from 6% to 10%

Compare 20 commits »

marcel closed issue marcel/familienarchiv#177

2026-04-07 12:46:22 +02:00

feat: Transcription read mode (clean split)

marcel merged pull request marcel/familienarchiv#205

2026-04-07 12:46:21 +02:00

feat: Transcription read mode (clean split) #177

marcel commented on pull request marcel/familienarchiv#205

2026-04-07 12:00:52 +02:00

feat: Transcription read mode (clean split) #177

Review Concerns Addressed

10 commits pushed addressing all reviewer concerns:

@saraholt (QA)

✅ 90120ca — flash-highlight class test for TranscriptionReadView (+ negative test)
✅…

marcel pushed to feat/issue-177-transcription-read-mode at marcel/familienarchiv

2026-04-07 12:00:31 +02:00

b5ec4ebc0c refactor(ui): rename shadowed m parameter to newMode

10fdaf7d00 refactor(ui): use CSS variable for turquoise in flash animations

e01ef56c48 fix(i18n): use getLocale() for date formatting in panel header

b01a9ef406 refactor(ui): use bg-turquoise/10 token for paragraph hover

e31b73303e fix(ui): bump paragraph hover opacity from 6% to 10%

Compare 10 commits »

marcel commented on pull request marcel/familienarchiv#205

2026-04-07 11:40:42 +02:00

feat: Transcription read mode (clean split) #177

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I checked

New dependencies, bundle impact, build/CI changes, infrastructure requirements, font loading.

###…

marcel commented on pull request marcel/familienarchiv#205

2026-04-07 11:40:34 +02:00

feat: Transcription read mode (clean split) #177

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ⚠️ Approved with concerns

What I checked

Typography, color usage, accessibility (WCAG 2.2), touch targets, mobile layout, dark mode…

marcel commented on pull request marcel/familienarchiv#205

2026-04-07 11:39:58 +02:00

feat: Transcription read mode (clean split) #177

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

What I checked

XSS vectors, injection surfaces, data exposure, auth boundaries, DOM manipulation…

marcel commented on pull request marcel/familienarchiv#205

2026-04-07 11:39:49 +02:00

feat: Transcription read mode (clean split) #177

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

What I checked

Test coverage, test quality, missing edge cases, test pyramid placement.

###…

marcel commented on pull request marcel/familienarchiv#205

2026-04-07 11:39:31 +02:00

feat: Transcription read mode (clean split) #177

🏗️ Markus Keller — Application Architect

Verdict: ✅ Approved

What I checked

Layer boundaries, state ownership, prop drilling depth, component coupling, data flow direction.

###…

marcel commented on pull request marcel/familienarchiv#205

2026-04-07 11:39:12 +02:00

feat: Transcription read mode (clean split) #177

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

What I checked

TDD evidence, naming, function size, Svelte 5 rules, component splitting,…

marcel created pull request marcel/familienarchiv#205

2026-04-07 11:38:13 +02:00

feat: Transcription read mode (clean split) #177

marcel pushed to feat/issue-177-transcription-read-mode at marcel/familienarchiv

2026-04-07 11:37:54 +02:00

4d5b8b4ead feat(ui): add collapsible PDF strip and abbreviated labels on mobile

10cecb01f5 feat(a11y): respect prefers-reduced-motion for scroll-sync

81b14e5026 feat(ui): add bidirectional scroll-sync with flash animations

e089192d7a feat(ui): wire panelMode state with read/edit view switching

306eef2e95 feat(ui): add TranscriptionReadView for flowing prose display

Compare 10 commits »