• Joined on 2026-03-17
marcel commented on issue marcel/familienarchiv#196 2026-04-07 10:52:37 +02:00
Split PdfViewer.svelte (469 lines) into renderer module + controls component

⚙️ Tobias Wendt -- DevOps & Platform Engineer

Pure frontend refactor, no infra impact. A few things on the build/CI side:

Bundle size check

  • Extracting usePdfRenderer.svelte.ts as a…
marcel commented on issue marcel/familienarchiv#201 2026-04-07 10:52:36 +02:00
Minor structural improvements — notification rows, admin list panels, search filters, icons

🔒 Nora "NullX" Steiner -- Application Security Engineer

This is a pure frontend refactoring issue -- no new endpoints, no auth changes, no data flow changes. My security exposure assessment…

marcel commented on issue marcel/familienarchiv#194 2026-04-07 10:52:35 +02:00
Extract shared utility functions to eliminate duplication

🎨 Leonie Voss -- UI/UX Design Lead

This issue is explicitly "pure-logic extractions that don't change any component markup" -- so no visual regressions expected. Still, a few items touch…

marcel commented on issue marcel/familienarchiv#199 2026-04-07 10:52:34 +02:00
Split TranscriptionEditView.svelte (332 lines) — extract auto-save + drag-drop modules

🎨 Leonie Voss -- UI/UX Design Lead

This is a code-level refactor, so the user-facing behavior should be pixel-identical. My concerns are about preserving the existing UX during extraction:

##…

marcel commented on issue marcel/familienarchiv#198 2026-04-07 10:52:31 +02:00
Split CommentThread.svelte (310 lines) — extract CommentMessage component

⚙️ Tobias Wendt -- DevOps & Platform Engineer

Pure frontend refactor -- no infrastructure changes, no new dependencies, no build pipeline impact. From a DevOps perspective this is low-risk,…

marcel commented on issue marcel/familienarchiv#200 2026-04-07 10:52:26 +02:00
Split NotificationBell.svelte (316 lines) — extract dropdown + SSE stream module

🔒 Nora "NullX" Steiner -- Application Security Engineer

Refactors don't change attack surface -- in theory. In practice, moving SSE and fetch logic into a separate module is a good moment to…

marcel commented on issue marcel/familienarchiv#196 2026-04-07 10:52:24 +02:00
Split PdfViewer.svelte (469 lines) into renderer module + controls component

🎨 Leonie Voss -- UI/UX Design Lead

The split is structural, but any time the control bar component is extracted, there's a risk of subtle visual regressions. Here's what I'd watch:

###…

marcel commented on issue marcel/familienarchiv#197 2026-04-07 10:52:23 +02:00
Split EntityNav.svelte (516 lines) into section + item subcomponents

⚙️ Tobias Wendt -- DevOps & Platform Engineer

Pure frontend refactor -- no infrastructure impact. Quick notes from the build/CI perspective:

Build & Bundle Size

  • Splitting one .svelte…
marcel commented on issue marcel/familienarchiv#201 2026-04-07 10:52:22 +02:00
Minor structural improvements — notification rows, admin list panels, search filters, icons

🧪 Sara Holt -- Senior QA Engineer

Pure refactor with "no behavior changes" -- this is exactly the scenario where test coverage proves its value. My focus is on how we verify nothing…

marcel commented on issue marcel/familienarchiv#199 2026-04-07 10:52:20 +02:00
Split TranscriptionEditView.svelte (332 lines) — extract auto-save + drag-drop modules

🔒 Nora "NullX" Steiner -- Application Security Engineer

This is a refactor, not new functionality, so the attack surface should remain unchanged. That said, a few things to verify during…

marcel commented on issue marcel/familienarchiv#198 2026-04-07 10:52:19 +02:00
Split CommentThread.svelte (310 lines) — extract CommentMessage component

🎨 Leonie Voss -- UI/UX Design Lead

The message bubble is a well-defined visual region -- avatar, name, timestamp, body, optional quote, optional edit controls. Extracting it into its own…

marcel commented on issue marcel/familienarchiv#194 2026-04-07 10:52:17 +02:00
Extract shared utility functions to eliminate duplication

🔒 Nora "NullX" Steiner -- Application Security Engineer

This is a pure frontend refactoring issue with no new endpoints or auth changes. Low security risk overall, but a few items warrant…

marcel commented on issue marcel/familienarchiv#195 2026-04-07 10:52:13 +02:00
Unify click-outside handling to use existing clickOutside action

⚙️ Tobias Wendt -- DevOps & Platform Engineer

Pure frontend refactor, no infrastructure impact. A few notes anyway:

CI pipeline considerations:

  • This touches 4 components across…
marcel commented on issue marcel/familienarchiv#197 2026-04-07 10:52:12 +02:00
Split EntityNav.svelte (516 lines) into section + item subcomponents

🎨 Leonie Voss -- UI/UX Design Lead

Component splitting is great for maintainability, but the visual contract must survive intact. Here's what I'd verify:

Active State Styling

  • The…
marcel commented on issue marcel/familienarchiv#200 2026-04-07 10:52:10 +02:00
Split NotificationBell.svelte (316 lines) — extract dropdown + SSE stream module

🧪 Sara Holt -- Senior QA Engineer

This is a pure refactor issue -- behavior must remain identical. That makes the test strategy straightforward but critical: existing behavior is the…

marcel commented on issue marcel/familienarchiv#196 2026-04-07 10:52:09 +02:00
Split PdfViewer.svelte (469 lines) into renderer module + controls component

🔒 Nora "NullX" Steiner -- Application Security Engineer

This is a structural refactor, not a feature change, so the attack surface should remain identical. A few things to verify:

PDF.js…

marcel commented on issue marcel/familienarchiv#201 2026-04-07 10:52:08 +02:00
Minor structural improvements — notification rows, admin list panels, search filters, icons

🏗️ Markus Keller -- Senior Application Architect

Structurally sound refactoring scope. My comments focus on module boundaries and abstraction durability.

AdminListPanel -- the one I'd…

marcel commented on issue marcel/familienarchiv#198 2026-04-07 10:52:08 +02:00
Split CommentThread.svelte (310 lines) — extract CommentMessage component

🔒 Nora "NullX" Steiner -- Application Security Engineer

Pure UI refactor, so the attack surface should not change -- but component splits can introduce subtle security regressions if not…

marcel commented on issue marcel/familienarchiv#199 2026-04-07 10:52:05 +02:00
Split TranscriptionEditView.svelte (332 lines) — extract auto-save + drag-drop modules

🧪 Sara Holt -- Senior QA Engineer

This refactor is a testability win -- extracting the auto-save state machine and drag-drop logic into standalone modules makes them independently testable…

marcel commented on issue marcel/familienarchiv#195 2026-04-07 10:52:02 +02:00
Unify click-outside handling to use existing clickOutside action

🎨 Leonie Voss -- UI/UX Design Lead

This refactor is invisible to users if done correctly -- which is exactly the point. A few interaction-design concerns to validate:

**Touch behavior on…