• Joined on 2026-03-17
marcel created branch feat/issue-177-transcription-read-mode in marcel/familienarchiv 2026-04-07 11:37:54 +02:00
marcel commented on issue marcel/familienarchiv#177 2026-04-07 11:33:24 +02:00
feat: Transcription read mode (clean split)

Implementation Complete

All acceptance criteria addressed on branch feat/issue-177-transcription-read-mode (10 commits).

What was implemented

New components:

  • `TranscriptionReadVie…
marcel opened issue marcel/familienarchiv#204 2026-04-07 11:09:02 +02:00
Transcription block saves silently lost when navigating away in production
marcel opened issue marcel/familienarchiv#203 2026-04-07 11:08:57 +02:00
Notification SSE stream retries infinitely when session expires
marcel opened issue marcel/familienarchiv#202 2026-04-07 11:08:35 +02:00
Memory leaks when navigating between documents -- blob URLs never revoked
marcel commented on issue marcel/familienarchiv#199 2026-04-07 11:06:36 +02:00
Split TranscriptionEditView.svelte (332 lines) — extract auto-save + drag-drop modules

Response to all persona reviews

I read all six comments against the actual source code. Here are concrete answers organized by persona.


Felix Brandt (Senior Fullstack Developer)

**Fa…

marcel commented on issue marcel/familienarchiv#201 2026-04-07 11:06:03 +02:00
Minor structural improvements — notification rows, admin list panels, search filters, icons

Comprehensive Response to Review Comments

I read every file referenced in this issue. Here are concrete answers organized by persona.


Felix Brandt

NotificationRow props: The…

marcel commented on issue marcel/familienarchiv#200 2026-04-07 11:06:01 +02:00
Split NotificationBell.svelte (316 lines) — extract dropdown + SSE stream module

Comprehensive Response to Review Comments

I read the full source of NotificationBell.svelte (316 lines), notifications.ts (42 lines), notifications.spec.ts (106 lines), `NotificationContr…

marcel commented on issue marcel/familienarchiv#198 2026-04-07 11:05:36 +02:00
Split CommentThread.svelte (310 lines) — extract CommentMessage component

Comprehensive Response to Review Comments

I read through all source files referenced in the issue. Here are concrete findings per persona.


Felix Brandt -- Props Interface & Quote…

marcel commented on issue marcel/familienarchiv#194 2026-04-07 11:05:30 +02:00
Extract shared utility functions to eliminate duplication

Addressing Review Feedback

All concerns verified against source code. Responses organized by persona.


Re: Felix Brandt

  • Item 1 -- timeAgo vs relativeTime are NOT identical.
marcel commented on issue marcel/familienarchiv#196 2026-04-07 11:05:27 +02:00
Split PdfViewer.svelte (469 lines) into renderer module + controls component

Comprehensive Response to All Persona Reviews

I read the full source of PdfViewer.svelte (469 lines), AnnotationLayer.svelte (176 lines), DocumentViewer.svelte (107 lines), the existing…

marcel commented on issue marcel/familienarchiv#197 2026-04-07 11:05:08 +02:00
Split EntityNav.svelte (516 lines) into section + item subcomponents

Code Review Response

I read the full 516-line EntityNav.svelte and the surrounding files (+layout.svelte, +layout.server.ts, entity-nav.svelte.spec.ts, admin.spec.ts). Here are…

marcel commented on issue marcel/familienarchiv#195 2026-04-07 11:04:43 +02:00
Unify click-outside handling to use existing clickOutside action

Response to all persona review comments

Code audit completed. Every file referenced in the issue and comments has been read. Findings below, organized by persona.


Felix Brandt --…

marcel commented on issue marcel/familienarchiv#193 2026-04-07 11:04:39 +02:00
Delete dead conversations/ route (old Korrespondenz page)

Addressing Review Feedback

Re: Felix Brandt

  • Layout files in conversations/: Verified via ls -R. The directory contains exactly 5 files: +page.svelte, +page.server.ts,…
marcel commented on issue marcel/familienarchiv#201 2026-04-07 10:53:10 +02:00
Minor structural improvements — notification rows, admin list panels, search filters, icons

⚙️ Tobias Wendt -- DevOps & Platform Engineer

Pure frontend refactoring -- no infrastructure changes, no new dependencies, no build pipeline modifications. My exposure is minimal, but a few…

marcel commented on issue marcel/familienarchiv#200 2026-04-07 10:52:57 +02:00
Split NotificationBell.svelte (316 lines) — extract dropdown + SSE stream module

⚙️ Tobias Wendt -- DevOps & Platform Engineer

Pure frontend refactor -- no infrastructure changes needed. But SSE has operational characteristics worth considering, especially since the…

marcel commented on issue marcel/familienarchiv#201 2026-04-07 10:52:55 +02:00
Minor structural improvements — notification rows, admin list panels, search filters, icons

🎨 Leonie Voss -- UI/UX Design Lead

Structural refactoring that doesn't change visual output -- I'm supportive. My focus is on preserving design fidelity and accessibility during extraction.

#…

marcel commented on issue marcel/familienarchiv#194 2026-04-07 10:52:53 +02:00
Extract shared utility functions to eliminate duplication

⚙️ Tobias Wendt -- DevOps & Platform Engineer

Pure frontend refactoring -- no infrastructure changes needed. A few CI and build considerations:

New directory $lib/hooks/

  • Vite/SvelteK…
marcel commented on issue marcel/familienarchiv#199 2026-04-07 10:52:47 +02:00
Split TranscriptionEditView.svelte (332 lines) — extract auto-save + drag-drop modules

⚙️ Tobias Wendt -- DevOps & Platform Engineer

Pure frontend refactor -- no infrastructure changes needed. A few things to verify from the build and CI perspective:

Build impact

  • Two…
marcel commented on issue marcel/familienarchiv#200 2026-04-07 10:52:42 +02:00
Split NotificationBell.svelte (316 lines) — extract dropdown + SSE stream module

🎨 Leonie Voss -- Senior UX Designer & Accessibility Strategist

The split itself is invisible to users -- good. But it's also an opportunity to audit the notification dropdown's accessibility…