marcel

marcel commented on issue marcel/familienarchiv#184

2026-04-06 19:29:45 +02:00

feat(massimport): handle dot-compressed names and titles in PersonNameParser.split()

🛠️ Tobias Wendt — DevOps Engineer

Questions & Observations

Pure Java code change, no infrastructure impact. No new dependencies, no config changes, no Docker or CI modifications…

marcel commented on issue marcel/familienarchiv#184

2026-04-06 19:29:43 +02:00

feat(massimport): handle dot-compressed names and titles in PersonNameParser.split()

🎨 Leonie Voss — UI/UX Design Lead

Questions & Observations

Backend-only parsing change with no UI impact. The dot-compressed names are a data quality issue in the import spreadsheet,…

marcel commented on issue marcel/familienarchiv#184

2026-04-06 19:29:40 +02:00

feat(massimport): handle dot-compressed names and titles in PersonNameParser.split()

🔒 Nora "NullX" Steiner — Security Engineer

Questions & Observations

Same as #182: this is a pure parsing change in a backend utility class processing trusted spreadsheet data from…

marcel commented on issue marcel/familienarchiv#184

2026-04-06 19:29:36 +02:00

feat(massimport): handle dot-compressed names and titles in PersonNameParser.split()

🧪 Sara Holt — QA Engineer

Questions & Observations

The 5 proposed tests cover the four split() scenarios from the issue's table plus a parseReceivers passthrough test. Good…

marcel commented on issue marcel/familienarchiv#184

2026-04-06 19:29:26 +02:00

feat(massimport): handle dot-compressed names and titles in PersonNameParser.split()

🏗️ Markus Keller — Application Architect

Questions & Observations

This is another well-scoped parser enhancement — 3 lines of normalization inside an existing method, no new classes,…

marcel commented on issue marcel/familienarchiv#184

2026-04-06 19:29:16 +02:00

feat(massimport): handle dot-compressed names and titles in PersonNameParser.split()

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

The 3-line fix (cleaned.replace(".", ". ").trim()) is beautifully minimal — it normalizes the input so the…

marcel commented on issue marcel/familienarchiv#182

2026-04-06 19:28:59 +02:00

feat(massimport): support // as multi-person separator in PersonNameParser

🛠️ Tobias Wendt — DevOps Engineer

Questions & Observations

Pure Java code change, no infrastructure impact. No new dependencies, no config changes, no Docker or CI modifications…

marcel commented on issue marcel/familienarchiv#182

2026-04-06 19:28:55 +02:00

feat(massimport): support // as multi-person separator in PersonNameParser

🎨 Leonie Voss — UI/UX Design Lead

Questions & Observations

This is a backend-only parsing change with no UI impact. No frontend components, routes, or user-facing text are affected. -…

marcel commented on issue marcel/familienarchiv#182

2026-04-06 19:28:52 +02:00

feat(massimport): support // as multi-person separator in PersonNameParser

🔒 Nora "NullX" Steiner — Security Engineer

Questions & Observations

This is a pure parsing change in a backend utility class that processes spreadsheet data from authenticated admin…

marcel commented on issue marcel/familienarchiv#182

2026-04-06 19:28:45 +02:00

feat(massimport): support // as multi-person separator in PersonNameParser

🧪 Sara Holt — QA Engineer

Questions & Observations

The 4 proposed tests cover the core scenarios well: two independent names, abbreviated first name, whitespace tolerance, and mixed…

marcel commented on issue marcel/familienarchiv#182

2026-04-06 19:28:36 +02:00

feat(massimport): support // as multi-person separator in PersonNameParser

🏗️ Markus Keller — Application Architect

Questions & Observations

The change is well-scoped: a single method gets a 6-line pre-split step, no new classes, no new interfaces, no schema…

marcel commented on issue marcel/familienarchiv#182

2026-04-06 19:28:26 +02:00

feat(massimport): support // as multi-person separator in PersonNameParser

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

The recursive approach (flatMap(segment -> parseReceivers(segment).stream())) is elegant and handles the…

marcel deleted branch feat/issue-180-extended-search-sort from marcel/familienarchiv

2026-04-06 19:18:14 +02:00

marcel pushed to main at marcel/familienarchiv

2026-04-06 19:18:13 +02:00

a863f8baad docs(search): explain void sort/dir ESLint workaround in SearchFilterBar

1f86e6e238 fix(a11y): bump result count text to text-base (16px) for senior readability

c82bd61ad4 feat(a11y): fix SortDropdown accessibility — label, aria-label i18n, chevron

56f7282a9d test(search): add empty-receivers edge case for RECEIVER sort

110024245d docs(search): document in-memory sort tradeoff and total=size() limitation

Compare 26 commits »

marcel closed issue marcel/familienarchiv#180

2026-04-06 19:18:13 +02:00

feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

marcel merged pull request marcel/familienarchiv#183

2026-04-06 19:18:12 +02:00

feat(search): extended search, sort options, live tag filter, result count

marcel commented on pull request marcel/familienarchiv#183

2026-04-06 16:53:55 +02:00

feat(search): extended search, sort options, live tag filter, result count

✅ Review concerns addressed

All reviewer concerns from the multi-persona review have been resolved. Here's what was done, commit by commit:

Refactoring / Architecture

1202351…

marcel pushed to feat/issue-180-extended-search-sort at marcel/familienarchiv

2026-04-06 16:53:37 +02:00

a863f8baad docs(search): explain void sort/dir ESLint workaround in SearchFilterBar

1f86e6e238 fix(a11y): bump result count text to text-base (16px) for senior readability

c82bd61ad4 feat(a11y): fix SortDropdown accessibility — label, aria-label i18n, chevron

56f7282a9d test(search): add empty-receivers edge case for RECEIVER sort

110024245d docs(search): document in-memory sort tradeoff and total=size() limitation

Compare 9 commits »

marcel commented on pull request marcel/familienarchiv#183

2026-04-06 16:20:03 +02:00

feat(search): extended search, sort options, live tag filter, result count

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

No infrastructure, CI, or deployment changes in this PR. Checked the changed files — all application code.

###…

marcel commented on pull request marcel/familienarchiv#183

2026-04-06 16:19:46 +02:00

feat(search): extended search, sort options, live tag filter, result count

🎨 Leonie Voss — UX Design Lead

Verdict: ⚠️ Approved with concerns

The sort controls are functionally complete but have accessibility and mobile gaps that affect both our senior and…