• Joined on 2026-03-17
marcel deleted branch feat/issue-175-176-metadata-drawer-transcription from marcel/familienarchiv 2026-04-06 11:31:20 +02:00
marcel closed issue marcel/familienarchiv#176 2026-04-06 11:31:15 +02:00
feat: Annotation-backed collaborative transcription system
marcel pushed to main at marcel/familienarchiv 2026-04-06 11:31:15 +02:00
8e48e67cb8 fix(a11y): increase contrast
c18ad25514 remove e2e from pipeline. takes too long
e89d8a4ca9 test: increase coverage
f359c19e4c fix: bump comment text to text-base + reload annotations on block delete
ef11cbee4e feat(transcription): clicking annotation focuses corresponding block
Compare 47 commits »
marcel closed issue marcel/familienarchiv#175 2026-04-06 11:31:13 +02:00
feat: Expandable metadata header with labeled "Details" toggle
marcel merged pull request marcel/familienarchiv#178 2026-04-06 11:31:12 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)
8e48e67cb8 fix(a11y): increase contrast
c18ad25514 remove e2e from pipeline. takes too long
e89d8a4ca9 test: increase coverage
Compare 3 commits »
marcel commented on issue marcel/familienarchiv#179 2026-04-06 09:27:46 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🎨 Leonie Voss — UX Design Lead

Design direction update — sequential hero dropped, discovery framing adopted. Supersedes the earlier interaction model comment.


Resolved

-…

marcel commented on issue marcel/familienarchiv#180 2026-04-06 01:15:33 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

⚙️ Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

  • Request volume increase from eager tag filter: The current "search on submit" pattern produces one backend…
marcel commented on issue marcel/familienarchiv#180 2026-04-06 01:15:22 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

🎨 Leonie Voss — UI/UX Design Lead

Questions & Observations

  • Active sort indicator design: The issue says "icon or highlight" — I'd push for both: a directional arrow (↑↓) next…
marcel commented on issue marcel/familienarchiv#180 2026-04-06 01:15:06 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

🔒 Nora "NullX" Steiner — Application Security

Questions & Observations

Three areas to verify before or during implementation:

**1. Sort parameter injection — CWE-89 (SQL Injection via…

marcel commented on issue marcel/familienarchiv#180 2026-04-06 01:14:56 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

🧪 Sara Holt — QA Engineer & Test Strategist

Questions & Observations

The ACs are well-structured but have gaps that will make test cases ambiguous. A few I'd want closed before…

marcel commented on issue marcel/familienarchiv#180 2026-04-06 01:14:42 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

🏗️ Markus Keller — Application Architect

Questions & Observations

  • Multi-value sort fields need a design decision: Sort by sender is unambiguous (one sender per document). Sort…
marcel commented on issue marcel/familienarchiv#180 2026-04-06 01:14:30 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • Current sort mechanism: Before writing the first failing test for the new sort fields, I need to know how…
marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:13:22 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

This is a clean, additive change from an infrastructure perspective. No new services, no new dependencies, no async…

marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:13:11 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

🎨 Leonie Voss — UI/UX Design Lead

Questions & Observations

  • Mobile layout for the add-alias form: At 320px viewport, a single row with a type dropdown + last name field + optional…
marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:13:06 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🎨 Leonie Voss — UX Design Lead

The sequential hero design is agreed (see earlier discussion comment). A few implementation details that need to be defined before the developer starts:

###…

marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:12:56 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

🔒 Nora "NullX" Steiner — Application Security

Questions & Observations

Two concerns worth resolving before implementation, one definite and one a design decision:

**1. IDOR risk in…

marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:12:51 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🚀 Tobias Wendt — DevOps & Platform Engineer

No infrastructure impact

Pure SvelteKit frontend change. No new environment variables, no new services, no Docker Compose changes, no CI…

marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:12:45 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

🧪 Sara Holt — QA Engineer & Test Strategist

Questions & Observations

The acceptance criteria are solid at the happy-path level, but several edge cases and error paths are unspecified.…

marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:12:41 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🔒 Nora "NullX" Steiner — Security Engineer

No new attack surface introduced

This is a UI-only refactor. No new endpoints, no new data flows, no auth boundary changes. Nothing to flag on…