marcel

marcel commented on pull request marcel/familienarchiv#183

2026-04-06 16:19:23 +02:00

feat(search): extended search, sort options, live tag filter, result count

🔐 NullX (Nora Steiner) — Application Security Engineer

Verdict: ✅ Approved

I've reviewed the new search, sort, and filter code across the full attack surface. No new vulnerabilities…

marcel commented on pull request marcel/familienarchiv#183

2026-04-06 16:19:06 +02:00

feat(search): extended search, sort options, live tag filter, result count

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

TDD evidence is present and the frontend spec files are well-structured. The backend service has the most coverage…

marcel commented on pull request marcel/familienarchiv#183

2026-04-06 16:18:35 +02:00

feat(search): extended search, sort options, live tag filter, result count

🏗️ Markus Keller — Application Architect

Verdict: ⚠️ Approved with concerns

The feature is scoped correctly and the layering holds. Two architectural issues need to be on the radar…

marcel commented on pull request marcel/familienarchiv#183

2026-04-06 16:18:12 +02:00

feat(search): extended search, sort options, live tag filter, result count

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Good TDD discipline throughout — the commit history shows red→green→refactor and the new spec files…

marcel pushed to feat/issue-180-extended-search-sort at marcel/familienarchiv

2026-04-06 15:58:09 +02:00

79250fb705 fix(ui): fix SortDropdown height alignment — appearance-none + items-stretch

marcel pushed to feat/issue-180-extended-search-sort at marcel/familienarchiv

2026-04-06 15:56:32 +02:00

fc3496abb6 fix(ui): align SortDropdown styling with SearchFilterBar button style

marcel pushed to feat/issue-180-extended-search-sort at marcel/familienarchiv

2026-04-06 15:53:13 +02:00

0e13fd194b feat(search): show spinner in search input while navigation is in-flight

marcel pushed to feat/issue-180-extended-search-sort at marcel/familienarchiv

2026-04-06 15:47:35 +02:00

023b6ddb49 fix(search): tagQ alone now triggers search mode; selecting chip clears tagQ

marcel opened issue marcel/familienarchiv#184

2026-04-06 14:22:45 +02:00

feat(massimport): handle dot-compressed names and titles in PersonNameParser.split()

marcel commented on issue marcel/familienarchiv#180

2026-04-06 14:21:12 +02:00

feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

Implementation complete — PR #183

All tasks implemented with red/green/refactor TDD. Here's what was built:

Backend

DocumentSpecifications.hasText extended with EXISTS subqueries…

marcel created pull request marcel/familienarchiv#183

2026-04-06 14:20:53 +02:00

feat(search): extended search, sort options, live tag filter, result count

marcel pushed to feat/issue-180-extended-search-sort at marcel/familienarchiv

2026-04-06 14:20:33 +02:00

bc397048b7 fix(search): use in-memory sort for SENDER to include documents with null sender

07dbe152e2 feat(search): show result count and term-aware empty state in DocumentList

78fdb01ec1 feat(search): wire sort/dir/tagQ state into page.svelte and URL params

769937e03d feat(search): read sort/dir/tagQ from URL and unwrap DocumentSearchResult envelope

4fe10e1316 feat(search): add sort/dir/tagQ props to SearchFilterBar with SortDropdown

Compare 10 commits »

marcel created branch feat/issue-180-extended-search-sort in marcel/familienarchiv

2026-04-06 14:20:33 +02:00

marcel opened issue marcel/familienarchiv#182

2026-04-06 13:52:41 +02:00

feat(massimport): support // as multi-person separator in PersonNameParser

marcel commented on issue marcel/familienarchiv#181

2026-04-06 12:52:05 +02:00

feat: Person name aliases — support name changes over time (marriage, widowhood)

🎨 Leonie Voss — UI/UX Design Lead — Edit page placement

One open question from the previous discussion, now resolved.

✅ Alias section placement on the edit page — resolved

**Dec…

marcel commented on issue marcel/familienarchiv#181

2026-04-06 12:43:29 +02:00

feat: Person name aliases — support name changes over time (marriage, widowhood)

🎨 Leonie Voss — UI/UX Design Lead — Discussion follow-up

Four open design questions worked through with the author. All resolved.

✅ 1. Mobile layout — resolved

**Detail…

marcel commented on issue marcel/familienarchiv#181

2026-04-06 12:17:10 +02:00

feat: Person name aliases — support name changes over time (marriage, widowhood)

🏗️ Markus Keller — Application Architect — Discussion follow-up

Four open architectural questions worked through with the author. All resolved.

✅ 1. DocumentService domain…

marcel commented on issue marcel/familienarchiv#180

2026-04-06 12:09:59 +02:00

feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

Design specs — Sort integration (Problem 1)

Two spec files committed to main (commit e6f12e6):

marcel pushed to main at marcel/familienarchiv

2026-04-06 12:09:40 +02:00

e6f12e6d90 docs(design): add sort integration specs for issue #180

marcel commented on issue marcel/familienarchiv#180

2026-04-06 11:59:17 +02:00

feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback

🏗️ Markus Keller — Application Architect (follow-up discussion)

This comment captures the outcomes of an architecture discussion on the four open items from my earlier review, plus two…