marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 22:49:04 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

🏗️ Markus Keller — Application Architect (Round 3)

Verdict: ✅ Approved

The architectural decisions from rounds 1-2 are cleanly implemented:

  • Block as aggregate root — delete…
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 22:48:47 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

👨‍💻 Felix Brandt — Senior Fullstack Developer (Round 3)

Verdict: ⚠️ Approved with concerns

What improved since Round 2

Massive progress. The PR now has 30 commits addressing…

6dc81ef2e3 fix(ui): match delete icon size + add cursor-pointer to interactive elements
cef1810700 fix(comments): stop Escape propagation in edit mode
351f31b183 feat(comments): inline edit on click + trash icon for own comments
e6432846a1 fix(topbar): use brand navy for transcribe button, not turquoise
a66bec1971 fix(comments): increase text size for readability
82d5a34f76 fix(comments): use semantic tokens for comment box dark mode
3d086bd1fb fix(transcription): auto-capture quote on text selection, smart comment button
e384c87eef refactor(comments): streamline input — Enter to send, no buttons
f09b605752 refactor(comments): flat compact comment thread matching spec design
193bd73af1 fix(i18n): translate comment timestamps and edited label
cab017a2ce fix(comments): show either created or edited timestamp, not both
be4f1ed73b fix(transcription): always show comment list, compose box on demand
6475ebcc60 fix(transcription): auto-expand comment thread when block has comments
d8830b5a8e fix(transcription): use local state for textarea to prevent flicker on save
569a13e1b1 feat(transcription): show block numbers on PDF annotation overlays
7ad852dd52 fix(comments): remove empty state hint from CommentThread
03d76863cb fix: clicking annotation enters transcribe mode and scrolls to block
f3c29ffe58 refactor: remove legacy annotate mode — transcription replaces it