marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:12:32 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

🏗️ Markus Keller — Application Architect

Questions & Observations

  • Where does the alias JOIN live in document search? The issue says DocumentService search must join aliases when…
marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:12:27 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🧪 Sara Holt — QA Engineer

Missing acceptance criteria for the sequential flow

The current AC covers the end states but not the transitions. I'd add:

  • After Person A is selected,…
marcel commented on issue marcel/familienarchiv#181 2026-04-06 01:12:18 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • Test strategy for the search JOIN: The extension to PersonService and DocumentService search touches…
marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:12:13 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🏗️ Markus Keller — Application Architect

No backend changes required

This is a pure frontend refactor. No new API endpoints, no schema changes, no Spring Boot work. The existing…

marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:12:01 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

👨‍💻 Felix Brandt — Senior Fullstack Developer

Component decomposition

The current ConversationFilterBar.svelte does one job today (full filter panel) but will need to serve two…

marcel commented on issue marcel/familienarchiv#179 2026-04-06 01:10:12 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text

🎨 Leonie Voss — UX Design Lead

Design discussion outcomes — interaction model and layout decisions agreed with the product owner.

Resolved

  • **Interaction model — sequential…
marcel opened issue marcel/familienarchiv#181 2026-04-06 00:25:22 +02:00
feat: Person name aliases — support name changes over time (marriage, widowhood)
marcel opened issue marcel/familienarchiv#180 2026-04-06 00:23:00 +02:00
feat: Document list — extended sort options, broader search scope, eager tag filter, search feedback
marcel opened issue marcel/familienarchiv#179 2026-04-06 00:22:41 +02:00
ui: Korrespondenz view — unclear empty state, misplaced search header, focus misdirection, small text
f359c19e4c fix: bump comment text to text-base + reload annotations on block delete
ef11cbee4e feat(transcription): clicking annotation focuses corresponding block
676d3cb6a7 fix(pdf): prevent scroll-sync effect from hijacking page navigation
d389dc2023 feat(annotations): dim non-active annotations when a block is focused
Compare 2 commits »
b4212f5e86 feat(transcription): mobile stacked layout + cross-page scroll-sync
c22f2e41b1 fix(transcription): replace broken HTML5 drag with pointer-based drag
7d2d615e0c feat(transcription): add drag-and-drop + arrow button reordering
4a88b3ba82 feat(transcription): add dashed next-block CTA below block list
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 22:50:23 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

🔧 Tobias Wendt — DevOps & Platform Engineer (Round 3)

Verdict: ✅ Approved

What changed since Round 2

  • 9 dead component files deleted — reduces frontend build surface
  • No new…
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 22:50:08 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

🎨 Leonie Voss — UI/UX Design Lead (Round 3)

Verdict: ✅ Approved

Significant UI improvements since round 2. All my previous concerns have been addressed:

Resolved concerns

  1. ✅…
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 22:49:44 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

🔒 Nora "NullX" Steiner — Application Security Engineer (Round 3)

Verdict: ✅ Approved

All blockers from rounds 1-2 resolved. New changes reviewed:

What improved

  • **Regex HTML…
marcel commented on pull request marcel/familienarchiv#178 2026-04-05 22:49:25 +02:00
feat: Expandable metadata drawer + transcription system (#175, #176)

🧪 Sara Holt — QA Engineer & Test Strategist (Round 3)

Verdict: ⚠️ Approved with concerns

Test coverage — current state

Backend: solid

  • TranscriptionServiceTest — 13 unit…