marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel closed issue marcel/mealprep#25 2026-04-03 21:02:21 +02:00
Frontend: B4 — Cook mode (full-screen step-by-step)
marcel deleted branch feat/issue-28-variety-review from marcel/mealprep 2026-04-03 11:37:55 +02:00
marcel pushed to master at marcel/mealprep 2026-04-03 11:37:55 +02:00
6d76da5542 Merge pull request 'feat: C3 — Variety review screen (Issue #28)' (#41) from feat/issue-28-variety-review into master
8e82213d1e fix(variety): remove unused total, add warning border, fix abbreviation, aria
cb15143c30 refactor(variety): fix \$derived.by pattern, remove dead import, use pure functions
9adf786b8f test(variety): extract and test sub-score/warnings pure functions
1bf929280b test(variety): add all-zero edge case test for EffortBar
Compare 7 commits »
marcel merged pull request marcel/mealprep#41 2026-04-03 11:37:54 +02:00
feat: C3 — Variety review screen (Issue #28)
marcel commented on pull request marcel/mealprep#41 2026-04-03 11:37:47 +02:00
feat: C3 — Variety review screen (Issue #28)

Review feedback addressed

All reviewer blockers resolved in 5 commits:

🔧 Kai blockers fixed

  • $derived(() => {...}) anti-pattern → changed all 4 derivations to `$derived.by(() =>…
marcel pushed to feat/issue-28-variety-review at marcel/mealprep 2026-04-03 11:37:33 +02:00
8e82213d1e fix(variety): remove unused total, add warning border, fix abbreviation, aria
cb15143c30 refactor(variety): fix \$derived.by pattern, remove dead import, use pure functions
9adf786b8f test(variety): extract and test sub-score/warnings pure functions
1bf929280b test(variety): add all-zero edge case test for EffortBar
75c860a62b test(variety): add boundary tests for VarietyScoreHero (score=0,4,7,10)
Compare 5 commits »
marcel commented on pull request marcel/mealprep#41 2026-04-03 11:25:58 +02:00
feat: C3 — Variety review screen (Issue #28)

🛠️ Backend Engineer

Verdict: ⚠️ Approved with concerns

The frontend correctly uses the existing GET /v1/week-plans/{id}/variety-score endpoint. My concerns are about the mismatch…

marcel commented on pull request marcel/mealprep#41 2026-04-03 11:25:35 +02:00
feat: C3 — Variety review screen (Issue #28)

🎨 Atlas — UI/UX Designer

Verdict: ⚠️ Approved with concerns

The structural layout matches the spec well — mobile stacked, desktop 2-column, protein grid, effort bar, warning cards.…

marcel commented on pull request marcel/mealprep#41 2026-04-03 11:25:06 +02:00
feat: C3 — Variety review screen (Issue #28)

🔐 Sable — Security Engineer

Verdict: ✅ Approved

C3 is a read-only screen with no user input, no mutations, and no form submissions. The attack surface is narrow. I've audited the…

marcel commented on pull request marcel/mealprep#41 2026-04-03 11:24:47 +02:00
feat: C3 — Variety review screen (Issue #28)

🧪 QA Engineer — Test Coverage

Verdict: ⚠️ Approved with concerns

Good TDD discipline — tests were written before components and the red→green cycle is evident. Component tests cover…

marcel commented on pull request marcel/mealprep#41 2026-04-03 11:24:24 +02:00
feat: C3 — Variety review screen (Issue #28)

👨‍💻 Kai — Frontend Engineer

Verdict: ⚠️ Approved with concerns

The implementation is solid and the component split is clean — VarietyScoreHero, ScoreBreakdownList, `VarietyWarning…

marcel created pull request marcel/mealprep#41 2026-04-03 11:23:47 +02:00
feat: C3 — Variety review screen (Issue #28)
marcel pushed to feat/issue-28-variety-review at marcel/mealprep 2026-04-03 11:23:34 +02:00
8ad636f825 feat(variety): implement C3 variety review screen (Issue #28)
marcel created branch feat/issue-28-variety-review in marcel/mealprep 2026-04-03 11:23:33 +02:00
marcel deleted branch feat/issue-27-meal-suggestions from marcel/mealprep 2026-04-03 11:18:48 +02:00
marcel closed issue marcel/mealprep#27 2026-04-03 11:18:47 +02:00
Frontend: C2 — Meal suggestions (variety-aware)
marcel pushed to master at marcel/mealprep 2026-04-03 11:18:47 +02:00
7c07bc443b feat(suggestions): C2 — Meal suggestions (variety-aware) (#40)
marcel merged pull request marcel/mealprep#40 2026-04-03 11:18:46 +02:00
feat(suggestions): C2 — Meal suggestions (variety-aware)
marcel pushed to feat/issue-27-meal-suggestions at marcel/mealprep 2026-04-03 11:18:39 +02:00
1f2ec97500 fix(suggestions): address PR review — input validation, redirect, UI fixes
marcel commented on pull request marcel/mealprep#40 2026-04-03 11:14:23 +02:00
feat(suggestions): C2 — Meal suggestions (variety-aware)

🔧 Backend Engineer

Verdict: ✅ Approved

Frontend-only PR. API contract usage is correct.

Checked

  • GET /v1/week-plans with { query: { weekStart } } — correct for fetching the…