0511a735a5
Merge pull request 'feat(recipes): B3 — Add/edit recipe form with dynamic ingredients, steps, tag chips' (#38) from feat/issue-23-recipe-form into master
Review feedback addressed
All reviewer concerns have been resolved in 3 follow-up commits:
🔒 Security / Kai blockers fixed
JSON.parsecrash (DoS risk): Wrapped `JSON.parse(ingredi…
🖥️ Backend Engineer
Verdict: ⚠️ Approved with concerns
The server-side load and action functions are structurally clean. The parallel fetch in the edit load is the right call. A few…
🔒 Sable — Security Engineer
Verdict: 🚫 Changes requested
B3 is the highest-risk screen in the recipe domain — it's the first screen in this codebase to accept user-submitted…
🧪 QA Engineer
Verdict: ⚠️ Approved with concerns
The component tests are solid — 18 tests covering both add/edit states, add/remove rows, and chip selection. Load function tests are…
🎨 Atlas — UI/UX Designer
Verdict: 🚫 Changes requested
Blockers
RecipeForm has no design system styling
RecipeForm.svelte is entirely unstyled. Raw <fieldset>, <label>,…
👨💻 Kai — Frontend Engineer
Verdict: 🚫 Changes requested
Blockers
JSON.parse in actions has no error handling
Both +page.server.ts files do:
const parsedIngredients…