• Joined on 2026-03-17
marcel commented on pull request marcel/mealprep#37 2026-04-03 10:04:03 +02:00
feat(recipes): B2 — Recipe detail view with hero, ingredients, steps

🖥️ Backend Engineer

Verdict: Approved

Frontend-only PR. Checked the server-side load function and data mapping.

What Looks Good

+page.server.ts is correct

const {
marcel commented on pull request marcel/mealprep#37 2026-04-03 10:03:54 +02:00
feat(recipes): B2 — Recipe detail view with hero, ingredients, steps

🔒 Sable — Security Engineer

Verdict: Approved

B2 is a read-only detail view. Checked against the threat model — nothing alarming.

What I Verified

Access control:…

marcel commented on pull request marcel/mealprep#37 2026-04-03 10:03:45 +02:00
feat(recipes): B2 — Recipe detail view with hero, ingredients, steps

🧪 QA Engineer

Verdict: ⚠️ Approved with concerns

The test structure is good — each component has its own test file, behavior is tested from the user's perspective, and the load…

marcel commented on pull request marcel/mealprep#37 2026-04-03 10:03:33 +02:00
feat(recipes): B2 — Recipe detail view with hero, ingredients, steps

🎨 Atlas — UI/UX Designer

Verdict: 🚫 Changes requested

Blockers

Tag pills missing from hero The spec says "Pills: time, effort, serves, tags" in both mobile and desktop…

marcel commented on pull request marcel/mealprep#37 2026-04-03 10:03:23 +02:00
feat(recipes): B2 — Recipe detail view with hero, ingredients, steps

👨‍💻 Kai — Frontend Engineer

Verdict: 🚫 Changes requested

Blockers

Tags never rendered in RecipeHero.svelte The recipe.tags prop is accepted and typed, but nothing in the…

marcel created pull request marcel/mealprep#37 2026-04-03 10:02:34 +02:00
feat(recipes): B2 — Recipe detail view with hero, ingredients, steps
marcel created branch feat/issue-24-recipe-detail in marcel/mealprep 2026-04-03 10:02:25 +02:00
marcel pushed to feat/issue-24-recipe-detail at marcel/mealprep 2026-04-03 10:02:25 +02:00
00c48a7c96 feat(recipes): implement B2 recipe detail page with mobile/desktop layout
ce860d68e4 feat(recipes): add recipe detail load function with 404 handling
b39d04acce feat(recipes): add StepList component with numbered circles
c7e56a173d feat(recipes): add IngredientList component (read-only)
86a25eb038 feat(recipes): add RecipeHero component with image/no-image variants
Compare 5 commits »
marcel deleted branch feat/issue-22-recipe-library from marcel/mealprep 2026-04-03 09:53:43 +02:00
marcel pushed to master at marcel/mealprep 2026-04-03 09:53:42 +02:00
a34c6f30f2 Merge pull request 'feat(recipes): B1 — Recipe Library page with search and effort filtering' (#36) from feat/issue-22-recipe-library into master
9bb6293d9f fix(recipes): address review feedback — shared type, design system tokens, test coverage
47c748145d feat(recipes): implement recipe library page with search and effort filtering
a25286e385 feat(recipes): load recipe list from API in page server
a733e8dd66 feat(recipes): add RecipeGrid with 2/4-col responsive grid and empty state
Compare 7 commits »
marcel closed issue marcel/mealprep#22 2026-04-03 09:53:40 +02:00
Frontend: B1 — Recipe library
marcel merged pull request marcel/mealprep#36 2026-04-03 09:53:40 +02:00
feat(recipes): B1 — Recipe Library page with search and effort filtering
marcel pushed to feat/issue-22-recipe-library at marcel/mealprep 2026-04-03 09:53:36 +02:00
9bb6293d9f fix(recipes): address review feedback — shared type, design system tokens, test coverage
marcel commented on pull request marcel/mealprep#36 2026-04-03 09:51:55 +02:00
feat(recipes): B1 — Recipe Library page with search and effort filtering

🖥️ Backend Engineer

Verdict: Approved

This PR is frontend-only and I have limited concerns from the backend perspective. Here's what I checked:

What Looks Good

**`+page.server.ts…

marcel commented on pull request marcel/mealprep#36 2026-04-03 09:51:47 +02:00
feat(recipes): B1 — Recipe Library page with search and effort filtering

🔒 Sable — Security Engineer

Verdict: Approved

Checked this PR against the OWASP Top 10 and project-specific threat model. No blockers.

What I Verified

Access control: The…

marcel commented on pull request marcel/mealprep#36 2026-04-03 09:51:38 +02:00
feat(recipes): B1 — Recipe Library page with search and effort filtering

🧪 QA Engineer

Verdict: ⚠️ Approved with concerns

Coverage Summary

Overall test coverage is solid — all five new components have dedicated test files following the right patterns…

marcel commented on pull request marcel/mealprep#36 2026-04-03 09:51:25 +02:00
feat(recipes): B1 — Recipe Library page with search and effort filtering

🎨 Atlas — UI/UX Designer

Verdict: 🚫 Changes requested

Blockers

+page.svelte header link broken styling The "Rezept hinzufügen" link in the page header uses `class="btn…

marcel commented on pull request marcel/mealprep#36 2026-04-03 09:51:18 +02:00
feat(recipes): B1 — Recipe Library page with search and effort filtering

👨‍💻 Kai — Frontend Engineer

Verdict: 🚫 Changes requested

Blockers

RecipeSummary type defined in three places (RecipeCard.svelte, RecipeGrid.svelte, +page.svelte) These…

marcel created pull request marcel/mealprep#36 2026-04-03 09:50:03 +02:00
feat(recipes): B1 — Recipe Library page with search and effort filtering
marcel pushed to feat/issue-22-recipe-library at marcel/mealprep 2026-04-03 09:49:55 +02:00
47c748145d feat(recipes): implement recipe library page with search and effort filtering
a25286e385 feat(recipes): load recipe list from API in page server
a733e8dd66 feat(recipes): add RecipeGrid with 2/4-col responsive grid and empty state
35ed6ca878 feat(recipes): add FilterChipRow with effort filter chips
dc99459a2e feat(recipes): add RecipeCard component with compact/full image variants
Compare 5 commits »