marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#706 2026-06-01 09:58:36 +02:00
Friendly app-level validation for a RANGE with end-before-start (#678)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

The shape is right: domain-owned validation as a private guard on DocumentService, mirroring the existing `RelationshipSer…

marcel commented on issue marcel/familienarchiv#678 2026-06-01 09:31:27 +02:00
Friendly app-level validation for a RANGE with end-before-start

Implemented on feat/issue-678-range-date-validation → PR #706.

TDD, red→green, one commit per behaviour:

  1. a574d96 feat(document): reject RANGE with end before start — `ErrorCode.INVALID_…
marcel created pull request marcel/familienarchiv#706 2026-06-01 09:31:08 +02:00
Friendly app-level validation for a RANGE with end-before-start (#678)
marcel pushed to feat/issue-678-range-date-validation at marcel/familienarchiv 2026-06-01 09:30:42 +02:00
88600d54cd test(document): prove Postgres accepts an equal-date RANGE (#678)
654ac1478c feat(document): surface end-before-start inline on the date form (#678)
3a4c2c6225 feat(exception): backstop DataIntegrityViolation as a clean 400 (#678)
73f614bc3a feat(document): reject end date without RANGE precision (#678)
6c5e5273bb test(document): lock in accepted RANGE cases — equal/after/open/null-start (#678)
Compare 6 commits »
marcel created branch feat/issue-678-range-date-validation in marcel/familienarchiv 2026-06-01 09:30:42 +02:00
marcel deleted branch fix/ocr-trigger-csrf from marcel/familienarchiv 2026-05-31 22:29:03 +02:00
marcel pushed to main at marcel/familienarchiv 2026-05-31 22:29:02 +02:00
246568301a refactor(ocr): CSRF-wrap injected fetchImpl too, not just the default
aab4fe37ae fix(ocr): send CSRF token when starting an OCR run
Compare 2 commits »
marcel merged pull request marcel/familienarchiv#705 2026-05-31 22:29:01 +02:00
fix(ocr): send CSRF token when starting an OCR run
marcel pushed to fix/ocr-trigger-csrf at marcel/familienarchiv 2026-05-31 22:10:28 +02:00
246568301a refactor(ocr): CSRF-wrap injected fetchImpl too, not just the default
marcel created pull request marcel/familienarchiv#705 2026-05-31 21:10:14 +02:00
fix(ocr): send CSRF token when starting an OCR run
marcel pushed to fix/ocr-trigger-csrf at marcel/familienarchiv 2026-05-31 21:10:02 +02:00
aab4fe37ae fix(ocr): send CSRF token when starting an OCR run
marcel created branch fix/ocr-trigger-csrf in marcel/familienarchiv 2026-05-31 21:10:02 +02:00
marcel deleted branch feat/issue-703-stammbaum-lineage-highlight from marcel/familienarchiv 2026-05-31 20:11:08 +02:00
marcel pushed to main at marcel/familienarchiv 2026-05-31 20:11:08 +02:00
4ebebe1e07 test(stammbaum): assert AC8 recentre via viewBox, not replaceState (#703)
81224829a2 test(stammbaum): prove the AC8 mobile-centre wiring at the route layer (#703)
7cc2ddc6ad refactor(stammbaum): carry child id on the connector centre object (#703)
da3067150d test(stammbaum): assert connector dimming at the render layer (#703 AC5)
10249c33be fix(stammbaum): raise dimmed opacity to 0.45 and bind tests to the constant (#703)
Compare 13 commits »
marcel merged pull request marcel/familienarchiv#704 2026-05-31 20:11:07 +02:00
feat(stammbaum): highlight the selected person's bloodline (#703)
marcel closed issue marcel/familienarchiv#703 2026-05-31 20:11:07 +02:00
Highlight the selected person's bloodline on the family tree
4ebebe1e07 test(stammbaum): assert AC8 recentre via viewBox, not replaceState (#703)
marcel commented on pull request marcel/familienarchiv#704 2026-05-31 19:23:03 +02:00
feat(stammbaum): highlight the selected person's bloodline (#703)

👨‍💻 Felix Brandt — review follow-up

Pushed 5 commits addressing the open concerns plus a visual defect Marcel caught during testing.

Defect fixed (Marcel, screenshot)

  • **Connectors…
81224829a2 test(stammbaum): prove the AC8 mobile-centre wiring at the route layer (#703)
7cc2ddc6ad refactor(stammbaum): carry child id on the connector centre object (#703)
da3067150d test(stammbaum): assert connector dimming at the render layer (#703 AC5)
10249c33be fix(stammbaum): raise dimmed opacity to 0.45 and bind tests to the constant (#703)
9c12f62345 fix(stammbaum): keep dimmed nodes opaque so connectors do not bleed through (#703)
Compare 5 commits »
marcel commented on pull request marcel/familienarchiv#704 2026-05-31 17:14:00 +02:00
feat(stammbaum): highlight the selected person's bloodline (#703)

📋 Elicit — Requirements Engineer

Verdict: ✅ Approved (traceability complete; one criterion partially verified)

Requirement → verification trace for #703: