marcel

marcel commented on issue marcel/familienarchiv#708

2026-06-01 19:41:46 +02:00

[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

🧪 Sara Holt — QA Engineer & Test Strategist

Observations

The bug's signature is dev-passes / prod-fails: it only manifests in the browser modern build with assets served over HTTP.…

marcel commented on issue marcel/familienarchiv#709

2026-06-01 19:41:38 +02:00

Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

📋 Elicit — Requirements Engineer

Observations

The issue is well-structured (context, problem, candidate options, scoped ACs, pointers) — this is a healthy, refinement-ready ticket.…

marcel commented on issue marcel/familienarchiv#708

2026-06-01 19:41:30 +02:00

[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

🛡️ Nora Steiner ("NullX") — Application Security Engineer

Observations

This is a same-origin static-asset fetch (/pdfjs-wasm/*.wasm served by our own adapter-node). No SSRF, no…

marcel commented on issue marcel/familienarchiv#709

2026-06-01 19:41:26 +02:00

Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

🛠️ Tobias Wendt — DevOps & Platform Engineer

Observations

There is no shared cache to lose by lowering this. Caddy doesn't cache by default, and there's no CDN in front of a…

marcel commented on issue marcel/familienarchiv#709

2026-06-01 19:41:15 +02:00

Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Observations

This maps directly to Nielsen's heuristic #1, Visibility of system status. The density chart sits above the…

marcel commented on issue marcel/familienarchiv#708

2026-06-01 19:41:12 +02:00

[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

The existing renderer test (usePdfRenderer.svelte.test.ts) explicitly can't cover init()/loadDocument() — its own…

marcel commented on issue marcel/familienarchiv#709

2026-06-01 19:41:05 +02:00

Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

🧪 Sara Holt — QA Engineer

Observations

Exactly one test pins this behavior: DocumentControllerTest.density_emitsPrivateCacheControlHeader, asserting containsString("max-age=300") +…

marcel commented on issue marcel/familienarchiv#708

2026-06-01 19:40:57 +02:00

[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

🏛️ Markus Keller — Application Architect

Observations

The diagnosis is solid and the fix is a configuration fix, not a structural one — no ADR needed, no diagram update triggered…

marcel commented on issue marcel/familienarchiv#709

2026-06-01 19:40:56 +02:00

Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

🔒 Nora Steiner ("NullX") — Application Security Engineer

Observations

The cachePrivate() directive is doing real security work here, and it must stay. The density response is…

marcel commented on issue marcel/familienarchiv#709

2026-06-01 19:40:46 +02:00

Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

The change is genuinely tiny: one argument in DocumentController.density() (DocumentController.java:410) and one…

marcel commented on issue marcel/familienarchiv#709

2026-06-01 19:40:36 +02:00

Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

🏛️ Markus Keller — Application Architect

Observations

This is a presentation-layer tuning knob, not a structural change. The cache lives entirely in one line of DocumentController…

marcel opened issue marcel/familienarchiv#709

2026-06-01 19:39:14 +02:00

Revisit the 5-minute Cache-Control TTL on GET /api/documents/density

marcel opened issue marcel/familienarchiv#708

2026-06-01 19:38:15 +02:00

[bug] Scanned PDFs with CCITT/JBIG2 images render blank — pdf.js 5.x wasmUrl not configured

marcel deleted branch feat/issue-678-range-date-validation from marcel/familienarchiv

2026-06-01 13:12:00 +02:00

marcel pushed to main at marcel/familienarchiv

2026-06-01 13:11:59 +02:00

1dd162f1be test(document): prove the DB rejects end-before-start; assert persisted end (#678)

ff7cfd4b1a fix(exception): log the violated constraint name at WARN (#678)

88600d54cd test(document): prove Postgres accepts an equal-date RANGE (#678)

654ac1478c feat(document): surface end-before-start inline on the date form (#678)

3a4c2c6225 feat(exception): backstop DataIntegrityViolation as a clean 400 (#678)

Compare 8 commits »

marcel closed issue marcel/familienarchiv#678

2026-06-01 13:11:59 +02:00

Friendly app-level validation for a RANGE with end-before-start

marcel merged pull request marcel/familienarchiv#706

2026-06-01 13:11:58 +02:00

Friendly app-level validation for a RANGE with end-before-start (#678)

marcel commented on pull request marcel/familienarchiv#706

2026-06-01 11:04:43 +02:00

Friendly app-level validation for a RANGE with end-before-start (#678)

🔧 Review concerns addressed

Pushed ff7cfd4 and 1dd162f in response to the review. No hard blockers were raised; the actionable concerns are resolved as follows.

**🔧 Tobias (DevOps) —…

marcel pushed to feat/issue-678-range-date-validation at marcel/familienarchiv

2026-06-01 11:04:25 +02:00

1dd162f1be test(document): prove the DB rejects end-before-start; assert persisted end (#678)

ff7cfd4b1a fix(exception): log the violated constraint name at WARN (#678)

Compare 2 commits »

marcel opened issue marcel/familienarchiv#707

2026-06-01 11:04:08 +02:00

Clear meta_date_end when a document's precision leaves RANGE