marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#704 2026-05-31 17:13:51 +02:00
feat(stammbaum): highlight the selected person's bloodline (#703)

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

Nothing in my domain. No Compose service, image tag, volume, port, env var, secret, or CI-workflow change — purely a…

marcel commented on pull request marcel/familienarchiv#704 2026-05-31 17:13:46 +02:00
feat(stammbaum): highlight the selected person's bloodline (#703)

🎨 Leonie Voss — UI/UX & Accessibility Lead

Verdict: ⚠️ Approved with concerns

The mechanism is theme-safe and the right call: opacity (a lightness cue), not a hue swap, so the…

marcel commented on pull request marcel/familienarchiv#704 2026-05-31 17:13:36 +02:00
feat(stammbaum): highlight the selected person's bloodline (#703)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

The unit layer is strong and at the right altitude: highlightLineage.test.ts covers isolated /…

marcel commented on pull request marcel/familienarchiv#704 2026-05-31 17:13:25 +02:00
feat(stammbaum): highlight the selected person's bloodline (#703)

🛡️ Nora Steiner ("NullX") — Application Security Engineer

Verdict: ✅ Approved

No new attack surface. This is a client-side transform over a graph the user is already authorized to see…

marcel commented on pull request marcel/familienarchiv#704 2026-05-31 17:13:20 +02:00
feat(stammbaum): highlight the selected person's bloodline (#703)

🏛️ Markus Keller — Application Architect

Verdict: ✅ Approved

Altitude and boundaries are right. One pure, DOM-free module (highlightLineage.ts) at the same layout/ boundary as…

marcel commented on pull request marcel/familienarchiv#704 2026-05-31 17:13:13 +02:00
feat(stammbaum): highlight the selected person's bloodline (#703)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved with minor suggestions

TDD discipline is visible and honest: the pure highlightLineage.test.ts and the `recentreAbov…

marcel commented on issue marcel/familienarchiv#703 2026-05-31 16:44:42 +02:00
Highlight the selected person's bloodline on the family tree

👨‍💻 Implemented — PR #704

Built on feat/issue-703-stammbaum-lineage-highlight (off latest main), TDD throughout. PR: #704.

Commits

  • 7a655ce6 feat(stammbaum): add lineage…
marcel created pull request marcel/familienarchiv#704 2026-05-31 16:44:22 +02:00
feat(stammbaum): highlight the selected person's bloodline (#703)
marcel created branch feat/issue-703-stammbaum-lineage-highlight in marcel/familienarchiv 2026-05-31 16:43:59 +02:00
e5784caa9d docs(glossary): define "lineage highlight" (#703)
4583ee2c4d feat(stammbaum): centre the tapped person above the bottom sheet (#703)
0a7b4fa265 feat(stammbaum): add recentreAbove pan helper for the mobile anchor (#703)
a3858b6c80 feat(stammbaum): bind the lineage highlight to the selected person (#703)
9f5d7b8570 feat(stammbaum): dim connectors outside the highlighted lineage (#703)
Compare 7 commits »
marcel deleted branch feat/issue-683-search-filters-record from marcel/familienarchiv 2026-05-31 16:17:48 +02:00
marcel pushed to main at marcel/familienarchiv 2026-05-31 16:17:47 +02:00
3b594c0b0b test(document): pin undated null->false coercion on /ids (#683)
2e44cab614 docs(document): explain the DensityFilters->SearchFilters bridge (#683)
4c2f036de0 test(document): collapse all-null SearchFilters literals to noFilters() (#683)
dcb57ffacd refactor(document): thread SearchFilters through the search chain (#683)
1c961619f1 refactor(document): introduce SearchFilters record (#683)
Compare 5 commits »
marcel merged pull request marcel/familienarchiv#702 2026-05-31 16:17:46 +02:00
refactor(document): extract a SearchFilters record for the document search signatures (#683)
marcel closed issue marcel/familienarchiv#683 2026-05-31 16:17:46 +02:00
Extract a SearchFilters record for the document search signatures
marcel commented on issue marcel/familienarchiv#703 2026-05-31 16:06:53 +02:00
Highlight the selected person's bloodline on the family tree

🎨 Leonie Voss — UI/UX & Accessibility Lead (re-review)

The opacity-dim decision, kept accent bar, reduced-motion gating, and the mobile-centring behaviour (AC8) are all captured correctly,…

marcel commented on issue marcel/familienarchiv#703 2026-05-31 16:06:48 +02:00
Highlight the selected person's bloodline on the family tree

🧪 Sara Holt — QA Engineer & Test Strategist (re-review)

The test matrix, the ?focus initial-load case (AC9), and the cyclic-termination case (AC10) are all in the body now, at the right…

marcel commented on issue marcel/familienarchiv#703 2026-05-31 16:06:43 +02:00
Highlight the selected person's bloodline on the family tree

🛡️ Nora Steiner ("NullX") — Application Security Engineer (re-review)

My one finding is now codified: REQ-STAMMBAUM-04 + AC10 mandate the visited-set guard against cyclic PARENT_OF data…

marcel commented on issue marcel/familienarchiv#703 2026-05-31 16:06:40 +02:00
Highlight the selected person's bloodline on the family tree

🔧 Tobias Wendt — DevOps & Platform Engineer (re-review)

No concerns. Still a client-side-only change — no infrastructure, config, secret, or CI surface. Nothing for me to operate.

marcel commented on issue marcel/familienarchiv#703 2026-05-31 16:06:38 +02:00
Highlight the selected person's bloodline on the family tree

🏛️ Markus Keller — Application Architect (re-review)

Addressed. The body now states it plainly: no backend/endpoint/schema change, one pure module at the same boundary as buildLayout,…

marcel commented on issue marcel/familienarchiv#703 2026-05-31 16:06:35 +02:00
Highlight the selected person's bloodline on the family tree

👨‍💻 Felix Brandt — Senior Fullstack Developer (re-review)

The implementation notes now capture everything I'd have asked for — pure highlightLineage.ts beside buildLayout.ts,…