• Joined on 2026-03-17
marcel commented on issue marcel/mealprep#17 2026-04-02 12:53:08 +02:00
Frontend: App shell — responsive layout, navigation, routing

🏗️ Backend Engineer — Spring Boot / PostgreSQL Specialist

Questions & Observations

  • API contract for sidebar data: The sidebar shows the household name and a variety score widget.…
marcel commented on issue marcel/mealprep#17 2026-04-02 12:52:55 +02:00
Frontend: App shell — responsive layout, navigation, routing

👨‍💻 Kai — Frontend Engineer

Questions & Observations

  • Layout group vs. route group: SvelteKit supports both (group) layouts. Are we doing (auth) for the app shell and…
marcel deleted branch feat/issue-16-design-system from marcel/mealprep 2026-04-02 12:51:14 +02:00
marcel closed issue marcel/mealprep#16 2026-04-02 12:51:10 +02:00
Frontend: Design system foundation — Tailwind 4 theme, CSS tokens, fonts
marcel pushed to master at marcel/mealprep 2026-04-02 12:51:07 +02:00
0a2ef750c4 feat(design-system): add Tailwind 4 @theme tokens, fonts, and completeness tests
7c8d725fce test(design-system): assert WCAG 2.2 AA contrast for key color pairs
82815205d0 Wire frontend into Docker Compose with type-safe API client
b36d4c731d Add frontend journey specs with visual previews and LLM instructions
Compare 4 commits »
marcel merged pull request marcel/mealprep#31 2026-04-02 12:51:07 +02:00
Design system foundation — Tailwind 4 theme, CSS tokens, fonts
marcel commented on pull request marcel/mealprep#31 2026-04-02 12:50:14 +02:00
Design system foundation — Tailwind 4 theme, CSS tokens, fonts

Review: DevOps — Build & Deployment Perspective

Verdict: Approved


What's good

The changes are contained to frontend/ — no backend, no infrastructure, no CI pipeline…

marcel commented on pull request marcel/mealprep#31 2026-04-02 12:49:47 +02:00
Design system foundation — Tailwind 4 theme, CSS tokens, fonts

Review: UI/UX Expert — Visual Design & Accessibility Perspective

Verdict: Approved


What's good

Color palette: The warm-neutral base (--color-page: #fafaf7, `--color-sur…

marcel commented on pull request marcel/mealprep#31 2026-04-02 12:49:12 +02:00
Design system foundation — Tailwind 4 theme, CSS tokens, fonts

Review: Security Expert — Security Perspective

Verdict: Approved


What's good

This PR is CSS tokens and test infrastructure — the attack surface is minimal by nature. There…

marcel commented on pull request marcel/mealprep#31 2026-04-02 12:48:43 +02:00
Design system foundation — Tailwind 4 theme, CSS tokens, fonts

Review: QA Engineer — Test Quality Perspective

Verdict: Approved


What's good

This PR ships tests alongside the code — that's the baseline I always ask for, and it's…

marcel commented on pull request marcel/mealprep#31 2026-04-02 12:48:13 +02:00
Design system foundation — Tailwind 4 theme, CSS tokens, fonts

Review: Architect — Structure & Coupling Perspective

Verdict: Approved


What's good

The architectural decision to use Tailwind 4's @theme block as the single authoritative…

marcel commented on pull request marcel/mealprep#31 2026-04-02 12:47:45 +02:00
Design system foundation — Tailwind 4 theme, CSS tokens, fonts

Review: Kai (Frontend Engineer) — Developer Perspective

Verdict: Approved


What's good

The CSS-first Tailwind 4 @theme block is exactly the right approach — no `tailwind.co…

marcel created pull request marcel/mealprep#31 2026-04-02 12:46:42 +02:00
Design system foundation — Tailwind 4 theme, CSS tokens, fonts
marcel pushed to feat/issue-16-design-system at marcel/mealprep 2026-04-02 12:46:31 +02:00
0a2ef750c4 feat(design-system): add Tailwind 4 @theme tokens, fonts, and completeness tests
7c8d725fce test(design-system): assert WCAG 2.2 AA contrast for key color pairs
82815205d0 Wire frontend into Docker Compose with type-safe API client
b36d4c731d Add frontend journey specs with visual previews and LLM instructions
Compare 4 commits »
marcel created branch feat/issue-16-design-system in marcel/mealprep 2026-04-02 12:46:30 +02:00
marcel commented on issue marcel/mealprep#16 2026-04-02 12:45:30 +02:00
Frontend: Design system foundation — Tailwind 4 theme, CSS tokens, fonts

Implemented on feat/issue-16-design-system

What was built

src/app.html — Google Fonts loaded via preconnect + stylesheet link (Fraunces, DM Sans, DM Mono).

src/app.css —…

marcel commented on issue marcel/mealprep#30 2026-04-02 12:18:50 +02:00
Frontend: D1 — Shopping list

Spec file: specs/frontend/j5-shopping-list.html — screen D1 with mobile (checklist + blue shared banner) + desktop (split checklist + recipe…

marcel commented on issue marcel/mealprep#29 2026-04-02 12:18:47 +02:00
Frontend: J4 — Swap flow (action sheet + quick suggestions)

Spec file: specs/frontend/j4-adapt-on-the-fly.html — swap trigger (mobile action sheet) + C2 swap context (easiest-first suggestions) previews,…

marcel commented on issue marcel/mealprep#28 2026-04-02 12:18:44 +02:00
Frontend: C3 — Variety review (score breakdown)

Spec file: specs/frontend/j2-plan-the-week.html — screen C3 with mobile (stacked score + breakdown) + desktop (2-col score/protein grid + effort…

marcel commented on issue marcel/mealprep#27 2026-04-02 12:18:41 +02:00
Frontend: C2 — Meal suggestions (variety-aware)

Spec file: specs/frontend/j2-plan-the-week.html — screen C2 with mobile (context banner + ranked list) + desktop (split context panel + suggestions…