marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on issue marcel/mealprep#18 2026-04-02 14:16:30 +02:00
Frontend: A1 — Sign up screen

🧑‍💻 Kai — Frontend Engineer

Questions & Observations

  • Pre-auth layout suppression: The issue says "no navigation chrome". That means A1 needs a dedicated pre-auth layout…
marcel deleted branch feat/issue-16-design-system from marcel/mealprep 2026-04-02 14:14:27 +02:00
marcel closed issue marcel/mealprep#17 2026-04-02 14:14:23 +02:00
Frontend: App shell — responsive layout, navigation, routing
marcel pushed to master at marcel/mealprep 2026-04-02 14:14:19 +02:00
682580e11d feat(nav): add hover state on inactive tablet and desktop nav items
5c066d33ef feat(nav): add emoji icons to all nav components
4bd020fa16 test(nav): add parameterized active-state tests for all routes
bd8e901685 fix(nav): use segment-boundary route matching to prevent false positives
aeaca76534 fix(auth): handle users without household — fallback to 'Kein Haushalt'
Compare 19 commits »
marcel merged pull request marcel/mealprep#32 2026-04-02 14:14:19 +02:00
Frontend: App shell, navigation, routing, and design tokens
marcel commented on pull request marcel/mealprep#32 2026-04-02 14:05:41 +02:00
Frontend: App shell, navigation, routing, and design tokens

Review Concerns Addressed

All 12 reviewer concerns have been resolved across 12 commits:

marcel pushed to feat/issue-16-design-system at marcel/mealprep 2026-04-02 14:05:22 +02:00
682580e11d feat(nav): add hover state on inactive tablet and desktop nav items
5c066d33ef feat(nav): add emoji icons to all nav components
4bd020fa16 test(nav): add parameterized active-state tests for all routes
bd8e901685 fix(nav): use segment-boundary route matching to prevent false positives
aeaca76534 fix(auth): handle users without household — fallback to 'Kein Haushalt'
Compare 12 commits »
marcel commented on pull request marcel/mealprep#32 2026-04-02 13:47:20 +02:00
Frontend: App shell, navigation, routing, and design tokens

🎨 Atlas — UI/UX Designer

Verdict: ⚠️ Approved with concerns

Design System Compliance

The app.css @theme tokens are correct and complete. Color scales, spacing, radii, shadows,…

marcel commented on pull request marcel/mealprep#32 2026-04-02 13:46:59 +02:00
Frontend: App shell, navigation, routing, and design tokens

🔒 Sable — Security Engineer

Verdict: ⚠️ Approved with concerns

Concerns

  1. Auth guard bypasses static assets and API routes — hooks.server.ts only exempts /login,…
marcel commented on pull request marcel/mealprep#32 2026-04-02 13:46:37 +02:00
Frontend: App shell, navigation, routing, and design tokens

🧪 QA Engineer

Verdict: ⚠️ Approved with concerns

What's Covered (Good)

  • Nav config: 6 tests covering item count, labels, hrefs, section structure — solid.
  • MobileTabBar:…
marcel commented on pull request marcel/mealprep#32 2026-04-02 13:46:07 +02:00
Frontend: App shell, navigation, routing, and design tokens

🏗️ Backend Engineer

Verdict: ✅ Approved

Observations

This PR is frontend-only. From a backend perspective, I checked:

  1. API contract usage — hooks.server.ts calls `GET…
marcel commented on pull request marcel/mealprep#32 2026-04-02 13:45:56 +02:00
Frontend: App shell, navigation, routing, and design tokens

👨‍💻 Kai — Frontend Engineer

Verdict: ⚠️ Approved with concerns

Blockers

None.

Concerns

  1. resolve: { conditions: ['browser'] } at the top level of vite.config.ts —…
marcel created pull request marcel/mealprep#32 2026-04-02 13:44:51 +02:00
Frontend: App shell, navigation, routing, and design tokens
marcel pushed to feat/issue-16-design-system at marcel/mealprep 2026-04-02 13:44:35 +02:00
9626bde694 feat(shell): add route groups, layout server load, redirect, and placeholder pages
7a17873046 feat(auth): add auth guard in hooks.server.ts with session validation
cfe38c39aa feat(nav): add AppShell layout with breakpoint-switched navigation
56cfd137aa feat(nav): add DesktopSidebar with logo, nav sections, and variety widget slot
8f33f469de feat(nav): add TabletNavBar with horizontal pills and active state
Compare 7 commits »
marcel created branch feat/issue-16-design-system in marcel/mealprep 2026-04-02 13:44:34 +02:00
marcel commented on issue marcel/mealprep#17 2026-04-02 13:23:22 +02:00
Frontend: App shell — responsive layout, navigation, routing

Implementation Complete

All acceptance criteria implemented on branch feat/issue-16-design-system.

What was built

  • Shared nav config (src/lib/nav/nav.ts) — single source of…
marcel commented on issue marcel/mealprep#17 2026-04-02 13:03:28 +02:00
Frontend: App shell — responsive layout, navigation, routing

👨‍💻 Kai — Frontend Engineer — Discussion Outcomes

Interactive discussion with Marcel to resolve open implementation questions before starting work.

Resolved Items

  • **Route group…
marcel commented on issue marcel/mealprep#17 2026-04-02 12:54:02 +02:00
Frontend: App shell — responsive layout, navigation, routing

🎨 Atlas — UI/UX Designer

Questions & Observations

  • Tablet nav "inline at bottom, not fixed": I want to flag this for discussion. An inline nav at the bottom of the page content…
marcel commented on issue marcel/mealprep#17 2026-04-02 12:53:40 +02:00
Frontend: App shell — responsive layout, navigation, routing

🔒 Sable — Security Engineer

Questions & Observations

  • Auth guard placement: The issue mentions "pre-auth routes render without navigation chrome" — which implies there's a routing…
marcel commented on issue marcel/mealprep#17 2026-04-02 12:53:23 +02:00
Frontend: App shell — responsive layout, navigation, routing

🧪 QA Engineer — Test Specialist

Questions & Observations

  • Acceptance criteria are visual but not behavioral: The criteria say "Mobile: bottom tab bar with correct active states" —…