marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on issue marcel/mealprep#18 2026-04-02 14:49:12 +02:00
Frontend: A1 — Sign up screen

Implementation Complete — A1 Sign Up Screen

All acceptance criteria addressed. 110 tests pass, 0 type errors.

What was implemented

  • (public) layout refactored to bare slot —…
marcel commented on issue marcel/mealprep#19 2026-04-02 14:45:15 +02:00
Frontend: A2 — Household setup + invite

🎨 Atlas — UI/UX Designer

Questions & Observations

  • Progress sidebar — completed step treatment: The spec defines current step (green circle) and future steps (subtle circle), but…
marcel commented on issue marcel/mealprep#19 2026-04-02 14:44:58 +02:00
Frontend: A2 — Household setup + invite

🔒 Sable — Security Engineer

Questions & Observations

  • Authentication gate on A2: A2 is post-signup, so the user is authenticated. But is this enforced? The hooks.server.ts should…
marcel commented on issue marcel/mealprep#19 2026-04-02 14:44:43 +02:00
Frontend: A2 — Household setup + invite

🧪 QA Engineer — Test Coverage

Questions & Observations

The acceptance criteria only cover the happy path and layout. Here's what's missing:

Missing AC — bad paths & edge cases: -…

marcel commented on issue marcel/mealprep#19 2026-04-02 14:44:32 +02:00
Frontend: A2 — Household setup + invite

🗄️ Backend Engineer — Spring Boot / PostgreSQL

Questions & Observations

  • Atomicity of Continue action: The spec says Continue "saves household + creates household_member…
marcel commented on issue marcel/mealprep#19 2026-04-02 14:44:20 +02:00
Frontend: A2 — Household setup + invite

🧑‍💻 Kai — Frontend Engineer

Questions & Observations

  • Layout group: A1 is (auth) (no nav, no session). A2 is post-signup — the user is authenticated. But A2 also has no…
marcel commented on issue marcel/mealprep#18 2026-04-02 14:27:22 +02:00
Frontend: A1 — Sign up screen

🧑‍💻 Kai — Frontend Engineer — Implementation Discussion

Worked through all open frontend items. Everything resolved.

Resolved

  • Route group — Use a (auth) route group with a…
marcel commented on issue marcel/mealprep#18 2026-04-02 14:17:24 +02:00
Frontend: A1 — Sign up screen

🎨 Atlas — UI/UX Designer

Questions & Observations

The layout structure is correct and consistent with the design system. A few details need clarification before the spec can be…

marcel commented on issue marcel/mealprep#18 2026-04-02 14:17:09 +02:00
Frontend: A1 — Sign up screen

🔒 Sable — Security Engineer

Questions & Observations

Signup is the entry point to the entire authentication system. Getting the design right here prevents a class of vulnerabilities…

marcel commented on issue marcel/mealprep#18 2026-04-02 14:16:57 +02:00
Frontend: A1 — Sign up screen

🧪 QA Engineer — Test Coverage

Questions & Observations

The current acceptance criteria cover layout and happy-path submission. They're missing the majority of testable paths. Here's…

marcel commented on issue marcel/mealprep#18 2026-04-02 14:16:44 +02:00
Frontend: A1 — Sign up screen

🗄️ Backend Engineer — Spring Boot / PostgreSQL

Questions & Observations

  • Endpoint path: The issue says "POST create user_account" but doesn't specify the API path. Is it `POST…
marcel commented on issue marcel/mealprep#18 2026-04-02 14:16:30 +02:00
Frontend: A1 — Sign up screen

🧑‍💻 Kai — Frontend Engineer

Questions & Observations

  • Pre-auth layout suppression: The issue says "no navigation chrome". That means A1 needs a dedicated pre-auth layout…
marcel deleted branch feat/issue-16-design-system from marcel/mealprep 2026-04-02 14:14:27 +02:00
marcel closed issue marcel/mealprep#17 2026-04-02 14:14:23 +02:00
Frontend: App shell — responsive layout, navigation, routing
marcel merged pull request marcel/mealprep#32 2026-04-02 14:14:19 +02:00
Frontend: App shell, navigation, routing, and design tokens
marcel pushed to master at marcel/mealprep 2026-04-02 14:14:19 +02:00
682580e11d feat(nav): add hover state on inactive tablet and desktop nav items
5c066d33ef feat(nav): add emoji icons to all nav components
4bd020fa16 test(nav): add parameterized active-state tests for all routes
bd8e901685 fix(nav): use segment-boundary route matching to prevent false positives
aeaca76534 fix(auth): handle users without household — fallback to 'Kein Haushalt'
Compare 19 commits »
marcel commented on pull request marcel/mealprep#32 2026-04-02 14:05:41 +02:00
Frontend: App shell, navigation, routing, and design tokens

Review Concerns Addressed

All 12 reviewer concerns have been resolved across 12 commits:

marcel pushed to feat/issue-16-design-system at marcel/mealprep 2026-04-02 14:05:22 +02:00
682580e11d feat(nav): add hover state on inactive tablet and desktop nav items
5c066d33ef feat(nav): add emoji icons to all nav components
4bd020fa16 test(nav): add parameterized active-state tests for all routes
bd8e901685 fix(nav): use segment-boundary route matching to prevent false positives
aeaca76534 fix(auth): handle users without household — fallback to 'Kein Haushalt'
Compare 12 commits »
marcel commented on pull request marcel/mealprep#32 2026-04-02 13:47:20 +02:00
Frontend: App shell, navigation, routing, and design tokens

🎨 Atlas — UI/UX Designer

Verdict: ⚠️ Approved with concerns

Design System Compliance

The app.css @theme tokens are correct and complete. Color scales, spacing, radii, shadows,…

marcel commented on pull request marcel/mealprep#32 2026-04-02 13:46:59 +02:00
Frontend: App shell, navigation, routing, and design tokens

🔒 Sable — Security Engineer

Verdict: ⚠️ Approved with concerns

Concerns

  1. Auth guard bypasses static assets and API routes — hooks.server.ts only exempts /login,…