marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel merged pull request marcel/familienarchiv#172 2026-03-31 20:56:52 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout
marcel commented on issue marcel/familienarchiv#110 2026-03-31 20:56:21 +02:00
fix(security): annotate AppUser.password with @JsonIgnore to prevent accidental hash leakage

🚀 Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

  • No deployment or infrastructure changes required for this fix — it's a source code annotation with no config,…
marcel commented on issue marcel/familienarchiv#110 2026-03-31 20:56:09 +02:00
fix(security): annotate AppUser.password with @JsonIgnore to prevent accidental hash leakage

🎨 Leonie Voss — UI/UX Designer & Accessibility Strategist

No UI concerns from my angle — this fix touches only backend serialization with no user-facing rendering changes. I checked there…

marcel commented on issue marcel/familienarchiv#110 2026-03-31 20:56:00 +02:00
fix(security): annotate AppUser.password with @JsonIgnore to prevent accidental hash leakage

🏗️ Markus Keller — Application Architect

Questions & Observations

  • The diagnosis is exactly right. Placing the protection in every controller is logic at the wrong layer.…
marcel commented on issue marcel/familienarchiv#110 2026-03-31 20:55:40 +02:00
fix(security): annotate AppUser.password with @JsonIgnore to prevent accidental hash leakage

🧪 Sara Holt — QA Engineer & Test Strategist

Questions & Observations

  • The acceptance criteria list three endpoints to verify, which is good. But there's no mention of how these will…
marcel commented on issue marcel/familienarchiv#110 2026-03-31 20:55:21 +02:00
fix(security): annotate AppUser.password with @JsonIgnore to prevent accidental hash leakage

🔒 Nora "NullX" Steiner — Application Security Engineer

Questions & Observations

  • The root cause is correctly identified. Relying on manual setPassword(null) in every controller…
marcel commented on issue marcel/familienarchiv#110 2026-03-31 20:55:03 +02:00
fix(security): annotate AppUser.password with @JsonIgnore to prevent accidental hash leakage

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • The fix itself is a one-liner, but the cleanup work is equally important: every user.setPassword(null) call…
marcel pushed to feat/issue-171-dashboard-classic-split at marcel/familienarchiv 2026-03-31 20:46:49 +02:00
19035fbeab fix(dashboard): move right column first in DOM for mobile-first upload zone
79faee554a fix(dashboard): reduce incomplete docs widget from 5 to 3 items to prevent scroll
5adef7bec5 refactor(dashboard): delete DashboardMentions component — notifications page exists
595c2eb987 test(e2e): Classic Split — right column absent for read-only user, present for admin
518019f099 chore(e2e): gitignore Playwright auth state — regenerate in CI via auth.setup.ts
Compare 7 commits »
marcel commented on issue marcel/familienarchiv#173 2026-03-31 20:28:36 +02:00
feat(ui): implement responsive DocumentTopBar — final spec

🛠️ Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

This is a pure frontend component issue — no backend changes, no infrastructure changes. My concerns are limited…

marcel commented on issue marcel/familienarchiv#173 2026-03-31 20:28:12 +02:00
feat(ui): implement responsive DocumentTopBar — final spec

🎨 Leonie Voss — UI/UX Designer

Questions & Observations

Font sizes below 12px minimum — needs resolution before implementation

The spec specifies:

  • text-[9px] for chip name…
marcel commented on issue marcel/familienarchiv#173 2026-03-31 20:27:45 +02:00
feat(ui): implement responsive DocumentTopBar — final spec

🔒 Nora "NullX" Steiner — Security Engineer

Questions & Observations

Overall, this is a pure frontend rendering component with no new backend surface — the risk profile is low. That…

marcel commented on issue marcel/familienarchiv#173 2026-03-31 20:27:15 +02:00
feat(ui): implement responsive DocumentTopBar — final spec

🧪 Sara Holt — QA Engineer

Questions & Observations

Unit tests (specified): The issue specifies unit tests for all 6 utility functions. The acceptance criteria mention "all edge…

marcel closed issue marcel/familienarchiv#161 2026-03-31 20:27:04 +02:00
feat(ui): responsive DocumentTopBar — TopBar B1 spec implementation
marcel commented on issue marcel/familienarchiv#173 2026-03-31 20:26:49 +02:00
feat(ui): implement responsive DocumentTopBar — final spec

🏛️ Markus Keller — Application Architect

Questions & Observations

  • Where do the design tokens live? The spec references bg-surface, border-line, text-ink, text-ink-2,…
marcel commented on issue marcel/familienarchiv#173 2026-03-31 20:26:23 +02:00
feat(ui): implement responsive DocumentTopBar — final spec

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • TDD scope is partially specified. The issue explicitly calls for Vitest unit tests before implementing each…
marcel opened issue marcel/familienarchiv#173 2026-03-31 20:23:06 +02:00
feat(ui): implement responsive DocumentTopBar — final spec
marcel commented on pull request marcel/familienarchiv#172 2026-03-31 19:58:52 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

What I checked

No changes to docker-compose.yml, CI workflow files, or infrastructure configuration…

marcel commented on pull request marcel/familienarchiv#172 2026-03-31 19:58:41 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ⚠️ Approved with concerns

What works well

Touch targets — WCAG 2.5.5 ✓

class="flex min-h-[44px] items-center justify-betw…
marcel commented on pull request marcel/familienarchiv#172 2026-03-31 19:58:24 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

Attack surface review

New API call: GET /api/stats

The load function now fetches /api/stats via…

marcel commented on pull request marcel/familienarchiv#172 2026-03-31 19:58:15 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

What's well covered

  • Stats success path — result.stats equals the mocked `{ totalDocuments:…