• Joined on 2026-03-17
marcel commented on issue marcel/familienarchiv#173 2026-03-31 20:26:49 +02:00
feat(ui): implement responsive DocumentTopBar — final spec

🏛️ Markus Keller — Application Architect

Questions & Observations

  • Where do the design tokens live? The spec references bg-surface, border-line, text-ink, text-ink-2,…
marcel commented on issue marcel/familienarchiv#173 2026-03-31 20:26:23 +02:00
feat(ui): implement responsive DocumentTopBar — final spec

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • TDD scope is partially specified. The issue explicitly calls for Vitest unit tests before implementing each…
marcel opened issue marcel/familienarchiv#173 2026-03-31 20:23:06 +02:00
feat(ui): implement responsive DocumentTopBar — final spec
marcel commented on pull request marcel/familienarchiv#172 2026-03-31 19:58:52 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

What I checked

No changes to docker-compose.yml, CI workflow files, or infrastructure configuration…

marcel commented on pull request marcel/familienarchiv#172 2026-03-31 19:58:41 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ⚠️ Approved with concerns

What works well

Touch targets — WCAG 2.5.5 ✓

class="flex min-h-[44px] items-center justify-betw…
marcel commented on pull request marcel/familienarchiv#172 2026-03-31 19:58:24 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved

Attack surface review

New API call: GET /api/stats

The load function now fetches /api/stats via…

marcel commented on pull request marcel/familienarchiv#172 2026-03-31 19:58:15 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

What's well covered

  • Stats success pathresult.stats equals the mocked `{ totalDocuments:…
marcel commented on pull request marcel/familienarchiv#172 2026-03-31 19:58:03 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🏛️ Markus Keller — Application Architect

Verdict: Approved

What I checked

Data flow — load function stays clean

+page.server.ts continues to own all API calls and pass…

marcel commented on pull request marcel/familienarchiv#172 2026-03-31 19:57:52 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Blockers

None.

Suggestions

1. formatGermanDateInput bundled into a dashboard PR

`front…

marcel created pull request marcel/familienarchiv#172 2026-03-31 19:54:18 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout
marcel pushed to feat/issue-171-dashboard-classic-split at marcel/familienarchiv 2026-03-31 19:52:16 +02:00
92e7aa127c feat(dashboard): Classic Split — 2-col layout, remove DashboardMentions widget
f618364632 feat(dashboard): add stats footnote and min-h touch target to DashboardRecentDocuments
20923d04b6 feat(dashboard): replace notifications fetch with stats in server load
6d61297182 fix(tests): fix 27 failing frontend unit tests
fb636e4152 fix(e2e): replace fragile .last() selector with data-testid on password form submit
Compare 5 commits »
marcel created branch feat/issue-171-dashboard-classic-split in marcel/familienarchiv 2026-03-31 19:52:15 +02:00
marcel commented on issue marcel/familienarchiv#171 2026-03-31 19:42:06 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

Implementation complete — felix/issue-171-dashboard-classic-split

All 11 plan items implemented via red/green/refactor TDD. Final test suite: **172 server + 326 client = 498 tests, all…

marcel commented on issue marcel/familienarchiv#171 2026-03-31 17:56:32 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🎨 Leonie Voss — UI/UX & Accessibility — Interactive discussion summary

Worked through four open items from my initial review. All resolved.


text-ink-3 token existence Token…

marcel commented on issue marcel/familienarchiv#171 2026-03-31 17:25:59 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🛠️ Tobias Wendt — DevOps & Platform Engineer

Questions & Observations

This is a clean frontend-only refactor from an infrastructure perspective. No new services, no new environment…

marcel commented on issue marcel/familienarchiv#171 2026-03-31 17:25:42 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🎨 Leonie Voss — UI/UX & Accessibility

Questions & Observations

The spec is thorough and the AC list explicitly calls out min-h-[44px] and text-lg — those are the two things I most…

marcel commented on issue marcel/familienarchiv#171 2026-03-31 17:25:16 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🔐 Nora "NullX" Steiner — Security Engineer

Questions & Observations

This is a frontend layout refactor with one new backend call. The attack surface change is minimal, but a few things…

marcel commented on issue marcel/familienarchiv#171 2026-03-31 17:24:57 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🧪 Sara Holt — QA Engineer

Questions & Observations

The AC list is well-structured and specific — it reads almost like a test plan already. Let me map it to the test pyramid.

**Unit /…

marcel commented on issue marcel/familienarchiv#171 2026-03-31 17:24:33 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

🏛️ Markus Keller — Application Architect

Questions & Observations

  • Parallel fetches in the load function: The issue adds a /api/stats fetch alongside the existing document search…
marcel commented on issue marcel/familienarchiv#171 2026-03-31 17:24:10 +02:00
feat(dashboard): Classic Split — remove notification widget, restructure into 2-col layout

👨‍💻 Felix Brandt — Senior Fullstack Developer

Questions & Observations

  • TDD coverage plan: The issue lists rich acceptance criteria but no corresponding test plan. Before…