527d174e9c
fix(focus-rings): remove broken [&_input]:focus selectors and fix error state focus-visible
527d174e9c
fix(focus-rings): remove broken [&_input]:focus selectors and fix error state focus-visible
🎨 Leonie Voss — Pre-merge UI/Accessibility Discussion
Follow-up to my review (#1007) — worked through the open items before the developer sits down with this.
Resolved
**`ConversationF…
⚙️ Tobias Wendt — DevOps & Platform
Verdict: ✅ Approved
No infrastructure, CI, Docker, or deployment changes in this PR. Everything stays the same on the platform side.
What I…
🎨 Leonie Voss — UI/UX & Accessibility Lead
Verdict: ⚠️ Approved with concerns
The token design is excellent — semantically named, mode-aware, WCAG-compliant contrast values documented…
🔒 Nora "NullX" Steiner — Security Engineer
Verdict: ✅ Approved
This PR is a pure CSS design token migration — no new endpoints, no new data flows, no changes to authentication,…
🧪 Sara Holt — QA Engineer
Verdict: ⚠️ Approved with concerns
The test-first commit (fe1121d) is there, which I appreciate. The tests are at the correct layer (E2E/Playwright for CSS…
🏗️ Markus Keller — Application Architect
Verdict: ✅ Approved
This is a textbook design token migration: single source of truth, clear naming, correct layer placement, no business logic…
👨💻 Felix Brandt — Senior Fullstack Developer
Verdict: 🚫 Changes requested
Blockers
**ConversationFilterBar.svelte (both /conversations/ and /korrespondenz/) — broken…
Implementation complete ✅
All 8 tasks implemented on branch feat/issue-167-focus-ring-tokens → PR #170.
What was done
Token + global rule
--c-focus-ring: #012851(light) /…