marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#702 2026-05-31 15:45:10 +02:00
refactor(document): extract a SearchFilters record for the document search signatures (#683)

🏛️ Markus Keller — Senior Application Architect

✅ Approved

A textbook parameter-object refactor. Ten positional arguments — including two UUIDs (sender/receiver) and two LocalDates…

marcel created pull request marcel/familienarchiv#702 2026-05-31 15:43:35 +02:00
refactor(document): extract a SearchFilters record for the document search signatures (#683)
marcel commented on issue marcel/familienarchiv#683 2026-05-31 15:21:39 +02:00
Extract a SearchFilters record for the document search signatures

👨‍💻 Felix Brandt — Implementation complete

Branch feat/issue-683-search-filters-record (off main), pushed.

What was done

Threaded a filter-only SearchFilters record through the…

marcel pushed to feat/issue-683-search-filters-record at marcel/familienarchiv 2026-05-31 15:21:22 +02:00
dcb57ffacd refactor(document): thread SearchFilters through the search chain (#683)
1c961619f1 refactor(document): introduce SearchFilters record (#683)
Compare 2 commits »
marcel created branch feat/issue-683-search-filters-record in marcel/familienarchiv 2026-05-31 15:21:22 +02:00
marcel commented on issue marcel/familienarchiv#683 2026-05-31 14:48:24 +02:00
Extract a SearchFilters record for the document search signatures

⚙️ Tobias Wendt — DevOps & Platform Engineer

No concerns from my angle. I checked that this touches no Docker service, Compose file, CI workflow, env var, port, or migration — it's an…

marcel commented on issue marcel/familienarchiv#683 2026-05-31 14:48:22 +02:00
Extract a SearchFilters record for the document search signatures

🎨 Leonie Voss — UX Designer & Accessibility

No concerns from my angle. I checked that this is a pure backend service-signature refactor with no UI, no route, no API contract change (both…

marcel commented on issue marcel/familienarchiv#683 2026-05-31 14:48:19 +02:00
Extract a SearchFilters record for the document search signatures

📋 Elicit — Requirements Engineer

Observations

  • The issue is implementation-ready: Scope, Suggested approach, Acceptance criteria, and DoD are all present, with the three structural…
marcel commented on issue marcel/familienarchiv#683 2026-05-31 14:48:08 +02:00
Extract a SearchFilters record for the document search signatures

🔒 Nora Steiner ("NullX") — Application Security Engineer

Observations

  • I checked the one security-relevant assertion in the AC: **@RequirePermission(Permission.WRITE_ALL) on…
marcel commented on issue marcel/familienarchiv#683 2026-05-31 14:47:57 +02:00
Extract a SearchFilters record for the document search signatures

🧪 Sara Holt — Senior QA Engineer

Observations

  • Test-name drift in the Acceptance Criteria — heads up. The cited controller tests search_with_undated_* and `getDocumentIds_with_und…
marcel commented on issue marcel/familienarchiv#683 2026-05-31 14:47:43 +02:00
Extract a SearchFilters record for the document search signatures

🏛️ Markus Keller — Senior Application Architect

Observations

  • This is the right move and the right size. A 13-parameter positional signature where sender/receiver (both UUID) and…
marcel commented on issue marcel/familienarchiv#683 2026-05-31 14:47:31 +02:00
Extract a SearchFilters record for the document search signatures

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

  • Verified the chain in current DocumentService.java. Line numbers have drifted slightly: findIdsForFilter is at 503…
marcel deleted branch feat/issue-697-readers-read-transcriptions from marcel/familienarchiv 2026-05-31 13:28:41 +02:00
marcel pushed to main at marcel/familienarchiv 2026-05-31 13:28:40 +02:00
2cc43c3c44 test(document): run OCR-status page tests as a writer (#697)
6c4d10d12f test(security): lock READ_ALL -> 403 on comment-write endpoints (#697)
2cdb48f4a4 refactor(document): compute hasTranscription only on the detail path (#697)
6be7413ba4 test(e2e): read-only user reads a transcription, no edit affordances (#697)
33aeefbb5b feat(ui): confine read-only users to the transcription read view (#697)
Compare 12 commits »
marcel closed issue marcel/familienarchiv#697 2026-05-31 13:28:38 +02:00
feat(transcription): let read-only users read transcriptions (read tab only, no edit)
marcel merged pull request marcel/familienarchiv#700 2026-05-31 13:28:38 +02:00
feat(transcription): let read-only users read transcriptions (read tab only, no edit) (#697)
bd3c1ced1d test(document): run OCR-status page tests as a writer (#697)
marcel closed issue marcel/familienarchiv#698 2026-05-31 12:58:11 +02:00
As a reader browsing topics I want each theme box to count documents across its whole sub-topic tree so I can judge a topic's depth at a glance
marcel deleted branch worktree-feat+issue-698-themen-subtree-count from marcel/familienarchiv 2026-05-31 12:58:11 +02:00
marcel merged pull request marcel/familienarchiv#701 2026-05-31 12:58:10 +02:00
feat(themen): count documents across the whole sub-topic tree (#698)