marcel

marcel pushed to main at marcel/familienarchiv

2026-05-28 23:21:18 +02:00

23d93d492d refactor(stammbaum): TestNode type alias drops generation cast (#361)

2097dddf3a docs(adr): ADR-026 cross-references findAc3Candidates() predicate (#361)

585f28cd23 refactor(stammbaum): single source of truth for findAc3Candidates (#361)

2c18cb8b0d docs(adr): ADR-026 names assessor + revisit cadence for dagre deferral (#361)

655f0c3531 test+feat(stammbaum): capture script soft-warns on AC3 revisit trigger (#361)

Compare 20 commits »

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:24:19 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

📋 "Elicit" — Requirements Engineer (cycle 4 / convergence check)

Verdict: ✅ Approved — no remaining concerns

Cycle 3 was ✅ for me on all open requirements concerns. Cycle 4's three…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:24:00 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

🛠️ Tobias Wendt — DevOps & Platform Engineer (cycle 4 / convergence check)

Verdict: ✅ Approved — no remaining concerns

Cycle 4 touched zero infrastructure surface. ADR-026 §"Operationa…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:23:49 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

🎨 Leonie Voss — UX Designer & Accessibility Strategist (cycle 4 / convergence check)

Verdict: ✅ Approved — no remaining concerns

Cycle-3 was ✅ for me. Cycle-4's three commits are all…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:23:31 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

🛡️ Nora "NullX" Steiner — Application Security Engineer (cycle 4 / convergence check)

Verdict: ✅ Approved — no remaining concerns

Cycle-3 was ✅ for me. Cycle-4 introduces three…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:23:11 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

🧪 Sara Holt — QA Engineer (cycle 4 / convergence check)

Verdict: ✅ Approved — no remaining concerns

Cycle-3 was ✅ for me with one cosmetic. Cycle-4 closes that cosmetic and adds zero…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:22:54 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

🏛️ Markus Keller — Application Architect (cycle 4 / convergence check)

Verdict: ✅ Approved — no remaining concerns

Both of my cycle-3 ⚠️ items are now closed in code. The architectura…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:22:35 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

👨‍💻 Felix Brandt — Senior Fullstack Developer (cycle 4 / convergence check)

Verdict: ✅ Approved — no remaining concerns

Three atomic structural commits. None ships behaviour. Each is…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:17:56 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Felix Brandt — cycle-4 follow-up (all cycle-3 concerns resolved)

Three atomic commits land the cycle-3 concerns. Each is test-anchored against the existing suite — no new behaviour, pure…

marcel pushed to feature/361-stammbaum-multi-spouse at marcel/familienarchiv

2026-05-28 21:17:32 +02:00

23d93d492d refactor(stammbaum): TestNode type alias drops generation cast (#361)

2097dddf3a docs(adr): ADR-026 cross-references findAc3Candidates() predicate (#361)

585f28cd23 refactor(stammbaum): single source of truth for findAc3Candidates (#361)

Compare 3 commits »

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:10:02 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

"Elicit" — Requirements Engineer (cycle 3 / final check)

Verdict: Approved

Both of the two soft follow-ups I left open in cycle-2 are now committed. The artefact discipline on this PR is…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:09:29 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Tobias Wendt — DevOps & Platform Engineer (cycle 3 / final check)

Verdict: Approved

Cycle-2 was ✅ for me and stays ✅. Cycle-3 touched zero infrastructure surface — no Compose changes,…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:09:16 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Leonie Voss — UX Designer & Accessibility Strategist (cycle 3 / final check)

Verdict: Approved

My cycle-2 ⚠️ hinged on a single promise: the axe-core readout had to land in the PR…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:08:48 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Nora "NullX" Steiner — Application Security Engineer (cycle 3 / final check)

Verdict: Approved

Cycle-2 was ✅ for me. Cycle-3 introduces zero new attack surface from a security lens.…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:08:30 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Sara Holt — QA Engineer (cycle 3 / final check)

Verdict: Approved

Both of my cycle-2 ⚠️ follow-ups landed exactly as asked. The two test-tightening concerns I filed are now closed in…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:08:07 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Markus Keller — Application Architect (cycle 3 / final check)

Verdict: Approved with concerns

Cycle-2 was ✅. The four cycle-3 commits touch tests, the capture script, and one ADR — no…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:07:47 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Felix Brandt — Senior Fullstack Developer (cycle 3 / final check)

Verdict: Approved with concerns

Four atomic commits, each preceded by the failing assertion the test would catch —…

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 21:04:42 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Cycle-3 iteration — 4 commits + axe-core readout

Closing the cycle-2 concerns from @Sara, @Leonie, and @Elicit. Per-concern resolution below.

Sara (cycle-2)

**#5 — AC2…

marcel pushed to feature/361-stammbaum-multi-spouse at marcel/familienarchiv

2026-05-28 21:04:11 +02:00

2c18cb8b0d docs(adr): ADR-026 names assessor + revisit cadence for dagre deferral (#361)

655f0c3531 test+feat(stammbaum): capture script soft-warns on AC3 revisit trigger (#361)

e7931335ce test(stammbaum): assert r=6 marriage dot fill is var(--c-primary) (#361)

89bb0b5d65 test(stammbaum): assert no node sits between AC2 spouses on same y (#361)

Compare 4 commits »

marcel commented on pull request marcel/familienarchiv#693

2026-05-28 20:51:52 +02:00

fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

📋 "Elicit" — Requirements Engineer (cycle 2)

Verdict: ✅ Approved

Of the six concerns I raised in cycle 1, three had a clear fix path and all three landed. The other three were…