• Joined on 2026-03-17
marcel pushed to feat/issue-692-stammbaum-mobile-panzoom at marcel/familienarchiv 2026-05-29 19:25:24 +02:00
b1309db8db feat(stammbaum): land a fresh visit on the tree's top-left corner (#692)
marcel commented on pull request marcel/familienarchiv#694 2026-05-29 19:11:42 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view (#692)

🔧 Review feedback addressed + live bug fixes

Pushed the fixes for the review blockers/concerns and several issues found running it live.

Blockers — fixed

  • [Elicit] ADR-026 collision
marcel pushed to feat/issue-692-stammbaum-mobile-panzoom at marcel/familienarchiv 2026-05-29 19:11:24 +02:00
01b902e885 test(stammbaum): assert zoom-out floor via mirrored ?z; e2e affordance beforeEach (#692)
20db3d0d8f test(stammbaum): cover animateView rAF tween + server 401/500 paths (#692)
0306023610 fix(stammbaum): 44x44 touch targets for panel + affordance icon buttons (#692)
8f836dfefb feat(stammbaum): raise MAX_ZOOM 3→10 so phones can zoom in to read (#692)
Compare 4 commits »
marcel pushed to feat/issue-692-stammbaum-mobile-panzoom at marcel/familienarchiv 2026-05-29 18:55:47 +02:00
b170085311 fix(stammbaum): node tap stopped selecting — defer pointer capture to drag start (#692)
d5a7974f3a fix(shared): trapFocus restores focus to the opener on destroy (#692)
53660eadc9 test(stammbaum): assert drag-pan before release to avoid inertia flake (#692)
f4b631e1bc refactor(stammbaum): extract + unit-test pinch and inertia math (#692)
Compare 4 commits »
marcel pushed to feat/issue-692-stammbaum-mobile-panzoom at marcel/familienarchiv 2026-05-29 18:43:18 +02:00
c1dd6d299f feat(stammbaum): round pan/zoom URL params for readable shared links (#692)
a458d3508b feat(stammbaum): pinned generation-label rail on all viewports (#692)
bb2a89da58 feat(stammbaum): land a fresh visit at readable z=3, keep fit-to-screen at z=1 (#692)
578bebbd8b fix(stammbaum): URL pan/zoom sync never fired — gate replaceState on router-ready (#692)
7e859252a3 docs(stammbaum): renumber pan/zoom ADR 026→027 (collision with #361) (#692)
Compare 5 commits »
marcel commented on pull request marcel/familienarchiv#694 2026-05-29 17:36:26 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view (#692)

📋 Elicit — Requirements Engineer

Verdict: 🚫 Request changes (one blocker on the acceptance gate + one traceability defect; the implementation itself satisfies the resolved OQ/AC…

marcel commented on pull request marcel/familienarchiv#694 2026-05-29 17:35:56 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view (#692)

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approve (with one CI-coverage caveat worth fixing before relying on it). Build/bundle/CI/dependency/infra are clean — the…

marcel commented on pull request marcel/familienarchiv#694 2026-05-29 17:35:42 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view (#692)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ⚠️ Approve with non-blocking suggestions. The design notes were honoured faithfully — bottom-right one-handed cluster,…

marcel commented on pull request marcel/familienarchiv#694 2026-05-29 17:35:15 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view (#692)

🧪 Sara Holt — Senior QA Engineer

Verdict: 🚫 Changes requested — solid pure-function and component coverage, but the single most complex new module (panZoomGestures.ts) is almost…

marcel commented on pull request marcel/familienarchiv#694 2026-05-29 17:34:57 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view (#692)

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: Approve — no security blockers. The requested ?z=Infinity / ?cx=NaN DoS fix is correctly implemented and defended…

marcel commented on pull request marcel/familienarchiv#694 2026-05-29 17:34:44 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view (#692)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approve with suggestions (no blockers). Disciplined work: the commit history is textbook red/green (each pure helper landed…

marcel commented on pull request marcel/familienarchiv#694 2026-05-29 17:34:27 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view (#692)

🏛️ Markus Keller — Application Architect

Verdict: Approved

I reviewed this strictly through the architecture lens: SSR safety, module-load DOM access, state ownership (props-down/call…

marcel commented on issue marcel/familienarchiv#692 2026-05-29 17:19:24 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view

Implemented — PR #694

Full epic delivered on feat/issue-692-stammbaum-mobile-panzoom (21 atomic TDD commits).

⚠️ OQ-007 reversed → custom viewBox (ADR-026)

OQ-007 resolved to…

marcel created pull request marcel/familienarchiv#694 2026-05-29 17:18:58 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view (#692)
marcel pushed to feat/issue-692-stammbaum-mobile-panzoom at marcel/familienarchiv 2026-05-29 17:18:29 +02:00
ba053b3c23 docs(stammbaum): ADR-026 custom viewBox pan/zoom + glossary terms (#692)
80f5e0b147 test(stammbaum): mobile visual + structural e2e at 320/414/768 (#692)
11b70d814f feat(stammbaum): first-load touch affordance hint (#692)
1dffb430ac feat(stammbaum): centre-on-person control in the panel title row (#692)
1e5a45a027 feat(stammbaum): dismissible accessible mobile bottom sheet (#692)
Compare 10 commits »
marcel created branch feat/issue-692-stammbaum-mobile-panzoom in marcel/familienarchiv 2026-05-29 17:18:28 +02:00
marcel commented on issue marcel/familienarchiv#692 2026-05-29 16:12:35 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view

🗳️ Discussion — Decision Queue resolved

Working through the 5 open decisions from the Decision Queue comment before implementation starts.

Resolved

  • OQ-007 — Library choice:
marcel deleted branch feature/361-stammbaum-multi-spouse from marcel/familienarchiv 2026-05-28 23:21:20 +02:00
marcel closed issue marcel/familienarchiv#361 2026-05-28 23:21:18 +02:00
tech-debt: fix Stammbaum layout limits (multi-spouse, intra-family marriage, unseeded loose spouse) — adopt dagre only if in-house fixes diverge
marcel merged pull request marcel/familienarchiv#693 2026-05-28 23:21:18 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)