• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:51:19 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

🛠️ Tobias Wendt — DevOps & Platform Engineer (cycle 2)

Verdict: Approved

Cycle-1 was an approve with one operational angle on the capture script (running with BACKEND_URL

marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:50:54 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

🎨 Leonie Voss — UX Designer & Accessibility Strategist (cycle 2)

Verdict: ⚠️ Approved with concerns

No UX-shaping code changed between cycles. The six new commits are: capture-script…

marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:50:25 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

🛡️ Nora "NullX" Steiner — Application Security Engineer (cycle 2)

Verdict: Approved

The one concrete concern I raised in cycle 1 — the capture-script's default admin credentials —…

marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:49:57 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

🧪 Sara Holt — QA Engineer (cycle 2)

Verdict: ⚠️ Approved with concerns

Of the six suggestions I raised in cycle 1, two were addressed and four were explicitly skipped. The two that…

marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:49:22 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

🏛️ Markus Keller — Application Architect (cycle 2)

Verdict: Approved

Three of my cycle-1 suggestions had a clear fix path and all three landed cleanly.

Cycle-1 concerns —…

marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:48:58 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

👨‍💻 Felix Brandt — Senior Fullstack Developer (cycle 2)

Verdict: Approved

Cycle-1 had two suggestions I cared about most. Both landed.

Cycle-1 concerns — status

  1. **`assignRa…
marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:46:36 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Iteration on review concerns — 6 commits pushed

Thank you for the thorough seven-persona pass. Pushed six new commits addressing the suggestions where there was a clear fix path. Below is a…

marcel pushed to feature/361-stammbaum-multi-spouse at marcel/familienarchiv 2026-05-28 20:45:58 +02:00
b8ad64dd13 docs(stammbaum): layout glossary + AC3 deferral SQL (#361)
9bdd9fb3a5 refactor(stammbaum): extract computeViewBox() helper from buildLayout (#361)
52e48a6b8c refactor(stammbaum): extract assignRanks() helper from buildLayout (#361)
fd624f6ec8 test(stammbaum): assert no canonical SPOUSE_OF carries fromYear (#361)
6d8655bad1 test+fix(stammbaum): capture script floors >= 1 multi-spouse person (#361)
Compare 6 commits »
marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:33:14 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

"Elicit" — Requirements Engineer

Verdict: Approved with concerns

Brownfield mode. The PR body maps every acceptance criterion from #361 to a concrete outcome ( AC1/AC2/AC4/AC5, ⏸️

marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:32:45 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

Nothing in this PR touches my surface. ADR-026 says so explicitly under "Operational" — no CI changes, no compose changes, no…

marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:32:22 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Leonie Voss — UX Designer & Accessibility Strategist

Verdict: Approved with concerns

Three of the four UX-facing fixes in this PR resolve issues I raised during persona review:

  • **AC1…
marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:31:49 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved with concerns

Pure frontend layout work — no controller, no service, no JPQL, no auth boundary, no template…

marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:31:22 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Sara Holt — QA Engineer

Verdict: Approved with concerns

Every feature commit on this PR is preceded by a test+feat or test+fix commit. The red-green discipline is visible in the git…

marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:30:51 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Markus Keller — Application Architect

Verdict: Approved

The decision artefact (ADR-026) is exactly the kind of document I want in docs/adr/: context, decision, alternatives, consequence…

marcel commented on issue marcel/familienarchiv#692 2026-05-28 20:30:38 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view

🗳️ Decision Queue — Action Required

5 decisions need your input before implementation starts.

Architecture

  • Library choice (OQ-007): Felix recommends panzoom by timmywil…
marcel commented on pull request marcel/familienarchiv#693 2026-05-28 20:30:25 +02:00
fix(stammbaum): multi-spouse + intra-family marriage layout (#361)

Felix Brandt — Senior Fullstack Developer

Verdict: Approved with concerns

Disciplined work overall. Six atomic commits, each preceded by a failing test that exercises the new behaviour…

marcel commented on issue marcel/familienarchiv#692 2026-05-28 20:30:06 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view

📋 Elicit — Requirements Engineer

Observations

OQ resolutions must be folded into the issue body before implementation

The user has resolved OQ-001 through OQ-008 with the…

marcel commented on issue marcel/familienarchiv#692 2026-05-28 20:29:44 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view

🛠️ Tobias Wendt — DevOps & Platform Engineer

Observations

No infrastructure changes required — this is entirely a frontend concern. Docker Compose, CI pipeline, and server config are…

marcel commented on issue marcel/familienarchiv#692 2026-05-28 20:29:26 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Observations

Control placement mismatch

The wireframe specifies the zoom cluster (+/−/⤢) in the bottom-right of the…

marcel commented on issue marcel/familienarchiv#692 2026-05-28 20:29:01 +02:00
feat(stammbaum): mobile read path — pan, zoom, fit-to-view

🧪 Sara Holt — Senior QA Engineer

Observations

  • Acceptance gate requires Playwright visual regression at 320/414/768px. This is non-negotiable and must include both the new…