marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel pushed to main at marcel/familienarchiv 2026-05-28 17:33:06 +02:00
a5e3205520 fix(stammbaum): make gutter visibility prop-overridable for tests (#689)
f124529ee8 fix(stammbaum): seed gutter media-query state synchronously (#689)
61ca5a6e40 test(person): tighten generation null-clear coverage (#689)
516a0a3814 refactor(person): single source of truth for generation bounds (#689)
39276b179d docs(stammbaum): document gutter + persons.generation column (#689)
Compare 17 commits »
marcel closed issue marcel/familienarchiv#689 2026-05-28 17:33:05 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter
marcel merged pull request marcel/familienarchiv#690 2026-05-28 17:33:05 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter
marcel pushed to feature/689-generation-gutter at marcel/familienarchiv 2026-05-28 16:54:02 +02:00
a5e3205520 fix(stammbaum): make gutter visibility prop-overridable for tests (#689)
marcel commented on pull request marcel/familienarchiv#690 2026-05-28 16:23:03 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter

Review round 1 — addressed

Pushed three fix-up commits + one CI fix:

marcel pushed to feature/689-generation-gutter at marcel/familienarchiv 2026-05-28 16:22:38 +02:00
f124529ee8 fix(stammbaum): seed gutter media-query state synchronously (#689)
61ca5a6e40 test(person): tighten generation null-clear coverage (#689)
516a0a3814 refactor(person): single source of truth for generation bounds (#689)
Compare 3 commits »
marcel commented on pull request marcel/familienarchiv#690 2026-05-28 16:09:28 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter

🎨 Leonie Voss — UI/UX & Accessibility Lead

Verdict: ⚠️ Approved with concerns

This is a thoughtful brand- and a11y-aware implementation. The gutter is the right pattern (decorative…

marcel commented on pull request marcel/familienarchiv#690 2026-05-28 16:08:51 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

The test coverage on this PR is the strongest I've seen on the project in a while. Every layer of the pyramid is…

marcel commented on pull request marcel/familienarchiv#690 2026-05-28 16:08:17 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter

🛡️ Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

Read the full diff against the OWASP Top 10 plus the project-specific concerns (mass assignment, SSRF,…

marcel commented on pull request marcel/familienarchiv#690 2026-05-28 16:07:48 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter

📐 Elicit — Senior Requirements Engineer

Verdict: ⚠️ Approved with concerns

Issue #689 is one of the densest, most rigorous specs I've reviewed on this project — it would be a strong…

marcel commented on pull request marcel/familienarchiv#690 2026-05-28 16:07:18 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

This is a small, clean migration on a stack I already operate. Nothing in the diff changes the service topology, adds a…

marcel commented on pull request marcel/familienarchiv#690 2026-05-28 16:06:58 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

This is textbook TDD across three stacks. Every change has a test that precedes it: the parameterised regex matrix in…

marcel commented on pull request marcel/familienarchiv#690 2026-05-28 16:06:31 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter

🏛️ Markus Keller — Senior Application Architect

Verdict: ⚠️ Approved with concerns

The structural shape of this PR is exactly what I would have asked for: integrity pushed to…

marcel created pull request marcel/familienarchiv#690 2026-05-28 16:04:06 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter
marcel commented on issue marcel/familienarchiv#689 2026-05-28 16:01:02 +02:00
feat(person): persist Excel generation (G0–G6) and show on Stammbaum gutter

Implementation complete on feature/689-generation-gutter (pushed). 13 atomic commits:

  1. 1cb05697 refactor(stammbaum): extract buildLayout to pure module
  2. f22508ca feat(person): add…
marcel created branch feature/689-generation-gutter in marcel/familienarchiv 2026-05-28 16:00:25 +02:00
marcel pushed to feature/689-generation-gutter at marcel/familienarchiv 2026-05-28 16:00:25 +02:00
39276b179d docs(stammbaum): document gutter + persons.generation column (#689)
577dd3fcb1 feat(person): generation dropdown on Person edit/new forms (#689)
c0b500b692 feat(stammbaum): render generation gutter on the family tree (#689)
cb8c85a742 feat(stammbaum): seed layout rank from imported generation (#689)
c93d3b03ed chore(api): mirror generation field in api types + PersonFormData (#689)
Compare 10 commits »
marcel deleted branch docs/import-migration from marcel/familienarchiv 2026-05-28 15:05:53 +02:00
marcel pushed to main at marcel/familienarchiv 2026-05-28 15:05:52 +02:00
ccf1661768 Merge branch 'main' into docs/import-migration
74cc4c8722 fix(admin): drop processed count from RUNNING import card
548bc60747 fix(admin): include CSRF token on admin trigger/backfill POSTs
4581fc0b1f test(discussion): atomically clear mention searchbox to kill CI flake
8f3c799b8f test(relationship): reset family_member flag in setFamilyMember network test
Compare 172 commits »
marcel merged pull request marcel/familienarchiv#663 2026-05-28 15:05:51 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets