• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#663 2026-05-28 11:11:23 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

Nora "NullX" Steiner — Application Security Engineer (round 3 re-review)

Verdict: Approved

The single blocker from round 2 — real-identity PII committed to git — has been removed…

marcel commented on pull request marcel/familienarchiv#663 2026-05-28 11:10:51 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

Tobias Wendt — DevOps & Platform Engineer (round 3 re-review)

Verdict: Approved

Round-2 ops blockers are addressed. Runtime surface is unchanged (no new compose service, no new port,…

marcel commented on pull request marcel/familienarchiv#663 2026-05-28 11:10:25 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

Felix Brandt — Senior Fullstack Developer (round 3 re-review)

Verdict: Approved

This is the round I was hoping for. Every concrete clean-code concern I raised in round 2 is fixed with…

marcel commented on pull request marcel/familienarchiv#663 2026-05-28 11:09:55 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

Markus Keller — Senior Application Architect (round 3 re-review)

Verdict: Approved

The architectural shape was already sound in round 2; the round-2 concerns I flagged at the…

marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-28 10:46:01 +02:00
f80dda74f0 chore(lint): enable svelte/no-at-html-tags as primary XSS guard
22603a4b04 test(persons): cover review form actions in server spec
461a8b125d fix(persons): use danger semantic tokens for review error pill
a670ba014c feat(persons): add confirm dialog to provisional confirm action
a9cac08f3c fix(persons): guard review form actions with hasWriteAll server-side
Compare 9 commits »
marcel commented on pull request marcel/familienarchiv#663 2026-05-28 10:10:25 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

📋 Elicit — Senior Requirements Engineer (Brownfield Mode)

Verdict: ⚠️ Approved with concerns

The work is well-specified — there's an ADR, a multi-document spec under `docs/import-migra…

marcel commented on pull request marcel/familienarchiv#663 2026-05-28 10:09:50 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

🎨 Leonie Voss — UI/UX Lead & Accessibility Advocate

Verdict: ⚠️ Approved with concerns

The new UI follows the brand system carefully — semantic tokens, 44px touch targets, focus-visibl…

marcel commented on pull request marcel/familienarchiv#663 2026-05-28 10:09:15 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

🧪 Sara Holt — Senior QA Engineer

Verdict: ⚠️ Approved with concerns

This is one of the cleanest test-suite additions I've reviewed: 22 new/modified test files spanning unit (Mockito),…

marcel commented on pull request marcel/familienarchiv#663 2026-05-28 10:08:37 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: 🚫 Changes requested

Application-layer security in this PR is genuinely good — among the best path-traversal defense…

marcel commented on pull request marcel/familienarchiv#663 2026-05-28 10:08:01 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

The runtime/infrastructure surface is tight. The concerns are about build-time artifacts ending up in…

marcel commented on pull request marcel/familienarchiv#663 2026-05-28 10:07:31 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Clean code, strong TDD evidence, good Svelte 5 / Spring Boot 4 idiom. The thing that keeps this from a…

marcel commented on pull request marcel/familienarchiv#663 2026-05-28 10:07:00 +02:00
Import normalizer: offline tool to normalize the raw archive spreadsheets

🏛️ Markus Keller — Senior Application Architect

Verdict: ⚠️ Approved with concerns

The architectural shape is excellent — schema-first via Flyway, header-mapped reader as a seam,…

marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-28 09:16:13 +02:00
07300aeff7 fix(person): flip family_member on both endpoints when a family-graph relationship is added
marcel deleted branch fix/dev-docker-actuator-port-and-node22 from marcel/familienarchiv 2026-05-28 09:12:32 +02:00
marcel pushed to main at marcel/familienarchiv 2026-05-28 09:12:32 +02:00
643d504c7a fix(docker): bump frontend image to Node 22 for pdfjs-dist engine requirement
c9f5f6d665 fix(docker): point dev backend healthcheck at management port 8081
Compare 2 commits »
marcel merged pull request marcel/familienarchiv#688 2026-05-28 09:12:31 +02:00
fix(docker): repair dev stack after observability merge (actuator port + Node 22)
marcel created pull request marcel/familienarchiv#688 2026-05-27 22:46:57 +02:00
fix(docker): repair dev stack after observability merge (actuator port + Node 22)
marcel created branch fix/dev-docker-actuator-port-and-node22 in marcel/familienarchiv 2026-05-27 22:46:42 +02:00
marcel pushed to fix/dev-docker-actuator-port-and-node22 at marcel/familienarchiv 2026-05-27 22:46:42 +02:00
643d504c7a fix(docker): bump frontend image to Node 22 for pdfjs-dist engine requirement
c9f5f6d665 fix(docker): point dev backend healthcheck at management port 8081
Compare 2 commits »
marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-27 22:17:06 +02:00
9d9cd644ec Merge remote-tracking branch 'origin/main' into HEAD
3f3d5e530c test(dashboard): add missing tag tree mock to recentDocs reader test
5dac1d993c fix(themen): correct link color and tag navigation route
264d60c855 feat(themen): cap ThemenWidget at 6 tags — link to /themen for full list
e6a0c2f6d6 feat(dashboard): move ThemenWidget to full-width position
Compare 18 commits »