marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel deleted branch worktree-feat+issue-557-upload-artifact-v3-pin from marcel/familienarchiv 2026-05-14 10:58:21 +02:00
marcel closed issue marcel/familienarchiv#557 2026-05-14 10:58:20 +02:00
ci(devops): downgrade actions/upload-artifact v4 → v3 (re-regression — needs ADR to prevent future re-upgrade)
marcel merged pull request marcel/familienarchiv#558 2026-05-14 10:58:20 +02:00
ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard
marcel created pull request marcel/familienarchiv#561 2026-05-14 10:58:18 +02:00
fix(ci): add IMPORT_HOST_DIR stub to compose-idempotency job
5ce0856178 fix(ci): add IMPORT_HOST_DIR stub to compose-idempotency env file
marcel closed issue marcel/familienarchiv#554 2026-05-14 10:37:38 +02:00
audit: factory mocks → prop injection migration (sveltest pattern)
marcel commented on issue marcel/familienarchiv#554 2026-05-14 10:37:35 +02:00
audit: factory mocks → prop injection migration (sveltest pattern)

Audit complete. Report filed as #560.

Results: 87 in-scope call sites across 12 mocked modules — 72 → __mocks__/ redirect, 10 → prop-injection, 5 → keep as factory. Full classification…

marcel opened issue marcel/familienarchiv#560 2026-05-14 10:37:24 +02:00
audit report: factory vi.mock → prop-injection / __mocks__ migration (87 call sites, 12 modules)
marcel commented on pull request marcel/familienarchiv#558 2026-05-14 10:18:41 +02:00
ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

Fix applied — 22538e32 adds the negative self-test case from Sara's review.

The guard self-test now asserts both directions:

  • @v5 is caught (positive case — was already present) -…
22538e32a7 ci(unit-tests): add negative self-test case to upload-artifact guard
marcel deleted branch worktree-chore+issue-556-drop-client-branches-coverage-gate from marcel/familienarchiv 2026-05-14 10:16:55 +02:00
marcel pushed to main at marcel/familienarchiv 2026-05-14 10:16:54 +02:00
582191d014 docs(adr-013): set exact baseline to 75% (confirmed in CI)
118100e58d chore(coverage): drop client branches threshold 80→75, add ADR-013
Compare 2 commits »
marcel closed issue marcel/familienarchiv#556 2026-05-14 10:16:53 +02:00
ci(coverage): drop client-project branches threshold 80 → 70 to unblock CI
marcel merged pull request marcel/familienarchiv#559 2026-05-14 10:16:53 +02:00
chore(coverage): drop client branches threshold 80→75 to unblock CI
marcel commented on pull request marcel/familienarchiv#558 2026-05-14 09:05:47 +02:00
ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

What I checked

This PR contains no UI changes, no frontend components, and no user-facing screens. There…

marcel commented on pull request marcel/familienarchiv#558 2026-05-14 09:05:41 +02:00
ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

📋 Elicit — Senior Requirements Engineer

Verdict: ✅ Approved

What I checked

Acceptance criteria completeness, traceability from issue decisions to PR, and requirement quality.

###…

marcel commented on pull request marcel/familienarchiv#558 2026-05-14 09:05:33 +02:00
ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

What I checked

Guard test coverage, AC completeness, and verification strategy.

Findings

####…

marcel commented on pull request marcel/familienarchiv#558 2026-05-14 09:05:25 +02:00
ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

What I checked

Supply chain security of the pin, secrets exposure in the guard step, and overall CI…

marcel commented on pull request marcel/familienarchiv#558 2026-05-14 09:05:18 +02:00
ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I checked

Workflow correctness, guard scope, CI behavior, and pin motivation.

One tension to name…