marcel

marcel commented on pull request marcel/familienarchiv#582

2026-05-14 15:27:06 +02:00

feat(invites): assign groups when creating an invite link (#566)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

Concerns

Missing input validation on groupIds in invite creation

groupIds…

marcel commented on pull request marcel/familienarchiv#582

2026-05-14 15:26:51 +02:00

feat(invites): assign groups when creating an invite link (#566)

🏛️ Markus Keller — Senior Application Architect

Verdict: ⚠️ Approved with concerns

Blockers

**Missing database-level FK — referential integrity is purely application-enforced…

marcel commented on pull request marcel/familienarchiv#582

2026-05-14 15:26:35 +02:00

feat(invites): assign groups when creating an invite link (#566)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: 🚫 Changes requested

Blockers

**UserGroupsSection.svelte — bind:group on a $derived value is incorrect Svelte…

marcel pushed to feat/issue-533-mass-import-ux at marcel/familienarchiv

2026-05-14 15:25:05 +02:00

b0cf35cf06 fix(test): replace toBeAttached() with querySelector not-null check for spinner

marcel created pull request marcel/familienarchiv#582

2026-05-14 15:21:54 +02:00

feat(invites): assign groups when creating an invite link (#566)

marcel commented on issue marcel/familienarchiv#566

2026-05-14 15:21:44 +02:00

feat(admin): assign groups when creating an invite link

Implementation complete ✅

Branch: feat/issue-566-invite-group-picker

Commits

d7fcbfd4 feat(groups): prevent deletion of groups referenced by active invites
- `ErrorCode.GROUP…

marcel created branch feat/issue-566-invite-group-picker in marcel/familienarchiv

2026-05-14 15:21:34 +02:00

marcel pushed to feat/issue-566-invite-group-picker at marcel/familienarchiv

2026-05-14 15:21:34 +02:00

82e61291d4 feat(invites): group picker in new-invite form

a1b319a535 feat(frontend): add GROUP_HAS_ACTIVE_INVITES error code + i18n keys

d7fcbfd4d9 feat(groups): prevent deletion of groups referenced by active invites

Compare 3 commits »

marcel pushed to feat/issue-533-mass-import-ux at marcel/familienarchiv

2026-05-14 15:14:52 +02:00

0d934a1b44 fix(test): use m() calls and toBeAttached() in ImportStatusCard tests

marcel opened issue marcel/familienarchiv#581

2026-05-14 15:05:59 +02:00

docs: document observability stack in DEPLOYMENT.md and CLAUDE.md

marcel opened issue marcel/familienarchiv#580

2026-05-14 15:05:44 +02:00

feat(backend): integrate sentry-spring-boot-starter for exception reporting to GlitchTip

marcel opened issue marcel/familienarchiv#579

2026-05-14 15:05:33 +02:00

feat(frontend): integrate @sentry/sveltekit for browser and SSR error reporting to GlitchTip

marcel opened issue marcel/familienarchiv#578

2026-05-14 15:05:09 +02:00

devops(observability): add GlitchTip error tracking infrastructure (GlitchTip + worker + Redis)

marcel opened issue marcel/familienarchiv#577

2026-05-14 15:04:53 +02:00

devops(observability): add Grafana with provisioned Prometheus, Loki, and Tempo data sources and pre-imported dashboards

marcel opened issue marcel/familienarchiv#576

2026-05-14 15:04:35 +02:00

devops(backend): expose Prometheus metrics endpoint + OTLP trace export from Spring Boot

marcel opened issue marcel/familienarchiv#575

2026-05-14 15:04:15 +02:00

devops(observability): add Tempo for distributed trace storage (OTLP receiver)

marcel opened issue marcel/familienarchiv#574

2026-05-14 15:04:05 +02:00

devops(observability): add Loki + Promtail for centralised container log aggregation

marcel opened issue marcel/familienarchiv#573

2026-05-14 15:03:52 +02:00

devops(observability): add Prometheus + Node Exporter + cAdvisor for host and container metrics

marcel opened issue marcel/familienarchiv#572

2026-05-14 15:03:38 +02:00

devops(observability): scaffold docker-compose.observability.yml and infra/observability/ directory structure

marcel commented on pull request marcel/familienarchiv#569

2026-05-14 14:47:16 +02:00

ui(admin/system): improve mass-import card (loading state, i18n, font size)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ⚠️ Approved with concerns

The spinner has role="status" + aria-label + motion-reduce:animate-none — this is…