marcel

marcel deleted branch worktree-chore+issue-556-drop-client-branches-coverage-gate from marcel/familienarchiv

2026-05-14 10:16:55 +02:00

marcel pushed to main at marcel/familienarchiv

2026-05-14 10:16:54 +02:00

582191d014 docs(adr-013): set exact baseline to 75% (confirmed in CI)

118100e58d chore(coverage): drop client branches threshold 80→75, add ADR-013

Compare 2 commits »

marcel closed issue marcel/familienarchiv#556

2026-05-14 10:16:53 +02:00

ci(coverage): drop client-project branches threshold 80 → 70 to unblock CI

marcel merged pull request marcel/familienarchiv#559

2026-05-14 10:16:53 +02:00

chore(coverage): drop client branches threshold 80→75 to unblock CI

marcel commented on pull request marcel/familienarchiv#558

2026-05-14 09:05:47 +02:00

ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

What I checked

This PR contains no UI changes, no frontend components, and no user-facing screens. There…

marcel commented on pull request marcel/familienarchiv#558

2026-05-14 09:05:41 +02:00

ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

📋 Elicit — Senior Requirements Engineer

Verdict: ✅ Approved

What I checked

Acceptance criteria completeness, traceability from issue decisions to PR, and requirement quality.

###…

marcel commented on pull request marcel/familienarchiv#558

2026-05-14 09:05:33 +02:00

ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

What I checked

Guard test coverage, AC completeness, and verification strategy.

Findings

####…

marcel commented on pull request marcel/familienarchiv#558

2026-05-14 09:05:25 +02:00

ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

What I checked

Supply chain security of the pin, secrets exposure in the guard step, and overall CI…

marcel commented on pull request marcel/familienarchiv#558

2026-05-14 09:05:18 +02:00

ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

What I checked

Workflow correctness, guard scope, CI behavior, and pin motivation.

One tension to name…

marcel commented on pull request marcel/familienarchiv#558

2026-05-14 09:05:12 +02:00

ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

🏗️ Markus Keller — Senior Application Architect

Verdict: ✅ Approved

What I checked

ADR quality and numbering, documentation currency, and consistency with the repo's existing…

marcel commented on pull request marcel/familienarchiv#558

2026-05-14 09:05:06 +02:00

ci(devops): downgrade upload-artifact v4 → v3 + ADR-014 + grep guard

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

What I checked

No production code changed — this is pure CI/infra. My review focused on guard step quality and…

marcel pushed to worktree-chore+issue-556-drop-client-branches-coverage-gate at marcel/familienarchiv

2026-05-14 09:04:17 +02:00

582191d014 docs(adr-013): set exact baseline to 75% (confirmed in CI)

marcel commented on pull request marcel/familienarchiv#559

2026-05-14 08:57:46 +02:00

chore(coverage): drop client branches threshold 80→75 to unblock CI

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ✅ Approved

What I checked

UI/UX surface, component impact, accessibility test coverage.

Findings

No…

marcel commented on pull request marcel/familienarchiv#559

2026-05-14 08:57:40 +02:00

chore(coverage): drop client branches threshold 80→75 to unblock CI

📋 Elicit — Requirements Engineer & Business Analyst

Verdict: ✅ Approved

What I checked

Acceptance criteria coverage, requirement completeness, and traceability.

Acceptance…

marcel commented on pull request marcel/familienarchiv#559

2026-05-14 08:57:28 +02:00

chore(coverage): drop client branches threshold 80→75 to unblock CI

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

Context on my usual stance

I quote 80% branch coverage as a floor in most contexts. I am not…

marcel commented on pull request marcel/familienarchiv#559

2026-05-14 08:57:16 +02:00

chore(coverage): drop client branches threshold 80→75 to unblock CI

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

What I checked

Security surface of the change and the ADR's treatment of security-relevant coverage…

marcel commented on pull request marcel/familienarchiv#559

2026-05-14 08:57:05 +02:00

chore(coverage): drop client branches threshold 80→75 to unblock CI

🔧 Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

What I checked

CI workflows, threshold change, and the headroom arithmetic.

Observations

**The…

marcel commented on pull request marcel/familienarchiv#559

2026-05-14 08:56:53 +02:00

chore(coverage): drop client branches threshold 80→75 to unblock CI

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ✅ Approved

What I checked

One config line changed, one ADR created — no production code, no test code. TDD red/green cycle…

marcel commented on pull request marcel/familienarchiv#559

2026-05-14 08:56:42 +02:00

chore(coverage): drop client branches threshold 80→75 to unblock CI

🏛️ Markus Keller — Senior Application Architect

Verdict: ✅ Approved

What I checked

This is a CI-gate adjustment with an ADR — exactly the right shape for lowering a quality bar…

marcel created pull request marcel/familienarchiv#559

2026-05-14 08:55:46 +02:00

chore(coverage): drop client branches threshold 80→75 to unblock CI