marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel closed issue marcel/familienarchiv#667 2026-05-27 18:25:23 +02:00
As a reader I want a clean persons directory so I'm not overwhelmed by unconfirmed import entries
marcel pushed to docs/import-migration at marcel/familienarchiv 2026-05-27 18:25:23 +02:00
929acf6964 style(persons): apply prettier formatting to PersonCard hasNoName derived
362672cdbf test(person): pin query count-parity and delete FK-detach ordering
1e3e420860 fix(person): report honest totals on the non-paged top-N persons path
3a758393bf refactor(shared): extract hasWriteAll(locals) permission helper
1a0be4130e fix(persons): make the show-all switch accessible name match its visible text
Compare 15 commits »
marcel merged pull request marcel/familienarchiv#679 2026-05-27 18:25:22 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)
marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:26:37 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

Elicit — Requirements Engineer & Business Analyst

Verdict: Approved with concerns

I'm assessing this against the stated need: stop ~942 provisional import entries from drowning readers…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:26:16 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

No infrastructure surface in this PR — no Compose changes, no CI workflow edits, no new service, no Dockerfile, no env vars,…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:26:03 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

Leonie Voss — UI/UX & Accessibility

Verdict: Approved with concerns

I reviewed touch targets, color-independence, the role="switch" accessible name, semantics, and the 320px story. The…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:25:41 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

Sara Holt — Senior QA Engineer

Verdict: Approved

The test pyramid for this PR is well-shaped: fast unit/slice tests for the controller and service, real-Postgres integration tests for…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:25:25 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

Felix Brandt — Senior Fullstack Developer

Verdict: Approved with one concern

Clean diff. The fixes from the prior round are genuinely resolved, and the component split is what I'd have…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:25:04 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved

Threat model for this PR: mass-assignment of the provisional flag, authorization on the two new write verbs, SQL…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:24:48 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

Markus Keller — Senior Application Architect

Verdict: Approved

I reviewed the boundaries, the paging contract, the DB integrity story, and the documentation currency. This round resolves…

marcel opened issue marcel/familienarchiv#681 2026-05-27 14:22:41 +02:00
Add index on document_receivers(person_id) for per-person document counts
marcel opened issue marcel/familienarchiv#680 2026-05-27 14:22:01 +02:00
CI: guard against generated frontend api.ts drift
marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:21:48 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

Review concerns addressed (7 commits, all Refs #667)

Thanks all — every raised concern is fixed in-PR. Autonomous pass (owner unreachable); decisions noted below.

marcel pushed to feature/667-persons-directory at marcel/familienarchiv 2026-05-27 14:21:25 +02:00
929acf6964 style(persons): apply prettier formatting to PersonCard hasNoName derived
362672cdbf test(person): pin query count-parity and delete FK-detach ordering
1e3e420860 fix(person): report honest totals on the non-paged top-N persons path
3a758393bf refactor(shared): extract hasWriteAll(locals) permission helper
1a0be4130e fix(persons): make the show-all switch accessible name match its visible text
Compare 7 commits »
marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:04:44 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

📋 "Elicit" — Requirements Engineer

Verdict: ⚠️ Approved with concerns (Brownfield: feature-vs-spec audit of #667)

The core requirement — *stop drowning readers in ~942 provisional…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:04:27 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ✅ Approved

No infra surface in this PR — no Compose, CI workflow, Dockerfile, env var, or migration changed. So this is mostly a…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:04:18 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

🎨 Leonie Voss — UX & Accessibility

Verdict: ⚠️ Approved with concerns

A lot to like for the dual audience. Filter chips are min-h-[44px] min-w-[44px] in a labelled role="group",…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:04:03 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

The test design here is genuinely good. Filter/count parity — the exact bug class that bites paginated endpoints — is…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:03:48 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

🏛️ Markus Keller — Application Architect

Verdict: ⚠️ Approved with concerns

The structure is sound and the boundaries hold. PersonSearchResult mirrors DocumentSearchResult…

marcel commented on pull request marcel/familienarchiv#679 2026-05-27 14:03:33 +02:00
feat(persons): clean filterable directory + triage UI (Phase 5, #667)

🛡️ Nora "NullX" Steiner — Application Security Engineer

Verdict: ✅ Approved

I went looking for the four classic failure modes on a feature like this — SQL injection in the native…