• Joined on 2026-03-17
marcel pushed to feature/668-undated-documents at marcel/familienarchiv 2026-05-27 19:55:13 +02:00
45e63307bb fix(documents): give the undated count chip a self-describing a11y name
995471082e test(documents): update obsolete em-dash assertion to undated badge
Compare 2 commits »
marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:48:32 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

⚙️ Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved (LGTM)

Nothing in my domain to block. I checked for: Docker Compose changes, CI workflow changes, Flyway migrations,…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:48:25 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

📋 Elicit — Requirements Engineer / Business Analyst

Verdict: Approved (Brownfield review)

I checked the two recent changes against the stated requirement for #668 — "undated/imprecis…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:48:12 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ⚠️ Approved with concerns

I designed for the hardest case first: a 67-year-old researcher scanning a list of letters,…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:47:55 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

🧪 Sara Holt — Senior QA Engineer

Verdict: Approved

Coverage of the two recent changes

Em-dash / badge — covered at the right layer (component, real DOM via vitest-browser):…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:47:42 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

🛡️ Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved

I reviewed the new attack surface introduced by this PR with a clean eye.

New query param undated —…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:47:30 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

🏛️ Markus Keller — Application Architect

Verdict: Approved

Layer boundaries

Clean. The undated predicate lives in DocumentSpecifications.undatedOnly(boolean) (returns null

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:47:18 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: Approved

Clean reviewer, no prior context — I read the diff and the touched source at the head ref, not the old comment…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:43:44 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Undated count: page-local → global (owner decision)

Replaced the page-local undated count with a global one. Previously the only undated tally was the year-grouping Undatiert bucket in…

marcel pushed to feature/668-undated-documents at marcel/familienarchiv 2026-05-27 19:43:26 +02:00
c6137a26a2 feat(documents): show global undated count chip on the filter toggle
a3c3f14aea feat(documents): return global undated count in search response
Compare 2 commits »
marcel pushed to feature/668-undated-documents at marcel/familienarchiv 2026-05-27 19:17:42 +02:00
19cd17d9cd fix(documents): always render undated badge in DocumentRow desktop column
marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:13:42 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Elicit — Requirements Engineer & Business Analyst

Verdict: Approved with concerns

I reviewed this against the #668 acceptance criteria, edge-case coverage, ambiguity, and two unresolved…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:13:21 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Leonie Voss — UX Designer & Accessibility Strategist

Verdict: Approved

I reviewed brand compliance, WCAG (contrast, touch targets, non-color cues, focus), and the 320px / senior-audience…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:13:08 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

I checked for infrastructure impact, CI implications, and migration/deploy risk.

Findings

  • No infra surface touched.
marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:12:58 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Nora Steiner ("NullX") — Application Security Engineer

Verdict: Approved

I reviewed the new query param for injection, authorization, mass-assignment, and untrusted-input rendering.

###…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:12:42 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Sara Holt — Senior QA Engineer

Verdict: Approved with concerns

I assessed the test pyramid, determinism, real-infra coverage, and boundary cases. CI owns the full sweep; I reviewed by…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:12:28 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Felix Brandt — Senior Fullstack Developer

Verdict: Approved

I checked TDD evidence, naming, function size, guard clauses, Svelte 5 rules, and dead code.

TDD evidence — solid

The…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:12:13 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Markus Keller — Senior Application Architect

Verdict: Approved

I reviewed module boundaries, the layering rule, database-vs-application enforcement, and documentation currency.

What…

marcel opened issue marcel/familienarchiv#683 2026-05-27 19:10:23 +02:00
Extract a SearchFilters record for the document search signatures
marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:10:11 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Felix Brandt — review concerns addressed

Pushed four atomic commits to feature/668-undated-documents. Red→green throughout; backend touched classes and frontend node-vitest + lint all…