marcel
0 Followers · 0 Following
  • Joined on 2026-03-17
Repositories
3
 Projects Packages Public Activity Starred Repositories
marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:13:08 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

I checked for infrastructure impact, CI implications, and migration/deploy risk.

Findings

  • No infra surface touched.…
marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:12:58 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Nora Steiner ("NullX") — Application Security Engineer

Verdict: Approved

I reviewed the new query param for injection, authorization, mass-assignment, and untrusted-input rendering.

###…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:12:42 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Sara Holt — Senior QA Engineer

Verdict: Approved with concerns

I assessed the test pyramid, determinism, real-infra coverage, and boundary cases. CI owns the full sweep; I reviewed by…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:12:28 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Felix Brandt — Senior Fullstack Developer

Verdict: Approved

I checked TDD evidence, naming, function size, guard clauses, Svelte 5 rules, and dead code.

TDD evidence — solid

The…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:12:13 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Markus Keller — Senior Application Architect

Verdict: Approved

I reviewed module boundaries, the layering rule, database-vs-application enforcement, and documentation currency.

What…

marcel opened issue marcel/familienarchiv#683 2026-05-27 19:10:23 +02:00
Extract a SearchFilters record for the document search signatures
marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:10:11 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Felix Brandt — review concerns addressed

Pushed four atomic commits to feature/668-undated-documents. Red→green throughout; backend touched classes and frontend node-vitest + lint all…

marcel pushed to feature/668-undated-documents at marcel/familienarchiv 2026-05-27 19:09:53 +02:00
508575eccb refactor(documents): collapse redundant span nesting in DocumentDate else branch
85372e3669 fix(documents): enlarge undated badge text to text-xs for legibility
caec92e7de test(document): lock undated-stays-in-sender-group with ordered multi-sender assertions
eacfd15f8e refactor(document): revert resolveSort to private
Compare 4 commits »
marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:01:21 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

Nothing in my domain to flag, but I checked the things that bite at deploy time rather than just rubber-stamping.

Infra…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:01:08 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Elicit — Requirements Engineer (Brownfield)

Verdict: Approved with concerns

I assessed this against the issue it closes (#668, "honest handling of undated/imprecise documents") and the…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:00:51 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Leonie Voss — UX Designer & Accessibility Strategist

Verdict: Approved with concerns

This is honest-by-design UX done right: an undated letter is rendered as a neutral absence, not an…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:00:32 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved

I reviewed the new undated parameter end-to-end for authz, injection, and input handling. No vulnerabilities, no…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:00:20 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Sara Holt — QA Engineer

Verdict: Approved with concerns

Strong test work. Real Postgres for the null-date guarantees, MockMvc for the authz boundary, browser specs for the badge/toggle,…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 19:00:00 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Markus Keller — Application Architect

Verdict: Approved

I reviewed this for layer boundaries, where the null-date semantics are enforced, and documentation currency.

Boundaries —…

marcel commented on pull request marcel/familienarchiv#682 2026-05-27 18:59:46 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)

Felix Brandt — Senior Fullstack Developer

Verdict: Approved with concerns

I read the full diff and the touched source files. The TDD discipline is visible — every behavioral change has…

marcel created pull request marcel/familienarchiv#682 2026-05-27 18:57:41 +02:00
feat(documents): honest handling of undated documents in browse & search (Phase 6, #668)
marcel pushed to feature/668-undated-documents at marcel/familienarchiv 2026-05-27 18:57:24 +02:00
a345bba74b test(activity): assert Chronik rows never fabricate a letter date
098c2c9def feat(documents): add a "Nur undatierte" filter toggle wired to the URL
5d8bb70255 feat(documents): explain that a date range excludes undated documents
bca3f34cec feat(documents): badge undated rows instead of a bare em-dash
f1fc3dc1ce feat(documents): thread undated filter through the search loader + i18n
Compare 8 commits »
marcel created branch feature/668-undated-documents in marcel/familienarchiv 2026-05-27 18:57:23 +02:00
marcel commented on issue marcel/familienarchiv#668 2026-05-27 18:56:50 +02:00
As a reader I want undated and imprecisely-dated letters to be honestly labelled in browse views so I always understand a document's date position

Implemented on feature/668-undated-documents (committed locally, not pushed)

8 atomic commits, red/green TDD throughout. Branch base: docs/import-migration.

NULLS-LAST across every…

marcel deleted branch feature/667-persons-directory from marcel/familienarchiv 2026-05-27 18:25:24 +02:00