• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#605 2026-05-16 11:05:13 +02:00
docs: document observability stack in DEPLOYMENT.md and CLAUDE.md (#581)

🎨 Leonie Voss (@leonievoss) — UX Designer & Accessibility Strategist

Verdict: Approved

Scope note

This is a pure documentation PR with no frontend or UI changes. My standard…

marcel commented on pull request marcel/familienarchiv#605 2026-05-16 11:05:03 +02:00
docs: document observability stack in DEPLOYMENT.md and CLAUDE.md (#581)

🧪 Sara Holt (@saraholt) — QA Engineer & Test Strategist

Verdict: Approved

Blockers

None. No code changes means no test coverage delta.

Review focus

For a documentation PR,…

marcel commented on pull request marcel/familienarchiv#605 2026-05-16 11:04:54 +02:00
docs: document observability stack in DEPLOYMENT.md and CLAUDE.md (#581)

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved

No security vulnerabilities. This is a documentation-only PR and I've checked it for the concerns that…

marcel commented on pull request marcel/familienarchiv#605 2026-05-16 11:04:44 +02:00
docs: document observability stack in DEPLOYMENT.md and CLAUDE.md (#581)

📋 Elicit — Requirements Engineer

Verdict: Approved

Blockers

None.

Requirements coverage check

The source issue (#581) asks for observability stack documentation.…

marcel commented on pull request marcel/familienarchiv#605 2026-05-16 11:04:30 +02:00
docs: document observability stack in DEPLOYMENT.md and CLAUDE.md (#581)

🛠️ Tobias Wendt (@tobiwendt) — DevOps & Platform Engineer

Verdict: Approved

This is a clean documentation correction — the kind of hygiene PR that prevents silent failures during…

marcel commented on pull request marcel/familienarchiv#605 2026-05-16 11:04:15 +02:00
docs: document observability stack in DEPLOYMENT.md and CLAUDE.md (#581)

👨‍💻 Felix Brandt (@felixbrandt) — Senior Fullstack Developer

Verdict: Approved

Blockers

None. This is a docs-only PR with no code changes.

Suggestions

  • **`VITE_SENTRY_DSN…
marcel commented on pull request marcel/familienarchiv#605 2026-05-16 11:04:06 +02:00
docs: document observability stack in DEPLOYMENT.md and CLAUDE.md (#581)

🏗️ Markus Keller (@mkeller) — Application Architect

Verdict: ⚠️ Approved with concerns

Blockers

C4 container diagram currency — My documentation-update checklist requires…

marcel commented on issue marcel/familienarchiv#604 2026-05-16 10:57:11 +02:00
fix(obs): wire up Spring Boot metrics and Loki log labels in Grafana

🗳️ Decision Queue — Action Required

1 decision needs your input before implementation starts.

Security / Architecture

  • Fix 3 should NOT be implemented as written — the issue…
marcel commented on issue marcel/familienarchiv#604 2026-05-16 10:57:05 +02:00
fix(obs): wire up Spring Boot metrics and Loki log labels in Grafana

🎨 Leonie Voss — UX Designer & Accessibility Strategist

No UX concerns for this issue. This is a pure backend/infrastructure observability fix with no frontend component or user-facing…

marcel commented on issue marcel/familienarchiv#604 2026-05-16 10:56:59 +02:00
fix(obs): wire up Spring Boot metrics and Loki log labels in Grafana

📋 Elicit — Requirements Engineer

Observations

This is a well-specified bug report. Root causes are precise, fixes are concrete, and acceptance criteria are specific and testable. The…

marcel commented on issue marcel/familienarchiv#604 2026-05-16 10:56:49 +02:00
fix(obs): wire up Spring Boot metrics and Loki log labels in Grafana

🧪 Sara Holt — QA Engineer & Test Strategist

Observations

  • All 6 acceptance criteria are manual verification steps against a running Grafana instance. There is no automated test…
marcel commented on issue marcel/familienarchiv#604 2026-05-16 10:56:38 +02:00
fix(obs): wire up Spring Boot metrics and Loki log labels in Grafana

🛡️ Nora "NullX" Steiner — Application Security Engineer

Observations

Fix 3 as described introduces a security mistake, even though it would be a no-op.

The issue proposes:

a
marcel commented on issue marcel/familienarchiv#604 2026-05-16 10:56:28 +02:00
fix(obs): wire up Spring Boot metrics and Loki log labels in Grafana

👨‍💻 Felix Brandt — Senior Fullstack Developer

Observations

  • This issue is primarily infra config. The code changes are small: one new relabel rule in a YAML file and one comment…
marcel commented on issue marcel/familienarchiv#604 2026-05-16 10:56:17 +02:00
fix(obs): wire up Spring Boot metrics and Loki log labels in Grafana

🏗️ Markus Keller — Senior Application Architect

Observations

  • The separate management port (management.server.port: 8081) is the architecturally correct approach and is already in…
marcel created pull request marcel/familienarchiv#605 2026-05-16 10:54:50 +02:00
docs: document observability stack in DEPLOYMENT.md and CLAUDE.md (#581)
marcel created branch feat/issue-581-obs-docs in marcel/familienarchiv 2026-05-16 10:54:33 +02:00
marcel pushed to feat/issue-581-obs-docs at marcel/familienarchiv 2026-05-16 10:54:33 +02:00
2e864e5b81 docs(infra): remove stale 'observability not yet deployed' note
40d9713b79 docs(deployment): fix stale GlitchTip image tags and add SENTRY_DSN to env vars table
68d07fe961 docs(claude): add observability service table and env var reference
Compare 3 commits »
marcel opened issue marcel/familienarchiv#604 2026-05-16 10:52:30 +02:00
fix(obs): wire up Spring Boot metrics and Loki log labels in Grafana
marcel pushed to main at marcel/familienarchiv 2026-05-16 10:31:25 +02:00
6145a25fe2 fix(obs): correct GlitchTip port and healthcheck for v6.x
marcel pushed to main at marcel/familienarchiv 2026-05-16 10:20:12 +02:00
c43f45a472 Merge branch 'fix/issue-601-obs-stack-permanent'
134f1e2ae0 chore(runner): mount /opt/familienarchiv into job containers
55ccd5f3c0 ci(obs): replace rsync with rm+cp in deploy step
Compare 3 commits »