• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:33:14 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ⚠️ Approved with concerns

Blockers

1. Delete button extends outside the annotation bounds — risk of clipping

T…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:32:54 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🔒 Nora Steiner ("NullX") — Application Security Engineer

Verdict: ⚠️ Approved with concerns

Blockers

**1. Unchecked DELETE response for orphaned annotations — silent auth bypass…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:32:38 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🏛️ Markus Keller — Application Architect

Verdict: Approved

What I checked

Prop chain depth — The feature adds a new prop through 5 layers: `+page.svelte → DocumentViewer…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:32:19 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Blockers

**1. Unchecked fetch response in the orphaned-annotation fallback (+page.svelte line…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:29:53 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

📋 Elicit — Requirements Engineer

Verdict: Approved

All three acceptance criteria from issue #344 are met. The Decision Queue resolutions are correctly implemented. The concern from…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:29:32 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

🎨 Leonie Voss — UI/UX Design Lead (@leonievoss)

Verdict: Approved

The implementation matches the design intent from issue #344. Cursor behavior is correct, tooltips are present in…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:29:18 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

🧪 Sara Holt — QA Engineer (@saraholt)

Verdict: Approved

The missing ThemeToggle.svelte.spec.ts concern from the previous review round has been addressed in commit 3. All 9 tests…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:29:00 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

🔒 Nora Steiner — Application Security Engineer (@NullX)

Verdict: Approved

No security concerns. Confirmed clean.

What I checked

**XSS / injection via title and aria-label

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:28:48 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

⚙️ Tobias Wendt — DevOps & Platform Engineer (@tobiwendt)

Verdict: Approved

No infrastructure changes. No new dependencies. Frontend-only change. Ship it.

What I checked

  • **New…
marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:28:35 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

👨‍💻 Felix Brandt — Senior Fullstack Developer (@felixbrandt)

Verdict: Approved

Clean, minimal, and correctly TDD'd. The $derived extractions for both bellLabel and themeLabel

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:28:14 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

🏗️ Markus Keller — Application Architect (@mkeller)

Verdict: Approved

No architectural concerns in this PR. This is a pure frontend cosmetic change — two components touched, one…

marcel pushed to feat/issue-344-bell-tooltip at marcel/familienarchiv 2026-04-26 21:27:28 +02:00
35c2c83996 test(nav): add ThemeToggle spec covering label derivation in both modes
marcel commented on pull request marcel/familienarchiv#349 2026-04-26 21:27:04 +02:00
fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

Decision Queue — Resolved

Both items from the Decision Queue have been actioned as follow-up issues:

Theme A: axe-playwright E2E gate

Issue #353: [test(a11y): add axe-playwright…

marcel opened issue marcel/familienarchiv#354 2026-04-26 21:26:52 +02:00
fix(a11y): increase annotation toggle touch target to 44×44px minimum
marcel opened issue marcel/familienarchiv#353 2026-04-26 21:26:43 +02:00
test(a11y): add axe-playwright E2E gate for PDF viewer WCAG 2.1 AA compliance
marcel commented on pull request marcel/familienarchiv#350 2026-04-26 21:10:25 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

🗳️ Decision Queue

Consolidated from all persona reviews. Decisions needed before merge.


1. E2E timing: page.waitForTimeout(400) → proper Playwright wait

**From Felix (developer)…

marcel commented on pull request marcel/familienarchiv#352 2026-04-26 21:10:18 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)

🗳️ Decision Queue — PR #352

Consolidated open items from the persona reviews that need a decision or follow-up action before or after merge.


Item 1: Button text contrast ratio…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:10:11 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🗳️ Decision Queue — PR #346

Consolidated open decisions and action items surfaced during review. All are non-blocking for merge; the overall verdict is ⚠️ Approved with concerns (Felix,…

marcel commented on pull request marcel/familienarchiv#350 2026-04-26 21:10:00 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

📋 Elicit — Requirements Engineer

Verdict: Approved

What I checked

Acceptance criteria coverage, scope completeness vs. the original issue, new gaps introduced, open decisions…

marcel commented on pull request marcel/familienarchiv#352 2026-04-26 21:09:55 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)

🚀 Tobias Wendt — DevOps & Platform

Verdict: Approved

Infrastructure review

Zero new infrastructure. No schema migration, no Docker Compose change, no new service, no new…