• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:09:04 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

What I checked

Test pyramid coverage, test naming, reliability, and missing scenarios.

Blockers

**The orphaned-ann…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:09:04 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

🧪 Sara Holt — QA Engineer (@saraholt)

Verdict: ⚠️ Approved with concerns

The NotificationBell tests are well-structured and cover the right behaviors. One gap: ThemeToggle has no…

marcel commented on pull request marcel/familienarchiv#347 2026-04-26 21:09:02 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

What I checked

Test coverage completeness, TDD evidence, test quality, spec file correctness, and the broader test…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:08:58 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🔒 Nora "NullX" Steiner — Security Engineer

Verdict: Approved

No new attack surface introduced. The page-jump control is a pure navigation component — it reads a derived value,…

marcel commented on pull request marcel/familienarchiv#352 2026-04-26 21:08:55 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)

🔒 Nora "NullX" Steiner — Security Engineer

Verdict: Approved

Security review

Authentication guard — correct. Authentication authentication parameter with `requireUserId(au…

marcel commented on pull request marcel/familienarchiv#350 2026-04-26 21:08:54 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

🔒 Nora "NullX" Steiner — Security Engineer

Verdict: Approved

What I checked

ARIA label correctness, DOM mutation patterns, fetch usage, event handler security, XSS vectors in…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:08:52 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🎨 Leonie Voss — UI/UX Design Lead

Verdict: ⚠️ Approved with concerns

What I checked

Brand compliance, touch targets, accessibility, and 60+ user experience.

Blockers

**`aria-l…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:08:52 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

🔒 Nora Steiner — Application Security Engineer (@NullX)

Verdict: Approved

No security concerns in this change. Confirmed clean.

What I checked

**XSS / injection via title

marcel commented on pull request marcel/familienarchiv#349 2026-04-26 21:08:50 +02:00
fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

🔒 Nora "NullX" Steiner — Application Security Engineer

Verdict: Approved

What I checked

  • XSS surface in changed template markup
  • ARIA label content (no user-controlled data…
marcel commented on pull request marcel/familienarchiv#347 2026-04-26 21:08:47 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Nora "NullX" Steiner — Security Engineer

Verdict: Approved

What I checked

Authorization surface changes, action routing security, CSRF exposure, and any new attack surface…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:08:45 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🚀 Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

Infrastructure footprint for this PR: zero. No new containers, no new npm dependencies, no CI configuration changes,…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:08:43 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

⚙️ Tobias Wendt — DevOps & Platform Engineer (@tobiwendt)

Verdict: Approved

No infrastructure changes. No new dependencies. No Docker Compose, CI pipeline, or environment config…

marcel commented on pull request marcel/familienarchiv#352 2026-04-26 21:08:42 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: Approved

Backend

The service method is clean and readable. Guard clause pattern used correctly: if (!block.isReviewed())

marcel commented on pull request marcel/familienarchiv#349 2026-04-26 21:08:40 +02:00
fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

🏗️ Markus Keller — Senior Application Architect

Verdict: Approved

What I checked

  • Module boundary compliance
  • Separation of concerns
  • Token system integrity
  • Lint rule…
marcel commented on pull request marcel/familienarchiv#347 2026-04-26 21:08:39 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Elicit — Requirements Engineer

Verdict: Approved

What I checked

Acceptance criteria traceability, scope alignment with the Decision Queue resolution, and requirement…

marcel commented on pull request marcel/familienarchiv#350 2026-04-26 21:08:39 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

What I checked

TDD evidence, naming, function size, Svelte 5 rules, ARIA correctness, dead…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:08:38 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🛡️ Nora "NullX" Steiner — Security Expert

Verdict: ⚠️ Approved with concerns

What I checked

Authorization enforcement, error handling, and new API surface.

Blockers

**Orphaned…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:08:37 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

The core implementation is solid and follows the project conventions correctly. $derived.by(),…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:08:35 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

👨‍💻 Felix Brandt — Senior Fullstack Developer (@felixbrandt)

Verdict: Approved

Clean, minimal, and DRY. This is exactly what was discussed in the issue review. The $derived

marcel commented on pull request marcel/familienarchiv#352 2026-04-26 21:08:28 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)

🏗️ Markus Keller — Application Architect

Verdict: Approved

What I checked

The pre-implementation review (issue #345) already locked in the structural decisions: single…