• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:09:50 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

📋 Elicit — Requirements Engineer

Verdict: Approved

All four acceptance criteria from issue #340 are met. The Decision Queue resolutions are implemented correctly. No scope creep. No…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:09:48 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🗳️ Decision Queue — PR #348

Two open decisions and one confirmation needed before merge.


1. Fix aria-label="Löschen"aria-label={m.btn_delete()}

Raised by: Felix,…

marcel commented on pull request marcel/familienarchiv#349 2026-04-26 21:09:48 +02:00
fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

🗳️ Decision Queue — PR #349

Consolidated open decisions from the persona reviews. All original Decision Queue items from issue #341 have been resolved and implemented. The following new…

marcel commented on pull request marcel/familienarchiv#352 2026-04-26 21:09:46 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)

📋 Elicit — Requirements Engineer

Verdict: Approved

AC traceability

marcel commented on pull request marcel/familienarchiv#350 2026-04-26 21:09:46 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

⚙️ Tobias Wendt — DevOps & Platform

Verdict: Approved

What I checked

Build pipeline impact, new file locations, test artifact paths, CI configuration implications.

###…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:09:41 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

🗳️ Decision Queue

One open decision surfaced across the persona reviews. All three Decision Queue items from issue #344 were already resolved and are correctly implemented. This new item is a…

marcel commented on pull request marcel/familienarchiv#352 2026-04-26 21:09:33 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)

🎨 Leonie Voss — UI/UX Designer

Verdict: Approved

What I checked

Placement — correct. Button is in the sticky progress header <div>, right-aligned next to `reviewedCount /…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:09:32 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🎨 Leonie Voss — UI/UX Design Lead

Verdict: Approved

The implementation follows the design recommendations from the Decision Queue exactly. Brand compliance is correct, touch targets…

marcel commented on pull request marcel/familienarchiv#350 2026-04-26 21:09:31 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

🎨 Leonie Voss — UX Design Lead

Verdict: Approved

What I checked

ARIA combobox pattern completeness, keyboard navigation, focus management, touch targets, brand compliance in…

marcel commented on pull request marcel/familienarchiv#349 2026-04-26 21:09:29 +02:00
fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

📋 Elicit — Requirements Engineer

Verdict: Approved

What I checked

  • Acceptance criteria coverage (from issue #341)
  • Traceability from requirements to implementation
  • Scope…
marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:09:27 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

📋 Elicit — Requirements Engineer

Verdict: Approved

All three acceptance criteria from issue #344 are met by this implementation. The Decision Queue resolutions are correctly…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:09:25 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

📋 Elicit — Requirements Engineer

Verdict: Approved

What I checked

Acceptance criteria coverage, edge cases, and NFR completeness.

Findings

**All three acceptance criteria…

marcel commented on pull request marcel/familienarchiv#347 2026-04-26 21:09:25 +02:00
feat(persons): show merge action inline with danger hint, remove Gefahrenzone collapsible (#342)

👨‍💻 Leonie Voss — UI/UX Design Lead

Verdict: ⚠️ Approved with concerns

What I checked

Brand token usage, accessibility, touch targets, danger signal visibility, mobile layout, and…

marcel commented on pull request marcel/familienarchiv#351 2026-04-26 21:09:17 +02:00
feat(nav): add tooltip and cursor:pointer to notification bell, fix ThemeToggle i18n (#344)

🎨 Leonie Voss — UI/UX Design Lead (@leonievoss)

Verdict: Approved

The implementation matches the design intent from issue #344 and follows the project's brand and interaction…

marcel commented on pull request marcel/familienarchiv#349 2026-04-26 21:09:16 +02:00
fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

What I checked

  • CI pipeline impact (does the new lint rule break any existing jobs?)
  • New test file: does it…
marcel commented on pull request marcel/familienarchiv#352 2026-04-26 21:09:14 +02:00
feat(transcription): add "Alle als fertig markieren" bulk action (#345)

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

What's well-covered

The test suite covers the scenarios I'd expect at each layer:

**Service unit tests (`Transcription…

marcel commented on pull request marcel/familienarchiv#346 2026-04-26 21:09:14 +02:00
feat(search): add direct page-jump control to document search pagination (#340)

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

The unit test suite is solid and well-structured. 12 new tests using vitest-browser-svelte with real DOM, role/testid…

marcel commented on pull request marcel/familienarchiv#348 2026-04-26 21:09:13 +02:00
feat(viewer): show delete icon directly on transcription annotation (#339)

🏗️ Tobias Wendt — DevOps & Platform Engineer

Verdict: Approved

What I checked

CI impact, infrastructure changes, and E2E test budget.

Findings

**No infrastructure changes…

marcel commented on pull request marcel/familienarchiv#350 2026-04-26 21:09:12 +02:00
fix(persons): fix person dropdown clipping with fixed positioning and ARIA (#343)

🧪 Sara Holt — QA Engineer

Verdict: ⚠️ Approved with concerns

What I checked

Test coverage completeness, test reliability, layer appropriateness, missing edge cases.

###…

marcel commented on pull request marcel/familienarchiv#349 2026-04-26 21:09:06 +02:00
fix(viewer): fix "Annotieren anzeigen" contrast and add lint rule (#341)

🧪 Sara Holt — QA Engineer & Test Strategist

Verdict: ⚠️ Approved with concerns

What I checked

  • Test coverage completeness for the annotation toggle
  • Test file structure and…