• Joined on 2026-03-17
marcel commented on pull request marcel/familienarchiv#331 2026-04-25 16:09:06 +02:00
feat: bulk metadata edit for existing documents

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Verdict: ⚠️ Approved with concerns

The mental model is right: an additive/replace badge per field is exactly the affordance bulk…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 16:08:27 +02:00
feat: bulk metadata edit for existing documents

👨‍💻 Felix Brandt — Senior Fullstack Developer

Verdict: ⚠️ Approved with concerns

Solid feature. Backend is exemplary — guard clauses, partial-failure shape, transactional boundary…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 16:07:53 +02:00
feat: bulk metadata edit for existing documents

🔐 Nora "NullX" Steiner — Application Security Engineer

Verdict: ⚠️ Approved with concerns

The bulk surface is well-fenced on the perimeter — every new endpoint is annotated with the…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 16:07:48 +02:00
feat: bulk metadata edit for existing documents

🛠️ Tobias Wendt — DevOps & Platform Engineer

Verdict: ⚠️ Approved with concerns

Operationally this is a clean, additive change — no infra moves, no migrations, no new services, no new…

marcel commented on pull request marcel/familienarchiv#331 2026-04-25 16:07:33 +02:00
feat: bulk metadata edit for existing documents

🏗️ Markus Keller — Senior Application Architect

Verdict: ⚠️ Approved with concerns

Solid feature on the whole. Layering is respected (controller → service → repo, tags via `tagService…

marcel created pull request marcel/familienarchiv#331 2026-04-25 16:03:25 +02:00
feat: bulk metadata edit for existing documents
marcel pushed to feat/issue-225-bulk-metadata-edit at marcel/familienarchiv 2026-04-25 16:02:30 +02:00
f13f635161 test(bulk-edit): e2e coverage for selection bar and Massenbearbeitung flow
6d3489d035 feat(bulk-edit): add /documents/bulk-edit route
fa5dc43864 feat(bulk-edit): extend BulkDocumentEditLayout with mode="edit"
d4f32ed5d4 feat(bulk-edit): add BulkSelectionBar and Alle-X-editieren fast path
27e3d290e7 feat(bulk-edit): add canWrite-gated row checkboxes on /documents and /enrich
Compare 10 commits »
marcel created branch feat/issue-225-bulk-metadata-edit in marcel/familienarchiv 2026-04-25 16:02:29 +02:00
marcel pushed to main at marcel/familienarchiv 2026-04-25 16:02:14 +02:00
marcel commented on issue marcel/familienarchiv#225 2026-04-25 15:35:52 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

Implemented & merged to main

12 atomic commits on main (b690c74d..f13f6351). Backend: 1334 tests green. Frontend bulk-edit specs: 69 tests green. Playwright E2E: 5 passed (1 skipped…

marcel pushed to main at marcel/familienarchiv 2026-04-25 15:35:12 +02:00
f13f635161 test(bulk-edit): e2e coverage for selection bar and Massenbearbeitung flow
6d3489d035 feat(bulk-edit): add /documents/bulk-edit route
fa5dc43864 feat(bulk-edit): extend BulkDocumentEditLayout with mode="edit"
d4f32ed5d4 feat(bulk-edit): add BulkSelectionBar and Alle-X-editieren fast path
27e3d290e7 feat(bulk-edit): add canWrite-gated row checkboxes on /documents and /enrich
Compare 12 commits »
marcel commented on issue marcel/familienarchiv#225 2026-04-25 14:09:20 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

📋 Elicit — Requirements Engineer · Cross-page Selection Correction

One additional gap surfaced after the previous comment.


Cross-page selection — store model correction

**Probl…

marcel commented on issue marcel/familienarchiv#225 2026-04-25 14:05:38 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

📋 Elicit — Requirements Engineer · Discussion Follow-up

Working through the open items from my earlier comment and the Decision Queue. All five items resolved.


Item 1 —…

marcel pushed to main at marcel/familienarchiv 2026-04-25 13:11:51 +02:00
b690c74ddf fix(richtlinien): improve examples, copy, and Wikipedia link
marcel commented on issue marcel/familienarchiv#225 2026-04-25 12:48:31 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

🗳️ Decision Queue — Action Required

2 decisions need your input before implementation starts.

Architecture

  • Metadata fetch strategy for the bulk-edit page — The store passes…
marcel commented on issue marcel/familienarchiv#225 2026-04-25 12:48:09 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

🛠️ Tobias Wendt — DevOps & Platform Engineer

Observations

No new infrastructure required. No new Docker services, no new environment variables, no MinIO bucket, no Flyway migration.…

marcel commented on issue marcel/familienarchiv#225 2026-04-25 12:47:58 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

🎨 Leonie Voss — UX Designer & Accessibility Strategist

Observations

The onboarding callout and field-label badges are the right design decisions. Users coming from the single-documen…

marcel commented on issue marcel/familienarchiv#225 2026-04-25 12:47:37 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

🔐 Nora "NullX" Steiner — Application Security Engineer

Observations

The core authorization model is correct. @RequirePermission(WRITE_ALL) on the PATCH endpoint matches every…

marcel commented on issue marcel/familienarchiv#225 2026-04-25 12:47:18 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

📋 Elicit — Requirements Engineer

Observations

The issue is well-specified for a complex feature — field semantics table, UX flow, partial-failure shape, ACs, and out-of-scope list are…

marcel commented on issue marcel/familienarchiv#225 2026-04-25 12:46:58 +02:00
feat: bulk metadata edit for existing documents (select → panel → PATCH)

🧪 Sara Holt — QA Engineer & Test Strategist

Observations

The issue has solid ACs, but several behaviors need explicit test cases that aren't yet implied by the AC list.

**Unit layer…